From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5DDC43219 for ; Tue, 18 Oct 2022 14:50:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACD276B0072; Tue, 18 Oct 2022 10:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C386B0075; Tue, 18 Oct 2022 10:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96AB16B0078; Tue, 18 Oct 2022 10:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8B91B6B0072 for ; Tue, 18 Oct 2022 10:50:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 670121A0FA6 for ; Tue, 18 Oct 2022 14:50:26 +0000 (UTC) X-FDA: 80034356052.24.ED972F8 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf07.hostedemail.com (Postfix) with ESMTP id AB33340032 for ; Tue, 18 Oct 2022 14:50:25 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id EC75A68C4E; Tue, 18 Oct 2022 16:50:21 +0200 (CEST) Date: Tue, 18 Oct 2022 16:50:21 +0200 From: Christoph Hellwig To: Song Liu Cc: Christoph Hellwig , Song Liu , Linux-MM , lkml , Andrew Morton , X86 ML , Peter Zijlstra , Kernel Team , "Edgecombe, Rick P" , "Hansen, Dave" , "urezki@gmail.com" Subject: Re: [RFC v2 0/4] vmalloc_exec for modules and BPF programs Message-ID: <20221018145021.GC20131@lst.de> References: <20221007234315.2877365-1-song@kernel.org> <20221017072607.GA30977@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666104626; a=rsa-sha256; cv=none; b=uP1i2C2C7mVJECpXusCQHWDsA4kQagkG2r9qYGmbIo/cN+lcei1wa+cNuXVEB7tl+y6upL 1wvjAvF+duMi9iNfz22OjejONV9J75v8geYdRo9jbDajIaAX2CNML/O5LmYEYvQX3kASej oTYvlg55M+darJvCMYlNY78gn2+Vfz8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=none (imf07.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666104626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Jc2iz9gJU8Se/iyDqwouPSA9IEWXlRJfXMRqzTgU9U=; b=EtPwsUuycwTj5fOQgFFTsGYXPF10fFLLYUa0wQioruzO0K25tuBBBIsTM6PRdOcNaBHo1u GSqg4f2FlGJQ2zIN1W61Wn/CzVBeYYOcNexp5SYj84WVyN8qKlj8Is8nMcqxVTJT+jmCc7 wh7Noa8K1knCOHCjUbezozSK4X65P6A= X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=none (imf07.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: i7c8ruiwgckh6xc3fgwx4d835rkoiksm X-Rspamd-Queue-Id: AB33340032 X-Rspamd-Server: rspam10 X-HE-Tag: 1666104625-216378 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 17, 2022 at 04:23:52PM +0000, Song Liu wrote: > > Well, nothing explains what the method is to avoid having memory > > that is mapped writable and executable at the same time, which really > > could use some explanation here (and in the main patch as well). > > Thanks for the feedback. I will add this. > > Does the code look good to you? I personally think patch 1, 2, 4 could > ship with a little more work. I only took a quick look and I'm not sure how the W^X actually works. Yes, it alls into the text poke helpers, but how do these work on less than page sized allocations?