From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A92C38A2D for ; Mon, 24 Oct 2022 07:04:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC5C28E0002; Mon, 24 Oct 2022 03:04:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E75E78E0001; Mon, 24 Oct 2022 03:04:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEFBD8E0002; Mon, 24 Oct 2022 03:04:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BFC648E0001 for ; Mon, 24 Oct 2022 03:04:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B64012097A for ; Mon, 24 Oct 2022 07:04:50 +0000 (UTC) X-FDA: 80054955540.03.5B10CE4 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf02.hostedemail.com (Postfix) with ESMTP id 1E5768000D for ; Mon, 24 Oct 2022 07:04:49 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29O6rw90005095; Mon, 24 Oct 2022 07:04:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=afaDR6I8p/cNZz+sX3utmJGiYdOXbLQ2QY04IdCSbnw=; b=dBD16+WqJIrLFWNY9yEBUJqVoY3WAiOu0xF2pgovW4nE8nE+x3qSoLApt14HCYKv7Wjh eM1lOpDLHjFYX8w6Le8A7r3FRna8ShjQxyaCVxXRduCiD9scBKKf7Z396MwxzPaep9FT /IvNQ//hjiaLEsAGj4kBl9XHTEvYA7W2oQBEfZetwc2J4tDM5+K6FTV4fTEc2SLzAIyO d5xa9xqxxr9FNhxWaMSrprZc3CkgUhvTTl64bViFl0bzo5FLPlawj+4W4Sps0joysXld WXRY1fn/UqteR2uXQGuu32WP2flCHYtf8c2caGNq2F9ETFiSqjVQu3pRHRUzhR1E0o5c 5Q== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kc6xdttbb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Oct 2022 07:04:46 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 29O56Kpi004199; Mon, 24 Oct 2022 07:04:46 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kc6y9dgef-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Oct 2022 07:04:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHkWTD0sIUwDIDTANf9JnID2GgwgikFm7kgUnemFbldtnFhUjFWtt13VmdEYVlqzMub7u1TJ87/WxrOXSmaJxvvB01PbjliYcX/n2o+Zi0Ke3qRvEolG/mDLUrgpuyVgoBogh/5p+siYUZFA39OtH+WLVMwf1h+R5QopPlNg1lEpPhndGkPRRdpVKTnqihW+FnEjqwJXvnOGKrAKs9mO/navXLVtmMZ6xlJY2rFDSVjnc/22vF6KHhJLPX4ci1L/7A3ZEK6UJfUI1u8Cx9WF/mt59ZfpPBdsb3sHRv3F7EmCdEE2+av0fqehhJw8N0TlksL8OIUz+lMhY702gjR9Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=afaDR6I8p/cNZz+sX3utmJGiYdOXbLQ2QY04IdCSbnw=; b=ESAD2fPi7u0BbnbI1o2fFWnM8nQjWmgSmSfJT2qC9on9TQ++BveG5YeU+fMdisX2tFy3hp3PVmQelwBwGgAXQACUXVi2GeugdbbSZ45j1arTlhm9pCjhb0EL8KhJ4cVHep3OyKvk/sR3gCzQhyZ+uYxzgXXRx1ViemFpSBuP5o/tKll5dOJ9SG7bKgtwSR9rdtUVzyP0jgDpiBps3yHB19m3D3Gbtki0ul7lF495a2Q8gAspHoVPqW0jMrfqB6WV2f5wNj9RqimOY3uxm0NXDfvXIR4VU18rW5wm7xfDlAzcx+0f72ST++I9Tl8k6cCdRqkfcDUKM5ZOipccJBrXHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afaDR6I8p/cNZz+sX3utmJGiYdOXbLQ2QY04IdCSbnw=; b=QCgqTICgU25Tj3nt3qniXUKon/byefbg44xf9ijfWOJfQ/Nf6DZZGmuPlO+97hBHOi2MnVbO7VUPWKhRSjDCVwMtiP6daevReartpDyppyJvUjezjpJs7raY9exATRJHsF0sor1N31+VTF9DG9FNLHTD1Xs3likUxoh/LaduwFY= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by PH0PR10MB4616.namprd10.prod.outlook.com (2603:10b6:510:34::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct 2022 07:04:44 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::1b8e:540e:10f0:9aec]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::1b8e:540e:10f0:9aec%4]) with mapi id 15.20.5676.031; Mon, 24 Oct 2022 07:04:43 +0000 Date: Mon, 24 Oct 2022 10:04:31 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Wei Yang , akpm@linux-foundation.org Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-mm@kvack.org, Wei Yang , Mel Gorman , Daero Lee Subject: Re: [PATCH] mm/vmscan: reduce double-check if kswapd is not able to sleep Message-ID: <202210231820.4uiXIJeC-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221023080431.30893-1-richard.weiyang@gmail.com> X-ClientProxiedBy: JNAP275CA0070.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::18) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2365:EE_|PH0PR10MB4616:EE_ X-MS-Office365-Filtering-Correlation-Id: 69ebcded-a73d-4e02-abf5-08dab58e070e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jgPKYN5khbO9pvp+w89uwtLMeAfcF3YrV+PEwdekZFXr8GEe+u/2NkKUgMp/4Mft5D0/KRxaWVsfLa5RufdwU63CCNRNQeSW4kYfuHwoZtz2zTjJ4FxfjjrHg7s/Y4kz8xXuvEOY0z7HGAKfmfFTcPKNHVZnGSbwI314OxVqWivsuMClD5Z01eeiuzYkwz+DeWGbDB8whsgGfUs21+5DKgAP6pQoguBDoJn++ZubXQTRHTppMcSq/Bw4WmxKbD45o2y0p+MlAt/w/mIFv6VE+7cfxMrC5Fu+ItQMriJeseFIDfa+EJ8yLhH2zn0vRRRm/3Vdz/ruZpwQ935AAsmTXkz5kPCO3rHw3VOHzlE+oPP1R+YDzoE3ZnVKUeC21HJpWUGAEIgxPHP5/bY00bprY3XHBn/i4P46vGbDXJsaM8wEyNr5Ocq7iS8l4OdJ/Yco9DvT+SQZ1wmuIMxImXORtfFH/r3rDTQNoUo2dsmxCeUmjYcWl0QP+0N4rlG7gp1NtcbprAE7jfe6DR2GO8xec448dmd9BPlsNwOBFmxXK4jPz9osckMNfrGuJY1ihIeS3pSc5JPX6GvAXcKC5Dag6jmzDQpAaNWfYwM/Kd3Fo7Hz3ZCU9U7orJicXWc/Nw8Rou47LCLDQH6AZPrUS4aDfMfAmH10/zENtavterT8k+IX1LmoYOJVcefJg8DwKJBH/ONSXCXAUkcUVuaBDWhLrYb2tnejmawwZEuHLNuGH2DbCK0dqP5hH+eiFGNAtSmeZd0bYSehGfwXNbzAnLIy1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39850400004)(366004)(136003)(451199015)(66556008)(186003)(1076003)(6506007)(36756003)(66476007)(66946007)(9686003)(8936002)(6512007)(26005)(5660300002)(6666004)(38100700002)(86362001)(54906003)(316002)(83380400001)(41300700001)(4326008)(8676002)(44832011)(966005)(6486002)(4001150100001)(2906002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nWD8nWoW5E21klNYTQl8gHNhLa98wjPTGgZnjNVrnLKoqDuReDiV0SZrO1E2?= =?us-ascii?Q?o0FgJXNvH4yRdtlih2sGfuhAQQ0GkCR9KfmIGF2aoT21AOUp95qwZB/Fldts?= =?us-ascii?Q?jA6XteFvziDoyiruLm0N6LOxkLaKoMg367kZBrayos02EGaFG7G/57/Dj+zU?= =?us-ascii?Q?/XCe2k9tRkGKWS1xyVPYOpk8nVnTndO+WlGETkd1f7ng/zO4yjGOaDSIO2K+?= =?us-ascii?Q?/g0ILEqph95x/ZIjS9XQtzG0F7r7QyngWpknYCwOUXNVlg9c+qw+93EJwqSW?= =?us-ascii?Q?AMy5dzBuy4r8x1jcW3piOiaRCekbMULWPZ2OXhhnbMjMbiuNXGGiYIGDl2zq?= =?us-ascii?Q?5sb94Rn5toWl1Yq5qn6M83U7499tPBBf3JQA5Rh8ljq8Xx5XB/WHFIvGsEIN?= =?us-ascii?Q?CXqm6/sQMCH/DnHu9NqW5rK7C4QPs+FnqqdrO2OzyXjssZNmtl/LoccXNW2G?= =?us-ascii?Q?NilBgdplTyCQs74kGnaol+OPZkNSY7Vn8ZCN8dFvBRA6oo+vbe1gFxpOqptf?= =?us-ascii?Q?UPuWv/Y9q9+UzqgtVl4FS3IV5W7AGtVHJ+WpvNJO+st575zlJ7DfpLBpT3S2?= =?us-ascii?Q?gIM/uDGDE83/WYHNQ0Om1RPB/nFy22SPkMFluQRJeUkRMxrHEoQAizJlTK0D?= =?us-ascii?Q?B10F8FYbY2IEtbfG6HFjDxpynfWPtRqDC/N1g+fGJbo31063Rhd/6CK0Tbuk?= =?us-ascii?Q?MVEh0tva6rb1dKR79gByy76d99JYtreoLB54IoBAeRC0LJu5pwEQWgiN75nt?= =?us-ascii?Q?pEv06ziJFlHEkUa5pTFyV61Y49UMEoCqV3kPjAGyZUmU1wHyLuujnJ5c0Ahc?= =?us-ascii?Q?leZT3rLHbSqNxCYjUDauVAjP0NSyZgvhAlYMcDGJ9b+9jsAqBugsmjiBAxRY?= =?us-ascii?Q?Ea4EkE8Pr5AvfovpcxKXC0nMLyGJReNmmUyNE1M+qVWFb7YRdXzvjZ6b2E1r?= =?us-ascii?Q?KlFyE/l4cZUre9H6g1RXT+FEsCbQDHbhYeXc8uENareXujwukSxqAhtKuRg8?= =?us-ascii?Q?T87oP6V4qNc1NMFqEYdAKtfivWhDsqneuABNcwDvaad4mqzCVuU6URnKJWTj?= =?us-ascii?Q?vNVrBUCpotndJ5tAHqTgbEDlb2eJW+anD7rxPx27FPCHY7h7Zbsxhfa37zNR?= =?us-ascii?Q?/X7tXwUv9I0gh2zmlFFazSUO1Z4wxD87/egbn5GwDDnnalmUkAvpoTJPpzw0?= =?us-ascii?Q?wmcWSRBMh4XUAksp1lqvtzO7+FkKLm+bk/E/jOxT24zw8jg+f0XdAkbRTtbb?= =?us-ascii?Q?Msm8qjoFGWltHEjOBMeuIxuDldIgyoIYFSuOScFFEuhV5fRnKVMIX+ELz4Pf?= =?us-ascii?Q?BObiMx9lxsal+uShkFixdDyeb/26LHKSBEzDyOZ60Xe6JFg6wQtheR1kiXg9?= =?us-ascii?Q?d/b9mONnAwBu5jhEOIxhziejCh3dc8UnVzBDwcITpcT3pf2TMMrX1nwE26SP?= =?us-ascii?Q?NwBj8GsqQtggWpGoDHyjdNSs8XYf4rAJpepHld3nG85Zq7uVFAm4AE4A1+8q?= =?us-ascii?Q?b8RjsHlYKhsik4KoQK4aUNsUBVRK0IOwAluKNWKBhIK96B206eFJAu+ATSwP?= =?us-ascii?Q?3KSDQWgNPxgucRnWShT+v/1ae2w4oxXabBaxSEV2FQ6Ip8tPXYC1h2uNJioD?= =?us-ascii?Q?iw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69ebcded-a73d-4e02-abf5-08dab58e070e X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 07:04:43.6606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4v+5LZp8PsH4M6lYq2FAjNJPQDuHqXpcYrY761jotz3munx8fAdFbRx0tFZnAcGw+MKUu+NxaKl8dnbcmAhoNgk+1Z41g8/pIq7LjLPwvaA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4616 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-24_01,2022-10-21_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210240045 X-Proofpoint-GUID: fGRgH_imB852nTc0xQpzGgv_d2hk2HR- X-Proofpoint-ORIG-GUID: fGRgH_imB852nTc0xQpzGgv_d2hk2HR- ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=dBD16+Wq; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=QCgqTICg; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf02.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1666595090; a=rsa-sha256; cv=pass; b=MW6eZdtREKp+pcXHeW0mgX9wo85VmysA5wUgWgUgoSQpKWcfKjAYI/t9Fs+dhq/6OwCwpw 4HYEsltyubldy1O+56vF2hhahkP33CW3Urk0n1EtvOaf/d6v/xY7IBD4Ig0oBAtNF9F6vn gGye9OU3uyXHp1sW9t/UBLCKOXcjuJg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666595090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=afaDR6I8p/cNZz+sX3utmJGiYdOXbLQ2QY04IdCSbnw=; b=uLPdLDkolq6HXBtdaWqrMRNC493rG22qCQUopUqUlzM4kC0AN4y3ifTI3uTFpcGDpAOUKI EgtcCPsb9EILr2hPBTIe5fCeWWMLwx5vdfL7XhZhpO3K4rTIGrL9xjodgvMhWd2enlu5n4 abE5Hk3vdybhj65+HIrr6qGd6lzhEBw= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=dBD16+Wq; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=QCgqTICg; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf02.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: owk5bqu13i17gypdhn7ipchea6xpcwqn X-Rspamd-Queue-Id: 1E5768000D X-HE-Tag: 1666595089-258119 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Wei, url: https://github.com/intel-lab-lkp/linux/commits/Wei-Yang/mm-vmscan-reduce-double-check-if-kswapd-is-not-able-to-sleep/20221023-160625 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20221023080431.30893-1-richard.weiyang%40gmail.com patch subject: [PATCH] mm/vmscan: reduce double-check if kswapd is not able to sleep config: microblaze-randconfig-m041-20221023 compiler: microblaze-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter New smatch warnings: mm/vmscan.c:7261 kswapd_try_to_sleep() error: uninitialized symbol 'remaining'. vim +/remaining +7261 mm/vmscan.c 38087d9b036098 Mel Gorman 2016-07-28 7179 static void kswapd_try_to_sleep(pg_data_t *pgdat, int alloc_order, int reclaim_order, 97a225e69a1f88 Joonsoo Kim 2020-06-03 7180 unsigned int highest_zoneidx) f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7181 { de349a300443b3 Wei Yang 2022-10-23 7182 long remaining; de349a300443b3 Wei Yang 2022-10-23 7183 bool can_sleep; f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7184 DEFINE_WAIT(wait); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7185 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7186 if (freezing(current) || kthread_should_stop()) f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7187 return; f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7188 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7189 prepare_to_wait(&pgdat->kswapd_wait, &wait, TASK_INTERRUPTIBLE); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7190 333b0a459c0e1b Shantanu Goel 2017-05-03 7191 /* 333b0a459c0e1b Shantanu Goel 2017-05-03 7192 * Try to sleep for a short interval. Note that kcompactd will only be 333b0a459c0e1b Shantanu Goel 2017-05-03 7193 * woken if it is possible to sleep for a short interval. This is 333b0a459c0e1b Shantanu Goel 2017-05-03 7194 * deliberate on the assumption that if reclaim cannot keep an 333b0a459c0e1b Shantanu Goel 2017-05-03 7195 * eligible zone balanced that it's also unlikely that compaction will 333b0a459c0e1b Shantanu Goel 2017-05-03 7196 * succeed. 333b0a459c0e1b Shantanu Goel 2017-05-03 7197 */ de349a300443b3 Wei Yang 2022-10-23 7198 can_sleep = prepare_kswapd_sleep(pgdat, reclaim_order, highest_zoneidx); de349a300443b3 Wei Yang 2022-10-23 7199 if (can_sleep) { fd901c95388b3b Vlastimil Babka 2016-04-28 7200 /* fd901c95388b3b Vlastimil Babka 2016-04-28 7201 * Compaction records what page blocks it recently failed to fd901c95388b3b Vlastimil Babka 2016-04-28 7202 * isolate pages from and skips them in the future scanning. fd901c95388b3b Vlastimil Babka 2016-04-28 7203 * When kswapd is going to sleep, it is reasonable to assume fd901c95388b3b Vlastimil Babka 2016-04-28 7204 * that pages and compaction may succeed so reset the cache. fd901c95388b3b Vlastimil Babka 2016-04-28 7205 */ fd901c95388b3b Vlastimil Babka 2016-04-28 7206 reset_isolation_suitable(pgdat); fd901c95388b3b Vlastimil Babka 2016-04-28 7207 fd901c95388b3b Vlastimil Babka 2016-04-28 7208 /* fd901c95388b3b Vlastimil Babka 2016-04-28 7209 * We have freed the memory, now we should compact it to make fd901c95388b3b Vlastimil Babka 2016-04-28 7210 * allocation of the requested order possible. fd901c95388b3b Vlastimil Babka 2016-04-28 7211 */ 97a225e69a1f88 Joonsoo Kim 2020-06-03 7212 wakeup_kcompactd(pgdat, alloc_order, highest_zoneidx); fd901c95388b3b Vlastimil Babka 2016-04-28 7213 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7214 remaining = schedule_timeout(HZ/10); "remaining" only set when can_sleep is true. 38087d9b036098 Mel Gorman 2016-07-28 7215 38087d9b036098 Mel Gorman 2016-07-28 7216 /* 97a225e69a1f88 Joonsoo Kim 2020-06-03 7217 * If woken prematurely then reset kswapd_highest_zoneidx and 38087d9b036098 Mel Gorman 2016-07-28 7218 * order. The values will either be from a wakeup request or 38087d9b036098 Mel Gorman 2016-07-28 7219 * the previous request that slept prematurely. 38087d9b036098 Mel Gorman 2016-07-28 7220 */ 38087d9b036098 Mel Gorman 2016-07-28 7221 if (remaining) { 97a225e69a1f88 Joonsoo Kim 2020-06-03 7222 WRITE_ONCE(pgdat->kswapd_highest_zoneidx, 97a225e69a1f88 Joonsoo Kim 2020-06-03 7223 kswapd_highest_zoneidx(pgdat, 97a225e69a1f88 Joonsoo Kim 2020-06-03 7224 highest_zoneidx)); 5644e1fbbfe15a Qian Cai 2020-04-01 7225 5644e1fbbfe15a Qian Cai 2020-04-01 7226 if (READ_ONCE(pgdat->kswapd_order) < reclaim_order) 5644e1fbbfe15a Qian Cai 2020-04-01 7227 WRITE_ONCE(pgdat->kswapd_order, reclaim_order); de349a300443b3 Wei Yang 2022-10-23 7228 can_sleep = false; de349a300443b3 Wei Yang 2022-10-23 7229 } else { de349a300443b3 Wei Yang 2022-10-23 7230 can_sleep = prepare_kswapd_sleep(pgdat, reclaim_order, de349a300443b3 Wei Yang 2022-10-23 7231 highest_zoneidx); 38087d9b036098 Mel Gorman 2016-07-28 7232 } 38087d9b036098 Mel Gorman 2016-07-28 7233 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7234 finish_wait(&pgdat->kswapd_wait, &wait); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7235 prepare_to_wait(&pgdat->kswapd_wait, &wait, TASK_INTERRUPTIBLE); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7236 } f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7237 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7238 /* de349a300443b3 Wei Yang 2022-10-23 7239 * If kswapd is fine to sleep, restore vmstat thresholds and kswapd de349a300443b3 Wei Yang 2022-10-23 7240 * goes to sleep. de349a300443b3 Wei Yang 2022-10-23 7241 * If not, account whether the low or high watermark was hit quickly. f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7242 */ de349a300443b3 Wei Yang 2022-10-23 7243 if (can_sleep) { f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7244 trace_mm_vmscan_kswapd_sleep(pgdat->node_id); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7245 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7246 /* f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7247 * vmstat counters are not perfectly accurate and the estimated f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7248 * value for counters such as NR_FREE_PAGES can deviate from the f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7249 * true value by nr_online_cpus * threshold. To avoid the zone f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7250 * watermarks being breached while under pressure, we reduce the f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7251 * per-cpu vmstat threshold while kswapd is awake and restore f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7252 * them before going back to sleep. f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7253 */ f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7254 set_pgdat_percpu_threshold(pgdat, calculate_normal_threshold); 1c7e7f6c0703d0 Aaditya Kumar 2012-07-17 7255 1c7e7f6c0703d0 Aaditya Kumar 2012-07-17 7256 if (!kthread_should_stop()) f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7257 schedule(); 1c7e7f6c0703d0 Aaditya Kumar 2012-07-17 7258 f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7259 set_pgdat_percpu_threshold(pgdat, calculate_pressure_threshold); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7260 } else { f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 @7261 if (remaining) Uninitialized here. f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7262 count_vm_event(KSWAPD_LOW_WMARK_HIT_QUICKLY); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7263 else f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7264 count_vm_event(KSWAPD_HIGH_WMARK_HIT_QUICKLY); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7265 } f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7266 finish_wait(&pgdat->kswapd_wait, &wait); f0bc0a60b13f20 KOSAKI Motohiro 2011-01-13 7267 } -- 0-DAY CI Kernel Test Service https://01.org/lkp