From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com,
willy@infradead.org, hch@infradead.org
Subject: [RFC PATCH v3 13/14] mm: add /sys/class/bdi/<bdi>/min_bytes knob
Date: Mon, 24 Oct 2022 12:06:02 -0700 [thread overview]
Message-ID: <20221024190603.3987969-14-shr@devkernel.io> (raw)
In-Reply-To: <20221024190603.3987969-1-shr@devkernel.io>
bdi has two existing knobs to limit the amount of dirty memory:
min_ratio and max_ratio. However the granularity of the knobs is limited
and often it is more convenient to specify limits in terms of bytes.
This change adds the min_bytes knob.
It does not store the min_bytes value, instead it converts the max_bytes
value to a ratio. The value is therefore more an approximation than an
absolute value.
It also maintains the sum over all the bdi min_ratio values stored in
the variable bdi_min_ratio.
Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
mm/backing-dev.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index d5f9a8a45550..53dc46ffdb9b 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -199,6 +199,34 @@ static ssize_t max_ratio_store(struct device *dev,
}
BDI_SHOW(max_ratio, bdi->max_ratio / BDI_RATIO_SCALE)
+static ssize_t min_bytes_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct backing_dev_info *bdi = dev_get_drvdata(dev);
+
+ return sysfs_emit(buf, "%llu\n", bdi_get_min_bytes(bdi));
+}
+
+static ssize_t min_bytes_store(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ struct backing_dev_info *bdi = dev_get_drvdata(dev);
+ unsigned long long bytes;
+ ssize_t ret;
+
+ ret = kstrtoull(buf, 10, &bytes);
+ if (ret < 0)
+ return ret;
+
+ ret = bdi_set_min_bytes(bdi, bytes);
+ if (!ret)
+ ret = count;
+
+ return ret;
+}
+DEVICE_ATTR_RW(min_bytes);
+
static ssize_t max_bytes_show(struct device *dev,
struct device_attribute *attr,
char *buf)
@@ -269,6 +297,7 @@ static struct attribute *bdi_dev_attrs[] = {
&dev_attr_read_ahead_kb.attr,
&dev_attr_min_ratio.attr,
&dev_attr_max_ratio.attr,
+ &dev_attr_min_bytes.attr,
&dev_attr_max_bytes.attr,
&dev_attr_stable_pages_required.attr,
&dev_attr_strict_limit.attr,
--
2.30.2
next prev parent reply other threads:[~2022-10-24 19:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 19:05 [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-11-16 21:28 ` Andrew Morton
2022-11-19 0:01 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 02/14] mm: add knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 03/14] mm: document /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 04/14] mm: use part per 1000 for bdi ratios Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:03 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:10 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:05 ` [RFC PATCH v3 07/14] mm: add bdi_set_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:14 ` Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:16 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 08/14] mm: add knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 09/14] mm: document /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 10/14] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:06 ` [RFC PATCH v3 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-24 19:06 ` Stefan Roesch [this message]
2022-10-24 19:06 ` [RFC PATCH v3 14/14] mm: document /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-11-11 17:30 ` [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024190603.3987969-14-shr@devkernel.io \
--to=shr@devkernel.io \
--cc=axboe@kernel.dk \
--cc=clm@meta.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).