From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com,
willy@infradead.org, hch@infradead.org
Subject: [RFC PATCH v3 07/14] mm: add bdi_set_max_bytes() function.
Date: Mon, 24 Oct 2022 12:05:56 -0700 [thread overview]
Message-ID: <20221024190603.3987969-8-shr@devkernel.io> (raw)
In-Reply-To: <20221024190603.3987969-1-shr@devkernel.io>
This introduces the bdi_set_max_bytes() function. The max_bytes function
does not store the max_bytes value. Instead it converts the max_bytes
value into the corresponding ratio value.
Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
include/linux/backing-dev.h | 1 +
mm/page-writeback.c | 38 +++++++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index cb0e66564d4d..5eb1ae3410b2 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -108,6 +108,7 @@ static inline unsigned long wb_stat_error(void)
unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi);
int bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ratio);
int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
+int bdi_set_max_bytes(struct backing_dev_info *bdi, unsigned long long max_bytes);
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit);
/*
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 8b8936603783..21d7c1880ea8 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -13,6 +13,7 @@
*/
#include <linux/kernel.h>
+#include <linux/math64.h>
#include <linux/export.h>
#include <linux/spinlock.h>
#include <linux/fs.h>
@@ -650,6 +651,28 @@ void wb_domain_exit(struct wb_domain *dom)
*/
static unsigned int bdi_min_ratio;
+static int bdi_check_pages_limit(unsigned long pages)
+{
+ unsigned long max_dirty_pages = global_dirtyable_memory();
+
+ if (pages > max_dirty_pages / 2)
+ return -EINVAL;
+
+ return 0;
+}
+
+static unsigned long bdi_ratio_from_pages(unsigned long pages)
+{
+ unsigned long background_thresh;
+ unsigned long dirty_thresh;
+ unsigned long ratio;
+
+ global_dirty_limits(&background_thresh, &dirty_thresh);
+ ratio = div64_u64(pages * 100ULL * BDI_RATIO_SCALE, dirty_thresh);
+
+ return ratio;
+}
+
static unsigned long long bdi_get_bytes(unsigned int ratio)
{
unsigned long background_thresh;
@@ -723,6 +746,21 @@ unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi)
}
EXPORT_SYMBOL_GPL(bdi_get_max_bytes);
+int bdi_set_max_bytes(struct backing_dev_info *bdi, unsigned long long max_bytes)
+{
+ int ret;
+ unsigned long pages = max_bytes >> PAGE_SHIFT;
+ unsigned long max_ratio;
+
+ ret = bdi_check_pages_limit(pages);
+ if (ret)
+ return ret;
+
+ max_ratio = bdi_ratio_from_pages(pages);
+ return __bdi_set_max_ratio(bdi, max_ratio);
+}
+EXPORT_SYMBOL_GPL(bdi_set_max_bytes);
+
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit)
{
if (strict_limit > 1)
--
2.30.2
next prev parent reply other threads:[~2022-10-24 19:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 19:05 [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-11-16 21:28 ` Andrew Morton
2022-11-19 0:01 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 02/14] mm: add knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 03/14] mm: document /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 04/14] mm: use part per 1000 for bdi ratios Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:03 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:10 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:05 ` Stefan Roesch [this message]
2022-11-16 21:29 ` [RFC PATCH v3 07/14] mm: add bdi_set_max_bytes() function Andrew Morton
2022-11-19 0:14 ` Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:16 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 08/14] mm: add knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 09/14] mm: document /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 10/14] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:06 ` [RFC PATCH v3 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 13/14] mm: add /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 14/14] mm: document " Stefan Roesch
2022-11-11 17:30 ` [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024190603.3987969-8-shr@devkernel.io \
--to=shr@devkernel.io \
--cc=axboe@kernel.dk \
--cc=clm@meta.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).