From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, minchan@kernel.org,
ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com,
ddstreet@ieee.org, vitaly.wool@konsulko.com
Subject: [PATCH 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers
Date: Wed, 26 Oct 2022 13:06:12 -0700 [thread overview]
Message-ID: <20221026200613.1031261-5-nphamcs@gmail.com> (raw)
In-Reply-To: <20221026200613.1031261-1-nphamcs@gmail.com>
This adds fields to zs_pool to store evict handlers for writeback,
analogous to the zbud allocator.
Signed-off-by: Nhat Pham <nphamcs@gmail.com>
---
mm/zsmalloc.c | 36 +++++++++++++++++++++++++++++++++++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 600c40121544..76ff2ed839d0 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -225,6 +225,12 @@ struct link_free {
};
};
+struct zs_pool;
+
+struct zs_ops {
+ int (*evict)(struct zs_pool *pool, unsigned long handle);
+};
+
struct zs_pool {
const char *name;
@@ -242,6 +248,12 @@ struct zs_pool {
/* List tracking the zspages in LRU order by most recently added object */
struct list_head lru;
+#ifdef CONFIG_ZPOOL
+ const struct zs_ops *ops;
+ struct zpool *zpool;
+ const struct zpool_ops *zpool_ops;
+#endif
+
#ifdef CONFIG_ZSMALLOC_STAT
struct dentry *stat_dentry;
#endif
@@ -379,6 +391,18 @@ static void record_obj(unsigned long handle, unsigned long obj)
#ifdef CONFIG_ZPOOL
+static int zs_zpool_evict(struct zs_pool *pool, unsigned long handle)
+{
+ if (pool->zpool && pool->zpool_ops && pool->zpool_ops->evict)
+ return pool->zpool_ops->evict(pool->zpool, handle);
+ else
+ return -ENOENT;
+}
+
+static const struct zs_ops zs_zpool_ops = {
+ .evict = zs_zpool_evict
+};
+
static void *zs_zpool_create(const char *name, gfp_t gfp,
const struct zpool_ops *zpool_ops,
struct zpool *zpool)
@@ -388,7 +412,17 @@ static void *zs_zpool_create(const char *name, gfp_t gfp,
* different contexts and its caller must provide a valid
* gfp mask.
*/
- return zs_create_pool(name);
+ struct zs_pool *pool = zs_create_pool(name);
+
+ if (pool) {
+ pool->zpool = zpool;
+ pool->zpool_ops = zpool_ops;
+
+ if (zpool_ops)
+ pool->ops = &zs_zpool_ops;
+ }
+
+ return pool;
}
static void zs_zpool_destroy(void *pool)
--
2.30.2
next prev parent reply other threads:[~2022-10-26 20:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 20:06 [PATCH 0/5] Implement writeback for zsmalloc Nhat Pham
2022-10-26 20:06 ` [PATCH 1/5] zswap: fix writeback lock ordering " Nhat Pham
2022-10-26 20:06 ` [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-10-28 14:46 ` Johannes Weiner
2022-11-02 3:28 ` Sergey Senozhatsky
2022-11-02 21:36 ` Minchan Kim
2022-11-03 15:18 ` Johannes Weiner
2022-11-03 15:53 ` Minchan Kim
2022-11-03 18:08 ` Johannes Weiner
2022-11-03 18:10 ` Yosry Ahmed
2022-11-03 20:37 ` Minchan Kim
2022-11-03 20:46 ` Yosry Ahmed
2022-11-03 21:15 ` Yu Zhao
2022-11-03 23:19 ` Yosry Ahmed
2022-11-03 21:43 ` Minchan Kim
2022-11-03 23:31 ` Yosry Ahmed
2022-11-03 20:22 ` Minchan Kim
2022-11-04 3:58 ` Sergey Senozhatsky
2022-11-07 21:31 ` Nhat Pham
2022-11-07 22:35 ` Minchan Kim
2022-10-26 20:06 ` [PATCH 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-10-28 14:47 ` Johannes Weiner
2022-10-26 20:06 ` Nhat Pham [this message]
2022-10-28 15:18 ` [PATCH 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Johannes Weiner
2022-11-02 4:10 ` Sergey Senozhatsky
2022-11-07 21:36 ` Nhat Pham
2022-10-26 20:06 ` [PATCH 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-10-27 13:53 ` kernel test robot
2022-10-27 18:27 ` [PATCH v2 " Nhat Pham
2022-10-28 15:19 ` Johannes Weiner
2022-11-02 3:42 ` Sergey Senozhatsky
2022-11-03 15:26 ` Johannes Weiner
2022-11-02 3:44 ` Sergey Senozhatsky
2022-11-02 4:13 ` Sergey Senozhatsky
2022-11-03 16:45 ` Johannes Weiner
2022-11-04 4:02 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026200613.1031261-5-nphamcs@gmail.com \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).