From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D82FA3741 for ; Mon, 31 Oct 2022 15:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 989A36B0074; Mon, 31 Oct 2022 11:31:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93AF56B0075; Mon, 31 Oct 2022 11:31:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DA8D8E0003; Mon, 31 Oct 2022 11:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 599596B0074 for ; Mon, 31 Oct 2022 11:31:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F075D120433 for ; Mon, 31 Oct 2022 15:31:54 +0000 (UTC) X-FDA: 80081634948.10.709C897 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by imf21.hostedemail.com (Postfix) with ESMTP id 1AEAA1C0041 for ; Mon, 31 Oct 2022 15:31:52 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C168B3200994; Mon, 31 Oct 2022 11:31:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 31 Oct 2022 11:31:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1667230310; x=1667316710; bh=D9 LbxPAcSmbbOCV0ltMT+zZ1Q/5Pyv+rKGf25TOsNoY=; b=IbukQMZhTasnrl7snv ZdNX06u3ULatj2BLVlBwYv+1FETK0bG9xLVBuERm/GGamGZrZA9jikEdrzSxU92I dqI9Lh/ZZ/kcTcBz3u8ntXH8ozjMtb/BTZjtg8vNfkDTovtXQJVhCvEFzIEdQb7P FLTy0r/w1vPMmCLflBF0NxUfFvkbdTOvEUdrSLH4br365km5ylT4k+Y+3zW4IzbP kRBh5knzvPjaJbFf8wsaDBsjJNkXxbE6IKOhGt3eILkjVwEb6lrPQs2p9LepfS3k 3qHJfbQo7jlAaf/Gh69Ned3N67Om/b/e5pMCcIzRw49KFkmkGySgRQ16r+qZr9kV BSIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667230310; x=1667316710; bh=D9LbxPAcSmbbOCV0ltMT+zZ1Q/5P yv+rKGf25TOsNoY=; b=OeMifl+btlhxCBqYOmuuskPuXCoNSvME+scMJq0gU5OH 6HAzNHp9+I3+hnlMyo1yu/Tk1bfTk0dyusygFSdW0BKrHNK0c/QINbo5AtJANkrb X62jHJ+1OGqTSoBvmsyZ8yr5eA55mIP3UYyH+tE0b7tUey2e7+Y8NI0Ksr4CgDVg BwWJrLcYf1USGMvp0OxU7bhJWdTuJ2b85dsYv92/hbBuexkpGMVkfRbCS3ob+1nj iBlqb1SgnW44D4dhjkxEcDg2oYSvQLaM+6499Bwa53EhffQODFCZtRt6wEvot2Ww K7CTqnHRMymSM8pvVoup+foZmibXfvwTMgIjr0oC4g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttddttddttddvnecuhfhrohhmpedfmfhirhhi lhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllhesshhhuhhtvghmohhvrdhnrg hmvgeqnecuggftrfgrthhtvghrnhephfeigefhtdefhedtfedthefghedutddvueehtedt tdehjeeukeejgeeuiedvkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Oct 2022 11:31:48 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id E5F69109577; Mon, 31 Oct 2022 18:31:45 +0300 (+03) Date: Mon, 31 Oct 2022 18:31:45 +0300 From: "Kirill A. Shutemov" To: Jiaqi Yan Cc: kirill.shutemov@linux.intel.com, shy828301@gmail.com, tongtiangen@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com, linmiaohe@huawei.com, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH v5 1/2] mm/khugepaged: recover from poisoned anonymous memory Message-ID: <20221031153145.cf6zvvsh2osm243y@box.shutemov.name> References: <20221010160142.1087120-1-jiaqiyan@google.com> <20221010160142.1087120-2-jiaqiyan@google.com> <20221011235918.hvefriya4m3qdhr2@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667230313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D9LbxPAcSmbbOCV0ltMT+zZ1Q/5Pyv+rKGf25TOsNoY=; b=OfQmMXlo14CEo91kQWKR1HGTWtzvpthviMHTv84BtQdQooQQqkVsjGuWSdWhrKLM8oP+Z5 chUqNCX2XsEjBfa7vHRc85jaq1gIyhbHDbezEM1cgl71FrNYXPc+qjd2lhv3a3lWdwRoT5 crQQnQJrI1oky73HCJxeyWoAJHTGvpo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b=IbukQMZh; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=OeMifl+b; spf=pass (imf21.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.19 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667230313; a=rsa-sha256; cv=none; b=PC/kg7ABt9Hm0TbaGWp+C/Mr9jZ7XOY3fKoPy2iobw8R5srE02OnNrU7d+BxFG239OIW+q /m3OYV8E2mUKA06sjWgPEkWez7e60JpaxNYshI3uX4cKT+qQxblwrPDGGj90CYw/lnxoMI KAUtsZVJR+AMUf4AC+8iLDe4adc3Hvg= X-Stat-Signature: odcsde3efhgoc3jjz66bngx3eeapmt8m X-Rspamd-Queue-Id: 1AEAA1C0041 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b=IbukQMZh; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=OeMifl+b; spf=pass (imf21.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.19 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1667230312-156544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 14, 2022 at 11:28:53AM -0700, Jiaqi Yan wrote: > > > > Looks very broken. Or just hard to follow. Or both. > > Do you think the logic looks correct (and just hard to follow) after > these explanation? Yes. > Currently the rollback operations are soaked with > the copy_succeed code to minimize lines of code. But I can definitely > rewrite to something like this if you think the rollback logic is > correct: > > if (copy_succeeded) { > ... > } else { > re-populate PMD; > if (!pte_none && !zero_pfn && !PageCompound(src_page)) > release_pte_page(src_page); > for(page in compound_list) { > release_pte_page(page); > } > } > return copy_succeeded; Looks sane to me. -- Kiryl Shutsemau / Kirill A. Shutemov