From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2644FC433FE for ; Wed, 2 Nov 2022 22:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86B848E0003; Wed, 2 Nov 2022 18:30:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B568E0001; Wed, 2 Nov 2022 18:30:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC908E0003; Wed, 2 Nov 2022 18:30:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5A8358E0001 for ; Wed, 2 Nov 2022 18:30:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2281A1413BC for ; Wed, 2 Nov 2022 22:30:34 +0000 (UTC) X-FDA: 80089947588.17.2A36FF7 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf11.hostedemail.com (Postfix) with ESMTP id 7B08440004 for ; Wed, 2 Nov 2022 22:30:32 +0000 (UTC) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A2MMjMm026692; Wed, 2 Nov 2022 22:30:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=9bcvBNVAtfWLhzk+C7N9ZU35vBoa+nKNpCdOWBorsPQ=; b=F6JepXmZF6InnQfiXLpRCD45SFK0dRMYASUNqr3WS0Ls4Uojbm+kk2tuAYhpJGdsN3sk oPVaAW9mltuK3t6QE8B1VDnnNJQiiaxsc6q8NI5vpBrgRU9n389BsvADlT5AyPwojGIT s+lHXIHlLOeZrBn6a/qDDYLszKYJDvI4sE0E3m9XUc6S2G1euhrCfcaWTrz/+ZPTSslA tskqzYPOg9iIgbEJk1TWNwAbrmRjTXuYulwDoRChJLzt9qlyoCHIwifLguYEIEK08JUt DH9wVYdkr2nA7uFhYWpVaW6gTXZ3uS2iShFjtc9vJDwxBM8u7+r/IJJagZQp/gGTZmqs 3Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3km19v04av-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 22:30:08 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2A2MMnqq027183; Wed, 2 Nov 2022 22:30:08 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3km19v048j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 22:30:08 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2A2MKcvw018509; Wed, 2 Nov 2022 22:30:05 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma04ams.nl.ibm.com with ESMTP id 3kgut97mx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 22:30:05 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2A2MU1RZ16319110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Nov 2022 22:30:01 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7415FA404D; Wed, 2 Nov 2022 22:30:01 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6489DA4040; Wed, 2 Nov 2022 22:30:00 +0000 (GMT) Received: from thinkpad (unknown [9.171.6.109]) by d06av23.portsmouth.uk.ibm.com (Postfix) with SMTP; Wed, 2 Nov 2022 22:30:00 +0000 (GMT) Date: Wed, 2 Nov 2022 23:29:58 +0100 From: Gerald Schaefer To: Linus Torvalds Cc: Christian Borntraeger , Peter Zijlstra , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Nadav Amit , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , Andrew Morton , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , Joerg Roedel , Uros Bizjak , Alistair Popple , linux-arch Subject: Re: mm: delay rmap removal until after TLB flush Message-ID: <20221102232958.3f5eaa53@thinkpad> In-Reply-To: References: <47678198-C502-47E1-B7C8-8A12352CDA95@gmail.com> <140B437E-B994-45B7-8DAC-E9B66885BEEF@gmail.com> <50458458-9b57-aa5a-0d67-692cc4dbf2ad@linux.ibm.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: x6KDpMx1-hZ1Wv6Lmf2TD7IsfYnRJzO5 X-Proofpoint-GUID: 5beV_M9V3vzREGfV2fcnorJeJPYJUuNu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_15,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 mlxlogscore=712 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020146 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667428232; a=rsa-sha256; cv=none; b=KExw+sG10JKg39r3VGUFWFixFugYwL6TNYZdf1WpbtvOzzO7lHiZG3sTCXjnybZoM2GM5K U3uB8W/6bXOhnc7f/Bz8sk+LFKXKMYnZVVZKUzfvFcsQZxMDCPrBCm4J3wsAFV4VSEBZHM TXNnKI2Fgh07A6PVZK6emX0ETnSSmeE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=F6JepXmZ; spf=pass (imf11.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667428232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9bcvBNVAtfWLhzk+C7N9ZU35vBoa+nKNpCdOWBorsPQ=; b=NU3Y7kBrP1bjoEvYWwJ6JMNNQk4mjSEZREqaGtqtsw14EklGCumKEPOcd59j/ny6hAZzLf YqV3wp1izIkSMdkRUBK/v+84uMs3Jynvx85m9XDyU/4cTBj0fkldukyYtv6pZ4yFDuRjl4 J4XkE2OvqQ/Y+IIFT9wIy0fyt3YCAYE= X-Stat-Signature: bpugtsfb88s6hisdpk1nzif7so7p8q7h X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: 7B08440004 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=F6JepXmZ; spf=pass (imf11.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-HE-Tag: 1667428232-424674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Nov 2022 10:55:10 -0700 Linus Torvalds wrote: > On Wed, Nov 2, 2022 at 2:15 AM Christian Borntraeger > wrote: > > > > It certainly needs a build fix for s390: > > > > In file included from kernel/sched/core.c:78: > > ./arch/s390/include/asm/tlb.h: In function '__tlb_remove_page_size': > > ./arch/s390/include/asm/tlb.h:50:17: error: implicit declaration of function 'page_zap_pte_rmap' [-Werror=implicit-function-declaration] > > 50 | page_zap_pte_rmap(page); > > | ^~~~~~~~~~~~~~~~~ > > Hmm. I'm not sure if I can add a > > #include > > to that s390 asm header file without causing more issues. > > The minimal damage would probably be to duplicate the declaration of > page_zap_pte_rmap() in the s390 asm/tlb.h header where it is used. > > Not pretty to have two different declarations of that thing, but > anything that then includes both and (which > is much of mm) would then verify the consistency of them. > > So I'll do that minimal fix and update that branch, but if s390 people > end up having a better fix, please holler. It compiles now with your duplicate declaration, but adding the #include also did not cause any damage, so that should also be OK.