Re: [PATCH v3 4/5] memblock tests: add generic NUMA tests for memblock_alloc_exact_nid_raw

David Hildenbrand
2022-10-31T12:42:49Z

On 19.10.22 20:34, Rebecca Mckeever wrote:
> Add tests for memblock_alloc_exact_nid_raw() where the simulated physical
> memory is set up with multiple NUMA nodes. Additionally, all but one of
> these tests set nid != NUMA_NO_NODE. All tests are run for both top-down
> and bottom-up allocation directions.
>
> The tested scenarios are:
>
> Range unrestricted:
> - region cannot be allocated:
> + there are no previously reserved regions, but requested node is
> too small
> + the requested node is fully reserved
> + the requested node is partially reserved and does not have
> enough space
> + none of the nodes have enough memory to allocate the region
>
> Range restricted:
> - region can be allocated in the specific node requested without
> dropping min_addr:
> + the range fully overlaps with the node, and there are adjacent
> reserved regions
> - region cannot be allocated:
> + range partially overlaps with two different nodes, where the
> second node is the requested node
> + range overlaps with multiple nodes along node boundaries, and
> the requested node starts after max_addr
> + nid is set to NUMA_NO_NODE and the total range can fit the
> region, but the range is split between two nodes and everything
> else is reserved
>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---

Acked-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb