From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E531C4332F for ; Sat, 5 Nov 2022 11:15:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 474126B0071; Sat, 5 Nov 2022 07:15:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 424146B0073; Sat, 5 Nov 2022 07:15:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EBDA8E0001; Sat, 5 Nov 2022 07:15:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1EDBF6B0071 for ; Sat, 5 Nov 2022 07:15:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 95359407C6 for ; Sat, 5 Nov 2022 11:15:47 +0000 (UTC) X-FDA: 80099133534.13.BC6D5BC Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 3851F80006 for ; Sat, 5 Nov 2022 11:15:46 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id g12so10112656wrs.10 for ; Sat, 05 Nov 2022 04:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tP7byI0+Iy8thvBM9RxOZ1IAYRCUM1f3pZvYHntjIiU=; b=DOEVQebwcJYZ/5W4LsmNd5BxPP3oBR0tUoHQD+yVm7KtNQLdI33Kxpiyv6k1NPct3d TurVtwwBhEkn2mHX6TPae3EuT1hEMKdeiBcf88WBXTnIC577NYFCHOTGpLfIzv9UjqHz lKPbX/Lc8OMHGYc0Yp5Rwehx3aljErPfr9t21Mkn/V7wHwfa57zgGFAe+iye9YXky3Rd VHCv64i4uEGPsxNIn8Zzvp6VI/dDqGZZdUPeEWDFdDq3T3bIcPmavAhkFXfoqZgtw/a9 3T4CVHiCkUbrSqtnin2DcXzehauiCY95qQP4m63W2/D+F7YuhW3Ae8RVQvkUW8dz6EG+ EKcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tP7byI0+Iy8thvBM9RxOZ1IAYRCUM1f3pZvYHntjIiU=; b=vc5OO7zEWIDzrXkKTFOwUe+l1wR6yuQBdEDxRU8tdWxeLfIlM9CIb5YUjvHDxUouf/ c1CoFPDwOBZBagtBwFjuoZbrCxd0fRp0Ew+4W+zWLgZ/RfH49zq+coHIm31db2Vk8huD m9R9G7dgBwu/YYKMKQVa7+byyNAF6A57ErdTGBCy8yVo78/YOTMzvUAt9asxVUQh5/iN zZ3/PRqsyQYUpNMtm+dtyfDBLq6O4oPtbLhGSYxDclM1vrm3+LGCDV0KZJ3gm/ThrSsz Sed+7CpXu3RnbaDh2OqO/Ee9U8N9cP1OVoNYj62Opndv5Rne1gMHbzxwPXbx8qQ0K8Pm 9TKA== X-Gm-Message-State: ACrzQf0D5Zd/hGfbIweZ5l2uL159BRVLUfPqlxy0zq5nSEjKXQDUgoOF ZSJ7Cl/xCX53yx1CIECEbko= X-Google-Smtp-Source: AMsMyM6WU7D2DZTLSdga05zuSpJl+2j2RYGDDpUBqWXo2H5qPh665HWr76c5oJV4AiBpWLaaf+cC9A== X-Received: by 2002:adf:f911:0:b0:21e:c0f6:fd26 with SMTP id b17-20020adff911000000b0021ec0f6fd26mr25119107wrr.361.1667646945769; Sat, 05 Nov 2022 04:15:45 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v18-20020adfe292000000b00228dbf15072sm1846126wri.62.2022.11.05.04.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 04:15:45 -0700 (PDT) Date: Sat, 5 Nov 2022 14:15:40 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Heming Zhao via Ocfs2-devel Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Joseph Qi Subject: fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status' Message-ID: <202211050722.8YGvtPaR-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667646947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=tP7byI0+Iy8thvBM9RxOZ1IAYRCUM1f3pZvYHntjIiU=; b=mIziJCmX3/n24lNCGuk+wqNqgzhgzRgCW/ulSn4ekuTt/NHCwnT5NsA2DpAUSGRWODBGpA DcrUAq5qjDqjYlexj7QAMO64VUr87uPSb00AGOelFld24rJ7sjWP3WzBp1hxM+EntRMTkG bxapOU7PKsSQ4IboZ35BywXi+6/JWcs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DOEVQebw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of error27@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=error27@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667646947; a=rsa-sha256; cv=none; b=HUp/hO7ZNGXzHsLfpojq7DbPzpcPtn4GzOw8TPODtm0EV0l91Y5n+DQNf4BOQBv3q/15DD ZOAhdy30u3ybp6vCESHpz0ZSQnvyz0GbSTGhb2LZAn6lLYMk9qRyWxRbS9dnCX6wV84tmN 4KSH923ipjf5k+hndub8EmQXQJ1Q/Sk= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DOEVQebw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of error27@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=error27@gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3851F80006 X-Stat-Signature: 8w6hyqt76exbm6i5q4p9znhjck8og3sx X-HE-Tag: 1667646946-838100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 10d916c86ecafeccaed89175ebf9b832dddde380 commit: 0737e01de9c411e4db87dcedf4a9789d41b1c5c1 ocfs2: ocfs2_mount_volume does cleanup job before return error config: alpha-randconfig-m041-20221030 compiler: alpha-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status' vim +/status +1809 fs/ocfs2/super.c ccd979bdbce9fba Mark Fasheh 2005-12-15 1802 ccd979bdbce9fba Mark Fasheh 2005-12-15 1803 static int ocfs2_mount_volume(struct super_block *sb) ccd979bdbce9fba Mark Fasheh 2005-12-15 1804 { ccd979bdbce9fba Mark Fasheh 2005-12-15 1805 int status = 0; ccd979bdbce9fba Mark Fasheh 2005-12-15 1806 struct ocfs2_super *osb = OCFS2_SB(sb); ccd979bdbce9fba Mark Fasheh 2005-12-15 1807 ccd979bdbce9fba Mark Fasheh 2005-12-15 1808 if (ocfs2_is_hard_readonly(osb)) 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 @1809 goto out; Unclear if this is an error path or a success path. Honestly, I would have thought the checker is correct that it looks like a failure path. ccd979bdbce9fba Mark Fasheh 2005-12-15 1810 5500ab4ed3b8f07 Gang He 2019-03-05 1811 mutex_init(&osb->obs_trim_fs_mutex); 5500ab4ed3b8f07 Gang He 2019-03-05 1812 ccd979bdbce9fba Mark Fasheh 2005-12-15 1813 status = ocfs2_dlm_init(osb); ccd979bdbce9fba Mark Fasheh 2005-12-15 1814 if (status < 0) { ccd979bdbce9fba Mark Fasheh 2005-12-15 1815 mlog_errno(status); a52370b3b182f79 Gang He 2018-01-31 1816 if (status == -EBADR && ocfs2_userspace_stack(osb)) a52370b3b182f79 Gang He 2018-01-31 1817 mlog(ML_ERROR, "couldn't mount because cluster name on" a52370b3b182f79 Gang He 2018-01-31 1818 " disk does not match the running cluster name.\n"); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1819 goto out; ccd979bdbce9fba Mark Fasheh 2005-12-15 1820 } ccd979bdbce9fba Mark Fasheh 2005-12-15 1821 ccd979bdbce9fba Mark Fasheh 2005-12-15 1822 status = ocfs2_super_lock(osb, 1); ccd979bdbce9fba Mark Fasheh 2005-12-15 1823 if (status < 0) { ccd979bdbce9fba Mark Fasheh 2005-12-15 1824 mlog_errno(status); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1825 goto out_dlm; ccd979bdbce9fba Mark Fasheh 2005-12-15 1826 } ccd979bdbce9fba Mark Fasheh 2005-12-15 1827 ccd979bdbce9fba Mark Fasheh 2005-12-15 1828 /* This will load up the node map and add ourselves to it. */ ccd979bdbce9fba Mark Fasheh 2005-12-15 1829 status = ocfs2_find_slot(osb); ccd979bdbce9fba Mark Fasheh 2005-12-15 1830 if (status < 0) { ccd979bdbce9fba Mark Fasheh 2005-12-15 1831 mlog_errno(status); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1832 goto out_super_lock; ccd979bdbce9fba Mark Fasheh 2005-12-15 1833 } ccd979bdbce9fba Mark Fasheh 2005-12-15 1834 ccd979bdbce9fba Mark Fasheh 2005-12-15 1835 /* load all node-local system inodes */ ccd979bdbce9fba Mark Fasheh 2005-12-15 1836 status = ocfs2_init_local_system_inodes(osb); ccd979bdbce9fba Mark Fasheh 2005-12-15 1837 if (status < 0) { ccd979bdbce9fba Mark Fasheh 2005-12-15 1838 mlog_errno(status); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1839 goto out_super_lock; ccd979bdbce9fba Mark Fasheh 2005-12-15 1840 } ccd979bdbce9fba Mark Fasheh 2005-12-15 1841 ccd979bdbce9fba Mark Fasheh 2005-12-15 1842 status = ocfs2_check_volume(osb); ccd979bdbce9fba Mark Fasheh 2005-12-15 1843 if (status < 0) { ccd979bdbce9fba Mark Fasheh 2005-12-15 1844 mlog_errno(status); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1845 goto out_system_inodes; ccd979bdbce9fba Mark Fasheh 2005-12-15 1846 } ccd979bdbce9fba Mark Fasheh 2005-12-15 1847 ccd979bdbce9fba Mark Fasheh 2005-12-15 1848 status = ocfs2_truncate_log_init(osb); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1849 if (status < 0) { ccd979bdbce9fba Mark Fasheh 2005-12-15 1850 mlog_errno(status); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1851 goto out_system_inodes; 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1852 } c271c5c22b0a7ca Sunil Mushran 2006-12-05 1853 ccd979bdbce9fba Mark Fasheh 2005-12-15 1854 ocfs2_super_unlock(osb, 1); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1855 return 0; ccd979bdbce9fba Mark Fasheh 2005-12-15 1856 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1857 out_system_inodes: 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1858 if (osb->local_alloc_state == OCFS2_LA_ENABLED) 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1859 ocfs2_shutdown_local_alloc(osb); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1860 ocfs2_release_system_inodes(osb); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1861 /* before journal shutdown, we should release slot_info */ 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1862 ocfs2_free_slot_info(osb); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1863 ocfs2_journal_shutdown(osb); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1864 out_super_lock: 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1865 ocfs2_super_unlock(osb, 1); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1866 out_dlm: 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1867 ocfs2_dlm_shutdown(osb, 0); 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 1868 out: ccd979bdbce9fba Mark Fasheh 2005-12-15 1869 return status; ccd979bdbce9fba Mark Fasheh 2005-12-15 1870 } -- 0-DAY CI Kernel Test Service https://01.org/lkp