From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DE7C4332F for ; Sun, 6 Nov 2022 23:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80D2A8E0002; Sun, 6 Nov 2022 18:14:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 795A28E0001; Sun, 6 Nov 2022 18:14:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 637148E0002; Sun, 6 Nov 2022 18:14:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4F7878E0001 for ; Sun, 6 Nov 2022 18:14:21 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09CFCC04B2 for ; Sun, 6 Nov 2022 23:14:21 +0000 (UTC) X-FDA: 80104573122.18.83B3660 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id A2E2C1A0002 for ; Sun, 6 Nov 2022 23:14:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FC6260DD5; Sun, 6 Nov 2022 23:14:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04B42C433D6; Sun, 6 Nov 2022 23:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667776459; bh=HOqaI7ArwDGzuQ5p7MrsUrsps/fJVCnEkG8E4CJJdxY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t2Hn6iF051vqTzh/OW0vMOekHbmoVvG+Iep+IuHA4FsMgfctc6LAsxbfYWPKtY8hG 8VRmEWE4hnLBKhfArvuvdxLtXldGFFFTm/F01YdJWQ7pTMFyHvwYkaKxtcv8yfyYgl 4K76072ETaMOid7a/pVXQTV6RsFv1lVjQwEq9R1g= Date: Sun, 6 Nov 2022 15:14:16 -0800 From: Andrew Morton To: Linus Torvalds Cc: Hugh Dickins , Johannes Weiner , Stephen Rothwell , Alexander Gordeev , Peter Zijlstra , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Nadav Amit , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , Joerg Roedel , Uros Bizjak , Alistair Popple , linux-arch Subject: Re: mm: delay rmap removal until after TLB flush Message-Id: <20221106151416.bc2f942f237de31b6c577e70@linux-foundation.org> In-Reply-To: References: <140B437E-B994-45B7-8DAC-E9B66885BEEF@gmail.com> <8a1e97c9-bd5-7473-6da8-2aa75198fbe8@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667776460; a=rsa-sha256; cv=none; b=RD0VUEd6OIwYtNYa2jIw0tiuyc894VqInCDGxG+4TBlsMikh8lS1TJSs/hQevB5STf7Z1j lquAdF6hbYFCGtWZDKght5edWE4jVzQKDKwgWdcErj7eMNm8epHXs/qQxIZ867e2AH5qmg jFq8ihjP/hknnLuPh5j1qf0dG3JYYZI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t2Hn6iF0; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667776460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YMwhUdD7bJqhRjq/0+VFQ/maKpbXWuQ3pjGXc4TlIco=; b=7HSkyOUW/bj28xltZ8qEizt3mNrXgVGo75UwufejUdvg5umMrgzl5omq3BAEFBaKs/hvkF W4u1X+lVZR1JPFq7z9f8aX6E/ZneN2oOwL1FNPQ6NM74ydnzGPbkbtioZkMMPl+KAhnNi2 gI8e/D+HmTLbTk88rZ96EG+bxpR5emQ= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t2Hn6iF0; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: z3fjngyxon8nyrpmnm9fanaf3jopsx4s X-Rspamd-Queue-Id: A2E2C1A0002 X-HE-Tag: 1667776460-927833 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 6 Nov 2022 14:34:51 -0800 Linus Torvalds wrote: > > mm-unstable (bad) > > ----------------- > > Aside from that PageAnon issue, mm-unstable is in an understandably bad > > state because you could not have foreseen my subpages_mapcount addition > > to page_remove_rmap(). page_zap_pte_rmap() now needs to handle the > > PageCompound (but not the "compound") case too. I rushed you and akpm > > an emergency patch for that on Friday night, but you, let's say, had > > reservations about it. So I haven't posted it, and while the PageAnon > > issue remains, I think your patchset has to be removed from mm-unstable > > and linux-next anyway. > > So I think I'm fine with your patch, I just want to move the memcg > accounting to outside of it. > > I can re-do my series on top of mm-unstable, I guess. That's probably > the easiest way to handle this all. > > Andrew - can you remove those patches again, and I'll create a new > series for you? Yes, I've removed both serieses and shall push the tree out within half an hour from now.