From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22806C4321E for ; Sat, 19 Nov 2022 00:15:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1A968E0002; Fri, 18 Nov 2022 19:15:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACA2E6B007E; Fri, 18 Nov 2022 19:15:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 944E56B0080; Fri, 18 Nov 2022 19:15:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8358D6B007D for ; Fri, 18 Nov 2022 19:15:44 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4B0D1409AF for ; Sat, 19 Nov 2022 00:15:44 +0000 (UTC) X-FDA: 80148273408.04.31E7667 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf21.hostedemail.com (Postfix) with ESMTP id E526F1C0009 for ; Sat, 19 Nov 2022 00:15:43 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id d192so6393516pfd.0 for ; Fri, 18 Nov 2022 16:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xlNO430pFQOka1esCEqa7IqA23nNPCeXNP57iQ3X88k=; b=dou3yaHyJKMOuyzUjM+AISJf6d71pZrUfWgikbtI9j3Y6hoNgor6yN25JPdwAaQ20T bmEir2kFtNskQqAa6VxLNCDTkWDBSHlNjmNr1BjrGtRvWaoVjBjwCe2CNlGrMB9dPazV zVupTfokhJ0RXHrTqeO8XRh2Sl5a0XajITvW/0w0eEWrXHyjTEthY+XOlM1/P3Qx+FOk PojrXY03qZdpjSSaqO9sYspzBL7r770DMqA1qyL4NgGRnuKeKEWvSnSjInRtGVvk6Vgd LqD/1+XOJo0RiC3b6nmNF2vpTvmAVhB1Dh2dkK+s9F02Uq+tVt1tf0f7PGy4eLuCIXyD 42JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xlNO430pFQOka1esCEqa7IqA23nNPCeXNP57iQ3X88k=; b=FG0ekwnboYmdpE3s5Fugwv6rjODs1kSdrJyXbUoalrWWnXFO9s5lCoM2gVNZDBVbtg R1z5ZqCGsKevr+dCKvahSzIitcwOc49u/itaOlU/rE+6hRoG2lhjUJWWkG49jfRmOLKP vElOx1UZ4lFsNL/wKajG0BVUsZQ3w8CQvAKntsCkPSR8Y3FtcNQSUm4Of0s251VR8GTr +9MS8Nr9v2wiOLi727F4ehc0ISGZrhKA88HzL0wroWiiKam21hY/bG3Ebf5LcmXceDzO pEtBe8HdbDOWubcFpnKN6BjFDNYSjnyC92e4uf9P3g/zGPBaMCDHJAFZ69Be4TnBQw5O g5sQ== X-Gm-Message-State: ANoB5pla8e/8mh4iQR2YlZAmKrKYnb8enxY5EXzidkIM5nRS5BXEgPV6 kUvmFbUA/JClj42UmDTxw2Q= X-Google-Smtp-Source: AA0mqf6yUmUHE0UvTfSdN0ChRKmCdP7x9U3+tTT0bCMv0jXDGck8BJGrPxpLEzKY2+HNMBmDm17XBg== X-Received: by 2002:a63:d241:0:b0:439:8688:a98d with SMTP id t1-20020a63d241000000b004398688a98dmr8511296pgi.424.1668816943018; Fri, 18 Nov 2022 16:15:43 -0800 (PST) Received: from localhost (fwdproxy-prn-017.fbsv.net. [2a03:2880:ff:11::face:b00c]) by smtp.gmail.com with ESMTPSA id u139-20020a627991000000b00561cf757749sm3751245pfc.183.2022.11.18.16.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 16:15:42 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: [PATCH v6 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Date: Fri, 18 Nov 2022 16:15:34 -0800 Message-Id: <20221119001536.2086599-5-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221119001536.2086599-1-nphamcs@gmail.com> References: <20221119001536.2086599-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668816944; a=rsa-sha256; cv=none; b=rSKM0j8DERvAFzIC27Xgf2QCX50QInQggaGOSDygMPH1GTEOb0adLAhv7vNSFp5G/uLrow DjncOchoq6abtDEookKlw8yeL+XxgVD6IQ5AdR/fqt/UWvxlVUp4XuKPxK1tfkgpzesxbj zjKwHIZJZ4Sb+1/NlYTl9+a/ZcvR6rM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dou3yaHy; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668816944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xlNO430pFQOka1esCEqa7IqA23nNPCeXNP57iQ3X88k=; b=oAy05/Cw+hbkrsrXO/Yuc6h3vsDedi1J0QCYryywygIUNDTwl25GVDbbSya0Hy2L8MJerU PmRQu/qoJIlQfUVL29BzuvOeF+o+SuHV3xseBohJZoyd2quuiXO24mPIacgyg0vh6EuAAy 2ZUifDWcwmDzyhyQQqBpNe6RiDeEpGM= X-Stat-Signature: ipuoih6wscsd9esu17hadz7nwg8pfd7k X-Rspamd-Queue-Id: E526F1C0009 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dou3yaHy; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668816943-624625 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This helps determines the coldest zspages as candidates for writeback. Signed-off-by: Nhat Pham --- mm/zsmalloc.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 326faa751f0a..7dd464b5a6a5 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -239,6 +239,11 @@ struct zs_pool { /* Compact classes */ struct shrinker shrinker; +#ifdef CONFIG_ZPOOL + /* List tracking the zspages in LRU order by most recently added object */ + struct list_head lru; +#endif + #ifdef CONFIG_ZSMALLOC_STAT struct dentry *stat_dentry; #endif @@ -260,6 +265,12 @@ struct zspage { unsigned int freeobj; struct page *first_page; struct list_head list; /* fullness list */ + +#ifdef CONFIG_ZPOOL + /* links the zspage to the lru list in the pool */ + struct list_head lru; +#endif + struct zs_pool *pool; #ifdef CONFIG_COMPACTION rwlock_t lock; @@ -953,6 +964,9 @@ static void free_zspage(struct zs_pool *pool, struct size_class *class, } remove_zspage(class, zspage, ZS_EMPTY); +#ifdef CONFIG_ZPOOL + list_del(&zspage->lru); +#endif __free_zspage(pool, class, zspage); } @@ -998,6 +1012,10 @@ static void init_zspage(struct size_class *class, struct zspage *zspage) off %= PAGE_SIZE; } +#ifdef CONFIG_ZPOOL + INIT_LIST_HEAD(&zspage->lru); +#endif + set_freeobj(zspage, 0); } @@ -1249,6 +1267,15 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle, obj_to_location(obj, &page, &obj_idx); zspage = get_zspage(page); +#ifdef CONFIG_ZPOOL + /* Move the zspage to front of pool's LRU */ + if (mm == ZS_MM_WO) { + if (!list_empty(&zspage->lru)) + list_del(&zspage->lru); + list_add(&zspage->lru, &pool->lru); + } +#endif + /* * migration cannot move any zpages in this zspage. Here, pool->lock * is too heavy since callers would take some time until they calls @@ -1967,6 +1994,9 @@ static void async_free_zspage(struct work_struct *work) VM_BUG_ON(fullness != ZS_EMPTY); class = pool->size_class[class_idx]; spin_lock(&pool->lock); +#ifdef CONFIG_ZPOOL + list_del(&zspage->lru); +#endif __free_zspage(pool, class, zspage); spin_unlock(&pool->lock); } @@ -2278,6 +2308,10 @@ struct zs_pool *zs_create_pool(const char *name) */ zs_register_shrinker(pool); +#ifdef CONFIG_ZPOOL + INIT_LIST_HEAD(&pool->lru); +#endif + return pool; err: -- 2.30.2