From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A304FC4332F for ; Mon, 21 Nov 2022 20:19:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 121C26B0072; Mon, 21 Nov 2022 15:19:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D2558E0001; Mon, 21 Nov 2022 15:19:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDBAC6B0074; Mon, 21 Nov 2022 15:19:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC3266B0072 for ; Mon, 21 Nov 2022 15:19:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ACE991A0C44 for ; Mon, 21 Nov 2022 20:19:44 +0000 (UTC) X-FDA: 80158565088.10.8666C9C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 1421F8000A for ; Mon, 21 Nov 2022 20:19:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3A02AB81063; Mon, 21 Nov 2022 20:19:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73380C433D6; Mon, 21 Nov 2022 20:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669061980; bh=Zi9Lx3c8aWMW4JxLDifOxiaYeP264p6EDgyqQzLFIuA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1CV3abAGw5xIsnLjgX6OP4B1P2vPYSLncEQJ9gPbUxXSPzBmhFXg8bo++WIxTft57 nEMFfIQXC7IudzLEeZPcyixYa128aLDX1dj/ghFaqAoNisEdFqM6ZUL32eIRd7JRNc IQ53Rv0/3SiWR5ki5+gXfesnTovCvZGa1tP6NW7g= Date: Mon, 21 Nov 2022 12:19:38 -0800 From: Andrew Morton To: Feng Tang Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 1/2] mm/slab: add is_kmalloc_cache() helper macro Message-Id: <20221121121938.1f202880ffe6bb18160ef785@linux-foundation.org> In-Reply-To: <20221121135024.1655240-1-feng.tang@intel.com> References: <20221121135024.1655240-1-feng.tang@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669061983; a=rsa-sha256; cv=none; b=7Et/9WCdOfZB/j9vQFJ1NqkTI6TpEouCMGxlA2Sv75s8NU1j9gUmd3N9GUkH9HGRxv2CMP 4mXFGoOXnoUBKgdktLyiO7jz1QVH6nAUr3vhUaDE3utTHrBgYuwAkYOj/fJGJKZh9XMRU6 tzaqydqtRx0+UOwIXx3Zt9GJnJHigbQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1CV3abAG; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669061983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uATQpzDiOPp2o9enV6Z7rYGB9I6Dn7+zkegTL3HlS3o=; b=oFvcfz/Rx0zOcvkFOMMlLsEoeKjEZ+bPm2+v/K6eLCAgUH8r/y1ynAhD++WGHQCPdZWoqq rkiChChNBlvNzSlyRPu641uF/mGxs10tExnloyRYNY3a/ltM4sxLBRAfsNJPE4n9gshJhZ ZUZDgGWw9sscHmNUQQYFN8NUkpXZ4VU= X-Rspam-User: X-Rspamd-Queue-Id: 1421F8000A Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1CV3abAG; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: dbi539d5cshyrhubq6s4kekf9qwb4t4s X-Rspamd-Server: rspam10 X-HE-Tag: 1669061982-916834 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 21 Nov 2022 21:50:23 +0800 Feng Tang wrote: > +#ifndef CONFIG_SLOB > +#define is_kmalloc_cache(s) ((s)->flags & SLAB_KMALLOC) > +#else > +#define is_kmalloc_cache(s) (false) > +#endif Could be implemented as a static inline C function, yes? If so, that's always best. For (silly) example, consider the behaviour of x = is_kmalloc_cache(s++); with and without CONFIG_SLOB.