From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Peter Xu <peterx@redhat.com>, John Hubbard <jhubbard@nvidia.com>,
syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com
Subject: Re: [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings
Date: Mon, 21 Nov 2022 13:33:20 -0800 [thread overview]
Message-ID: <20221121133320.a4e1c70af6ca72f29795fd5f@linux-foundation.org> (raw)
In-Reply-To: <e2e59601-ced3-a62e-48e8-69fd24b1297e@redhat.com>
On Mon, 21 Nov 2022 09:05:43 +0100 David Hildenbrand <david@redhat.com> wrote:
> >> MikeK do you have test cases?
> >
> > Sorry, I do not have any test cases.
> >
> > I can ask one of our product groups about their usage. But, that would
> > certainly not be a comprehensive view.
>
> With
>
> https://lkml.kernel.org/r/20221116102659.70287-1-david@redhat.com
>
> on it's way, the RDMA concern should be gone, hopefully.
>
> @Andrew, can you queue this one? Thanks.
This is all a little tricky.
It's not good that 6.0 and earlier permit unprivileged userspace to
trigger a WARN. But we cannot backport this fix into earlier kernels
because it requires the series "mm/gup: remove FOLL_FORCE usage from
drivers (reliable R/O long-term pinning)".
Is it possible to come up with a fix for 6.1 and earlier which won't
break RDMA?
next prev parent reply other threads:[~2022-11-21 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 15:25 [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings David Hildenbrand
2022-10-31 16:14 ` Jason Gunthorpe
2022-10-31 22:13 ` Mike Kravetz
2022-11-21 8:05 ` David Hildenbrand
2022-11-21 21:33 ` Andrew Morton [this message]
2022-11-22 9:05 ` David Hildenbrand
2022-11-22 17:41 ` Mike Kravetz
2022-11-22 17:59 ` Jason Gunthorpe
2022-11-22 23:03 ` Andrew Morton
2022-11-22 23:48 ` Mike Kravetz
2022-11-23 8:40 ` David Hildenbrand
2022-11-02 9:14 ` David Hildenbrand
2022-11-02 11:38 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121133320.a4e1c70af6ca72f29795fd5f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).