From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F26BC4332F for ; Wed, 23 Nov 2022 16:30:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4C496B0073; Wed, 23 Nov 2022 11:30:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFC6C6B0074; Wed, 23 Nov 2022 11:30:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC4DD6B0075; Wed, 23 Nov 2022 11:30:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9E92A6B0073 for ; Wed, 23 Nov 2022 11:30:47 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 355EE1A12E1 for ; Wed, 23 Nov 2022 16:30:47 +0000 (UTC) X-FDA: 80165245734.07.8135354 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 92E31140010 for ; Wed, 23 Nov 2022 16:30:46 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id q1so17171756pgl.11 for ; Wed, 23 Nov 2022 08:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iViwIfECIqhBr9fvxYi0Xo/aU6bf+FR/xO4cSLXF8Bc=; b=RzbR+elNzGu5bIsu1/MfFDtI4kni7yJZZoVH9tIE8j3ZVC5EgnWMjLNVyoQMfZffgX dtD9hxMmaJtL0djAJ7GK6P4fW03HJqtSvHduWF9ysAraPNn4VHJnBZHbzNYy/AWo9maN OGSbkn/15tuCWLB/z3sklKUZ0k1mOLbtrwXpOM5zICSy2sJZGwwPQIuixuNsHrBzr6XS GzZMH8HH7kV9ZgkaZMHIQq2KA8bdC7HEbzD+x4kwK9MSaF3WIrV1LJ0PbPMKf0llTPxI J1QUWMHYodUqx/N1XONJdCq4fhC2DbIcix5M5twc2leTTzMwGQWGjKjEHyh+NpHmikFj ejlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iViwIfECIqhBr9fvxYi0Xo/aU6bf+FR/xO4cSLXF8Bc=; b=KWsVZp53lODZ3h7PghqWytBJGLUck7henOTMM2DGA14sVV4H8b3peNcUrWaBe+aTiO sNFntMC+YqeihR2yEjDa1WW097qtwI+oqaYxblhMlt/XmBYRh9VTRb/nAmPvzGDl9Imr ryWeuHx1L+3zcqTr/tgV4AndjYTi5DdoK8G8a+gVaLch0v+hcx7mkT+VLQYaDmun3Bwk tQid7qwsH2sU/DOG3JKSqvduYDAQfn2OoUyyM1XVFyr7hthtybEslsrvi4m8Ce/Ttejz L7xy8lOMfL2/w60hD6/7VIZWSm+MU8keF5yC0Xy93pII0A3eHs3C2Q54aI1on/UHv3L9 zgRQ== X-Gm-Message-State: ANoB5pluiYzlxFop84AvrGk6NajN0IqY42Uqe15+mJGPFyNw1JTyDVac Oss0nhLdY07N+5EIG0p3dDk= X-Google-Smtp-Source: AA0mqf56HiyaKNWtbVUYLIP4BozP4wfIPlE8iDFyQN+KrIYyD50b3UMwczSOTW+Do4ZUyhJPcoRoFw== X-Received: by 2002:a63:220c:0:b0:46a:e819:216c with SMTP id i12-20020a63220c000000b0046ae819216cmr14804255pgi.155.1669221045555; Wed, 23 Nov 2022 08:30:45 -0800 (PST) Received: from localhost (fwdproxy-prn-118.fbsv.net. [2a03:2880:ff:76::face:b00c]) by smtp.gmail.com with ESMTPSA id o31-20020a635d5f000000b004769f0fd385sm10979505pgm.52.2022.11.23.08.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 08:30:45 -0800 (PST) From: Nhat Pham To: senozhatsky@chromium.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Date: Wed, 23 Nov 2022 08:30:44 -0800 Message-Id: <20221123163044.2029016-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RzbR+elN; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669221046; a=rsa-sha256; cv=none; b=oiH11UgmAWq+n5NTH37WqZkbV8laSyWDatKNYjzCrjlzZesVOf+pJOH8fD3gpaaT5fiP8M LojRnlhIsD8OBfewN54iYZJ7pJNTUrQ5ExbhvXREWaoRK75xytCk4FdMhZb/IqfRT88+rc 5tXryP0qiLNzsQiOaz/ylB9cJQCP4M4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669221046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iViwIfECIqhBr9fvxYi0Xo/aU6bf+FR/xO4cSLXF8Bc=; b=DSVdjkv/HxC8QZjPMjmR2MKI04mg3dpkgQgFZEzxSGmpCpsOlFmEDDQH5JNRYHEcCzOdTG xby2jSs01MehzplFZDQQVm3baBiS8uChVqfjZuhPqHdJSqgji77XueQc1ZWJ21DpJv1gQK VMRuio5KIcr8Y7POMKi3flrfEwrh0Fk= X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RzbR+elN; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: mqbb8bbsb5t64x6qbjc19hkrwc6gjkog X-Rspamd-Queue-Id: 92E31140010 X-Rspamd-Server: rspam09 X-HE-Tag: 1669221046-287778 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for the comments, Sergey! > A nit: we usually call get_first_page() in such cases. I'll use get_first_page() here in v7. > We probably better to cond_resched() somewhere here. Or in zs_zpool_shrink() > loop. I'll put it right after releasing the pool's lock in the retry loop: /* Lock out object allocations and object compaction */ remove_zspage(class, zspage, fullness); spin_unlock(&pool->lock); cond_resched(); /* Lock backing pages into place */ lock_zspage(zspage); This will also appear in v7. In the meantime, please feel free to discuss all the patches - I'll try to batch the changes to minimize the churning.