From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D34C43217 for ; Sun, 27 Nov 2022 18:22:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B679D6B0071; Sun, 27 Nov 2022 13:22:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF0266B0073; Sun, 27 Nov 2022 13:22:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 991136B0074; Sun, 27 Nov 2022 13:22:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 866056B0071 for ; Sun, 27 Nov 2022 13:22:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5954FA0011 for ; Sun, 27 Nov 2022 18:22:58 +0000 (UTC) X-FDA: 80180043636.10.CBE68F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id E798D18000E for ; Sun, 27 Nov 2022 18:22:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0307160E0B; Sun, 27 Nov 2022 18:22:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06C20C433C1; Sun, 27 Nov 2022 18:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669573376; bh=57HIenwr4Kxr7NNYG8vCR5qqJX7zD83iy2OLbU6pyIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Emh5Ol8sdOZJZuy9excDvXibwZaXZtYmloEpPcDw06KILvTUTJc/Dd0GyAVPgxmIq 0moiWYEXes3Tga3TndQa7tlyjHkJ+FNUhfkU+p7mYuACkKCVtnzGPkjfAg5XzFGhVV 7wa6AXUUPJCJqDgIgCOoT9fgkhMJv2Ai/LCSr9zMFVE7PLEiQnbyvmw6if3qyKK7gu vYsDpH+Fu4H/7rCbR5/+6BfNDwHngS5rCuSTnzrZge9FyDpfOOFTw0jRUMg9R6OnUs 45rEM0Fp2lRlWBrNypsHWZDLAVej53hvOmxtuA7+MNANiWcyD2XmoFNPo2ns7jsLUQ EwYSSHPt1JhOA== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 07/11] mm/damon/sysfs-schemes: connect filter directory and filters directory Date: Sun, 27 Nov 2022 18:22:54 +0000 Message-Id: <20221127182254.4850-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221124212114.136863-8-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669573378; a=rsa-sha256; cv=none; b=Lb0Aj2SA9ccwR9scBplwIaHrQjrr5iomAOyjiU3LRxrUb7gljoQMLoVlELVSFtMD1DK4rJ Qsewjc3eVPg7ez+nkSA2Qqb+VXoCq3MnUWKkLCetyus2LwgsAd3lefH4G5QwupiODLEExs XrkcZQMUb8E6mPDwBV8TQiQ2yacYx6s= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Emh5Ol8s; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669573378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zPNpapEMMjqMQHvTdqiIPaQ9tkYVu4jzkXCGxlHaGX8=; b=vLgILd8wvObWAuTTEE37UHUbHyyMh1uACl52L8lJ+6nDCThaX1V/PV/2yA9FXwVBRZdAPz htlWQBJaKxcSQc7l8zNt+hQGolXPeOzrtg5UV9D0O2CA3ady8wPpukk0IPeV/Ii8I6MybX Syt3AOnRH1StUUTphEUFPk1Ud3n/vNs= X-Rspamd-Queue-Id: E798D18000E X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Emh5Ol8s; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam07 X-Stat-Signature: k11adi5sjya9xf13m35q3z4g9ctqef1r X-HE-Tag: 1669573377-785288 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 24 Nov 2022 21:21:10 +0000 SeongJae Park wrote: > Implement 'nr_filters' file under 'filters' directory, which will be > used to populate specific number of 'filter' directory under the > directory, similar to other 'nr_*' files in DAMON sysfs interface. > > Signed-off-by: SeongJae Park > --- > mm/damon/sysfs-schemes.c | 67 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index afbfc55a8e84..7f2bab617156 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c [...] > @@ -401,6 +407,57 @@ damon_sysfs_scheme_filters_alloc(void) > return kzalloc(sizeof(struct damon_sysfs_scheme_filters), GFP_KERNEL); > } > > +static void damon_sysfs_scheme_filters_rm_dirs( > + struct damon_sysfs_scheme_filters *filters) > +{ > + struct damon_sysfs_scheme_filter **filters_arr = filters->filters_arr; > + int i; > + > + for (i = 0; i < filters->nr; i++) > + kobject_put(&filters_arr[i]->kobj); > + filters->nr = 0; > + kfree(filters_arr); > + filters->filters_arr = NULL; > +} This function should also be called from damon_Sysfs_scheme_rm_dirs() but this patch is missing that. This could result in undeleted filters directory when writing 0 to 'nr_schemes' file. Next version of this patchset will fix that. Thanks, SJ [...]