From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C488C4321E for ; Sun, 27 Nov 2022 19:51:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 298BB6B0071; Sun, 27 Nov 2022 14:51:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 248E26B0073; Sun, 27 Nov 2022 14:51:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1117D6B0074; Sun, 27 Nov 2022 14:51:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F14E76B0071 for ; Sun, 27 Nov 2022 14:51:27 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C28DE1C5C13 for ; Sun, 27 Nov 2022 19:51:27 +0000 (UTC) X-FDA: 80180266614.15.2AA49E3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 327821C0003 for ; Sun, 27 Nov 2022 19:51:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51086B80B3A; Sun, 27 Nov 2022 19:51:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94E75C433C1; Sun, 27 Nov 2022 19:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669578684; bh=u/x3fW/kNN7k6/MnlQGpUtV7XW5nRo+M7USr9HpvEd8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V/sSpxdQIfJtGqzzYHBMhwtme35L2XQD2y8x0d09iM4lJd02TwbLUXuVYwZU2PVsX 6GBmJRvWvNfptTxdRvE9Jq+A61+fd11sDKZv8//W1XkfNv6BazyTHSJfgsDYGnSm77 qsbyvE4EpBBsuJDzRekoyBy78EKhcEuCfrvn7RPVMhpemRRk1EWYM2aZFMyz0vXYs0 GIu3fvGDbLa+RVv1GS/uEkALoV+HGfW49Ky4038A0mhZPX3b2u5u9JQLRo0aEFCiYz tHcTqwR5mCXPD7fK2b5FvzyHcWa9ZpVm7dFXva5q3DLdZS15wyaBJzKjH2i7kNiGYB upDa8qTGeo0Nw== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 08/11] mm/damon/sysfs-schemes: implement scheme filters Date: Sun, 27 Nov 2022 19:51:21 +0000 Message-Id: <20221127195121.1388-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221124212114.136863-9-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="V/sSpxdQ"; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669578687; a=rsa-sha256; cv=none; b=V2Ca0TrpC1TG93+0zI/K8iImEKpvMCPyU2EzkDsRSpeMgjLXNNo1jMjaV7B3Sdee8aGHRU 533nRTwG037tRP5AzKuhxLUZGXT0+wR6SOXDFVQPmziZnDh1VoGfHXEC0r5o+VF4zYM2cS 1UH3rBp+K/tRCK+PKBJoS1/OA3U6a2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669578687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hgW0sTCHyikug6PslUbZmqH7KGlaqHaoc7OBL6fE2pI=; b=hWGZcWP7xTNBluRn+BgrrzMVty+aXmIobNNLNFr8U/A0CDSMJuiWTkNRaQXbHvC5D/nBkw mIZs8+pxzFOfnMpDW4HAw/GpfF8LI5n31BaOVD4OF2pZReGtyyxhpCcOiABKV0pTVFwO4O bMUd44dl+8V++UteRCEqQKWdLpUF7cY= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="V/sSpxdQ"; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Queue-Id: 327821C0003 X-Rspamd-Server: rspam01 X-Stat-Signature: n8qaay94otzoyguypwxbo1xuhndmfd6y X-HE-Tag: 1669578686-702559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 24 Nov 2022 21:21:11 +0000 SeongJae Park wrote: > Implement scheme filters functionality of DAMON sysfs interface by > making the code reads the values of files under the filter directories > and pass that to DAMON using DAMON kernel API. > > Signed-off-by: SeongJae Park > --- > mm/damon/sysfs-schemes.c | 85 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 84 insertions(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index 7f2bab617156..6f014b328e6f 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c [...] > +static int damon_sysfs_set_scheme_filters(struct damos *scheme, > + struct damon_sysfs_scheme_filters *sysfs_filters) > +{ > + int i; > + struct damos_filter *filter, *next; > + > + damos_for_each_filter_safe(filter, next, scheme) > + damos_destroy_filter(filter); > + > + for (i = 0; i < sysfs_filters->nr; i++) { > + struct damon_sysfs_scheme_filter *sysfs_filter = > + sysfs_filters->filters_arr[i]; > + struct damos_filter *filter = > + damos_new_filter(sysfs_filter->type, > + sysfs_filter->matching); > + int err; > + > + if (!filter) > + return -ENOMEM; > + if (filter->type == DAMOS_FILTER_TYPE_MEMCG) { > + err = damon_sysfs_memcg_path_to_id( > + sysfs_filter->memcg_path, > + &filter->memcg_id); > + if (err) > + return err; > + } Newly created filter should be added to the scheme, but this patch is missing the code. Will add that in the next version of this patch. > + } > + return 0; > +} > +