From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BBBC4332F for ; Fri, 2 Dec 2022 00:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 718106B0072; Thu, 1 Dec 2022 19:55:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7AF6B0073; Thu, 1 Dec 2022 19:55:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 569A06B0074; Thu, 1 Dec 2022 19:55:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4972F6B0072 for ; Thu, 1 Dec 2022 19:55:43 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 267594089C for ; Fri, 2 Dec 2022 00:55:43 +0000 (UTC) X-FDA: 80195548566.22.AA33071 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf24.hostedemail.com (Postfix) with ESMTP id B4CC118000D for ; Fri, 2 Dec 2022 00:55:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=U+LyVbbv; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669942542; a=rsa-sha256; cv=none; b=QTWCCVpKSERhZej8IEGfVz5Q76jf2tIvs6ahhU/b09L7Rm8Rsv4ToaB64kayQvprl/48b8 eM4X9kS1wesrximsyv11KY/31Kn4t6eNerS2nNKeZkgmbeGuJ7oz4s5Rw/6OVI0XWUrYx6 SKGREN4+3PsaQGmt3VOpDYd9XHzYw04= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=U+LyVbbv; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669942542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7xl+qejN3tIVmJSkrvPgdLgILrBaOoxJHIfgTJ2nuQg=; b=N/9T7gsJI22PIWoUbItdQpoYxpVJ3PWznuvYEA+2mqZyb4DzU4MxuHYDKFjC1I27+C3QNy 39WtTtYahMQy92fKhPiyb/KW2jYJ170WnCHQZunThihv31Eft8pqLUokbN/rAfILSZQsCJ xMo3oUPuzMZZdlaLSQe9ZFAK3uD2oNs= Received: by mail-pj1-f51.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so3729642pjd.5 for ; Thu, 01 Dec 2022 16:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7xl+qejN3tIVmJSkrvPgdLgILrBaOoxJHIfgTJ2nuQg=; b=U+LyVbbvc/EqSA7iugywzm78ANe70elPrUE6NMTdrgNZxzrN3L+KXn1dw/OCBzTVZC 1ziu5BU9NNZ4E2l91AsMA/fiQOZTncgXH1a9s7Ci/SxRB1aneAxbUhMBp9Ni35w4S9ez sJ75+Hlki+gge/DYEBT4WOxRPS8Jcf3Y7BgOI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7xl+qejN3tIVmJSkrvPgdLgILrBaOoxJHIfgTJ2nuQg=; b=r3UyXnDbdtFnTIaeySk2WJ1dVYfz8wJRZOERZhj1TSgTt8PwYN0BqbbVQujQSV3qC4 GlFDvvqtxexSxq0YIh+69O3YIHqcK3+RDtnVmXNS1D0SddX7puA4K434JdAMKliEVLc8 olQUBvPwMQdS3vyzHiOjDn1WyeiFi02ZNPuJDIAXizVCwKMgKXblfECAUMFzYz4IVuge 2q+tJuj7UeGaXIFzGyvPSn6XQf8njKibJiYzVIpcbKVc/GX2I9ykJyXKiQ5eofdFQsvQ pY3f2yFxr1Kcov52mukKqsisawzq0rSjBCnXkiV4CICqe9MqXHrdag6E31ohkh/QlcHR 3eCA== X-Gm-Message-State: ANoB5pny0D+N/nYM3wvwXFFZ5N4paFOSSu+eZvVljSFFbXz29UY5/dWZ qJa7GasDeQQN/NFDUivalgiNnw== X-Google-Smtp-Source: AA0mqf4f9epwr9PYq1sO4cqczGzM2TpxtnEKENtU4QLl6r1QIGi9jn92cAb1SK/+1n/byGKTD/iLfQ== X-Received: by 2002:a17:902:c194:b0:189:6995:660c with SMTP id d20-20020a170902c19400b001896995660cmr32787116pld.48.1669942541672; Thu, 01 Dec 2022 16:55:41 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x3-20020aa79ac3000000b00575c5ae50cdsm3949150pfp.142.2022.12.01.16.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 16:55:41 -0800 (PST) Date: Thu, 1 Dec 2022 16:55:40 -0800 From: Kees Cook To: David Gow Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, Oliver Glitta , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Vlastimil Babka , David Rientjes , Andrew Morton Subject: Re: [PATCH v4 3/3] mm: slub: test: Use the kunit_get_current_test() function Message-ID: <202212011655.7B32E97C92@keescook> References: <20221125084306.1063074-1-davidgow@google.com> <20221125084306.1063074-3-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221125084306.1063074-3-davidgow@google.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B4CC118000D X-Stat-Signature: h1az5ucowgcz1bn9dbcnh3z6gmyjmhhm X-Spamd-Result: default: False [6.10 / 9.00]; SORBS_IRL_BL(3.00)[209.85.216.51:from]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; BAYES_HAM(-0.00)[19.46%]; ARC_NA(0.00)[]; TAGGED_RCPT(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_ALLOW(0.00)[chromium.org:s=google]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[15]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; DMARC_POLICY_ALLOW(0.00)[chromium.org,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; DKIM_TRACE(0.00)[chromium.org:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspam-User: X-HE-Tag: 1669942542-447234 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 25, 2022 at 04:43:06PM +0800, David Gow wrote: > Use the newly-added function kunit_get_current_test() instead of > accessing current->kunit_test directly. This function uses a static key > to return more quickly when KUnit is enabled, but no tests are actively > running. There should therefore be a negligible performance impact to > enabling the slub KUnit tests. > > Other than the performance improvement, this should be a no-op. > > Cc: Oliver Glitta > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Christoph Lameter > Cc: Vlastimil Babka > Cc: David Rientjes > Cc: Andrew Morton > Signed-off-by: David Gow Reviewed-by: Kees Cook -- Kees Cook