From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBF3C352A1 for ; Tue, 6 Dec 2022 12:59:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C34E8E0002; Tue, 6 Dec 2022 07:59:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2725C8E0001; Tue, 6 Dec 2022 07:59:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13D228E0002; Tue, 6 Dec 2022 07:59:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 010338E0001 for ; Tue, 6 Dec 2022 07:59:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7774E1C6450 for ; Tue, 6 Dec 2022 12:59:49 +0000 (UTC) X-FDA: 80211888498.07.810C4E4 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf18.hostedemail.com (Postfix) with ESMTP id C8DC21C0009 for ; Tue, 6 Dec 2022 12:59:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bFBCIcEG; spf=pass (imf18.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670331585; a=rsa-sha256; cv=none; b=4QfJyFNrftnXw0G/aUXX8OJdEDGyp7E2t17bPYVTa2xWFU1Z9tbw0SNUi5isc7t6SetL1k qTJzguZ1i+Cd6o4ZfqCxLapZdjoKZiqlarMShlHXMvkb7qH6LiZmV79H/hC1pNz3bcuhYC QP02xbIx3Qw9IiQCryZ04TVbx1fxTNQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bFBCIcEG; spf=pass (imf18.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670331585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=V/khFb5lazp4vCm4xRZ42I7pi8oBjZDH7uh4Ihyi5+A=; b=4IWxG1/XYQUpnPkrlJe/vptJQkAEoLl9uYBkZqRuokZfoahFL8BMFlJvGFquZMRjxo5CT6 VlJTANEO//DwCzYVbHTHT8yYTwTnv2QW76sHF+Z7GUiw+4E0zYGREu05GziTY2It/KxrEP vgXq0rs8tj3PaJHOQNU6h7Rhb6jNDAA= Received: by mail-pg1-f182.google.com with SMTP id 62so13263954pgb.13 for ; Tue, 06 Dec 2022 04:59:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V/khFb5lazp4vCm4xRZ42I7pi8oBjZDH7uh4Ihyi5+A=; b=bFBCIcEGpsLoH1hh+w81wsAexoD/dPFAEsNeviWFtexVhoTEcy2osBHLD/x3nsZx6f pRnrNB4ctrsgiFOAQ1yNvY5UuysdtpXqJh66W5P2wbYvLMKVrFBlowQlmxChlwofNkVl fjuHrnDSt9bp7PSPZiiAuO/N7Hx0l0FLR/b1Ts0afyrDx/7qDW5b/5x4ylSoVIaVQppp Mtf6UNHdHldeEW135OPr53rQem+H91fpkH6K2kLVJKHGlw7JvAIAQY8jfvNH4CfR7XNw C+l7WHOgzL++BeNTzOcjFHU6UPUECVmWx5ZJdW8WZQ0iqRcyJl+myak6gEPXMAAj14Ld fNwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V/khFb5lazp4vCm4xRZ42I7pi8oBjZDH7uh4Ihyi5+A=; b=00GqnWY3wzv38HoK2lqjc4YZb1+EqVLaX3qc/BA2TR0Tm36msyAZjoAg13frHmXJVq X7oJdS8B0LUe/3z3LXSKOJvrMPAnuXX3E4E/dM7dCHtd2+XBzTPovYQM8vX1VqHdNwPD RD1oU0d4nTM03kXW6+U8dl3lI6EhE8XdtWZX5ekfgB9rqVHrOQATw2oS/vSq2ADkDgCa hQFVOD2lS//hIsoSsjoeZdS465r97OBMP9S29VKU9p5IT7Uuu+VjP5CBUBUdkKVetAFS rnoQvKvFJwSHGlo2MKbEey5ytIhfM0LQqtZVntnQ4GpsfSv/LV9MNhOT+HFG3oizrq8F rTCw== X-Gm-Message-State: ANoB5pmDzz8ibVgf55zhhxldK4Z9M3sYSRUDmYwAPNfldYvxZ+LPYpVE xr10iHCV+zAW79JiirAPsTw= X-Google-Smtp-Source: AA0mqf6HljOKz6kDuZ5/Re9QTFy0xo4TdBHZzFPCqs48LWjol+KrIax/xCp+eTe64SOrModeKPRB/w== X-Received: by 2002:a63:195a:0:b0:477:c9d9:f8a0 with SMTP id 26-20020a63195a000000b00477c9d9f8a0mr52705642pgz.228.1670331584718; Tue, 06 Dec 2022 04:59:44 -0800 (PST) Received: from localhost.localdomain ([190.92.242.52]) by smtp.gmail.com with ESMTPSA id q14-20020a170902a3ce00b0018968d1c6f3sm12510631plb.59.2022.12.06.04.59.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 04:59:44 -0800 (PST) From: Liam Ni To: x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, kasan-dev@googlegroups.com Cc: zhiguangni01@gmail.com Subject: [PATCH] x86/boot: Check if the input parameter (buffer) of the function is a null pointer Date: Tue, 6 Dec 2022 20:59:29 +0800 Message-Id: <20221206125929.12237-1-zhiguangni01@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spamd-Result: default: False [-1.89 / 9.00]; BAYES_HAM(-5.99)[99.98%]; SORBS_IRL_BL(3.00)[209.85.215.182:from]; MID_CONTAINS_FROM(1.00)[]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_SEVEN(0.00)[9]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; ARC_NA(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C8DC21C0009 X-Stat-Signature: gxd3hx8sg61pzbzczppcfpdz5hkmsb99 X-HE-Tag: 1670331585-527665 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If the variable buffer is a null pointer, it may cause the kernel to crash. Signed-off-by: Liam Ni --- arch/x86/boot/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/cmdline.c b/arch/x86/boot/cmdline.c index 21d56ae83cdf..d0809f66054c 100644 --- a/arch/x86/boot/cmdline.c +++ b/arch/x86/boot/cmdline.c @@ -39,7 +39,7 @@ int __cmdline_find_option(unsigned long cmdline_ptr, const char *option, char *b st_bufcpy /* Copying this to buffer */ } state = st_wordstart; - if (!cmdline_ptr) + if (!cmdline_ptr || buffer == NULL) return -1; /* No command line */ cptr = cmdline_ptr & 0xf; -- 2.25.1