From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE74C352A1 for ; Wed, 7 Dec 2022 00:56:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D797F8E0003; Tue, 6 Dec 2022 19:56:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D29D28E0001; Tue, 6 Dec 2022 19:56:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF13A8E0003; Tue, 6 Dec 2022 19:56:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AD3B18E0001 for ; Tue, 6 Dec 2022 19:56:29 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6D3FA4047D for ; Wed, 7 Dec 2022 00:56:29 +0000 (UTC) X-FDA: 80213694498.01.839C5BC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 0CEA74000D for ; Wed, 7 Dec 2022 00:56:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AqnLsi3c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670374588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WJ+wgklL4hhoK6Jo72r9luP3coTWbOxgPUJBoMCiHdY=; b=FhhXO9mCGIJqM8qOkjAXWmHDKc/xFrBvAw72Wvf5tZFqPOMLUlvvWVyDGELBcyp0+zrSir T6AvcFHJn8W52g6xf4EzD+kB/2r6FTsmVnkwwr0VyHqws/kVS2/cq28i/36X4h5mqgL7nm 8LeLcH+ynllkFkoOA5McOklt7U8gets= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AqnLsi3c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670374588; a=rsa-sha256; cv=none; b=kAhIl7RnRHK0NWxBc3zbA5pJ/s0qTaTEKSfx5fOjQtGtVk3SbXNGudq+cMqDb+Y0suyjpK vGLkTlffImlO8tIIMENxkl7aroNFFyP6DvxNpHWuQQady03ZD3oP+Z0PtoumDkBRWIvlJg QutNEk3rP9OpIjwVHGd7JSpH5RYzyWQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 243BD6199C; Wed, 7 Dec 2022 00:56:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04F17C433C1; Wed, 7 Dec 2022 00:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670374586; bh=U3rWuYGolopTKgjINqZ0FI0YddZX5cQ+D5E9d0O/2io=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AqnLsi3capSy+XrNYamv5Of/WCSiRS8EAURCkCFUHs1luC0itxkfsmpqxjhcBISIh QEwGh4rer6U7GTFrR+y+3GKh+FjtQUbk+0hK9cCWVbyv8deIkGP5cnZFBYIregihpG IdMbKPFaLL8SDKit+I9eA7Y82bKbCdjmecZDsTvrAmzg2+MFitMnmtQvomB57ujDTb pcNBDVgd7zYAor4wjF6A3dQnU98p4eXwfpFMgPFLFjCtLkpWZro5wVB7rnWrfcJM6l +p9/yDyhJ2/NaOA5ucnZBvjnRXEc0KIvSSq4yF7wnmVSUz/q/3S6rih3NtkKxbWwbY JnTg2IuYEYWzg== From: SeongJae Park To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() to use folios Date: Wed, 7 Dec 2022 00:56:24 +0000 Message-Id: <20221207005624.146281-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221207002158.418789-3-vishal.moola@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [6.52 / 9.00]; R_MISSING_CHARSET(2.50)[]; IRL_BL_25(2.00)[52.25.139.140:received]; BAYES_HAM(-1.58)[84.61%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; DMARC_POLICY_ALLOW(0.00)[kernel.org,none]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[kernel.org:s=k20201202]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+a:dfw.source.kernel.org]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 0CEA74000D X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 8bagrgn3yqhbajg66y33m7y6jehngww1 X-HE-Tag: 1670374587-389345 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vishal, Thank you for this patch. Nit pick. Could we please replace 'damon:' on the subject with 'mm/damon:' to look more consistent with other DAMON patches? On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" wrote: > This change replaces 2 calls to compound_head() with one. I guess you mean _compound_head() calls in page_folio() that called from mark_page_accessed() and folio_mark_accessed(). However, deactivate_page() calls page_folio() anyway, so this patch doesn't reduce the number of calls to one but keep the number, correct? Am I missing something? If I'm not, I'd like to clean up the wording. > This is in preparation for the conversion of deactivate_page() to > deactivate_folio(). I think folio_deactivate() might be a more consistent naming. What do you think? Also, you may keep the above sentence if you implement folio_deactivate() first, update deactivate_page() calls to use folio_deactivate(), and finally remove deactivate_page() definition. I don't really care about the name and the sequence, though. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/damon/paddr.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index e1a4315c4be6..73548bc82297 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -238,15 +238,18 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate( > > for (addr = r->ar.start; addr < r->ar.end; addr += PAGE_SIZE) { > struct page *page = damon_get_page(PHYS_PFN(addr)); > + struct folio *folio; > > if (!page) > continue; > + folio = page_folio(page); One _compound_head() call here, > + > if (mark_accessed) > - mark_page_accessed(page); > + folio_mark_accessed(folio); > else > - deactivate_page(page); > - put_page(page); > - applied++; > + deactivate_page(&folio->page); And second _compound_head() call here. > + folio_put(folio); > + applied += folio_nr_pages(folio); > } > return applied * PAGE_SIZE; > } > -- > 2.38.1 > Thanks, SJ