From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
linux-mm@kvack.org, damon@lists.linux.dev,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() to use folios
Date: Wed, 7 Dec 2022 01:04:26 +0000 [thread overview]
Message-ID: <20221207010426.146353-1-sj@kernel.org> (raw)
In-Reply-To: <20221207005624.146281-1-sj@kernel.org>
On Wed, 7 Dec 2022 00:56:24 +0000 SeongJae Park <sj@kernel.org> wrote:
> Hi Vishal,
>
>
> Thank you for this patch.
>
> Nit pick. Could we please replace 'damon:' on the subject with 'mm/damon:' to
> look more consistent with other DAMON patches?
>
> On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" <vishal.moola@gmail.com> wrote:
>
> > This change replaces 2 calls to compound_head() with one.
>
> I guess you mean _compound_head() calls in page_folio() that called from
> mark_page_accessed() and folio_mark_accessed().
s/folio_mark_accessed()/deactivate_page()/
Sorry for the typo.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2022-12-07 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 0:21 [PATCH 0/3] Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07 0:21 ` [PATCH 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios Vishal Moola (Oracle)
2022-12-07 9:47 ` kernel test robot
2022-12-07 23:46 ` kernel test robot
2022-12-07 0:21 ` [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() " Vishal Moola (Oracle)
2022-12-07 0:56 ` SeongJae Park
2022-12-07 1:04 ` SeongJae Park [this message]
2022-12-07 2:43 ` Vishal Moola
2022-12-07 0:21 ` [PATCH 3/3] swap: Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07 16:18 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207010426.146353-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).