From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DD5C352A1 for ; Wed, 7 Dec 2022 01:04:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81D568E0003; Tue, 6 Dec 2022 20:04:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CE0D8E0001; Tue, 6 Dec 2022 20:04:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695AB8E0003; Tue, 6 Dec 2022 20:04:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 568BC8E0001 for ; Tue, 6 Dec 2022 20:04:30 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 25E3D120687 for ; Wed, 7 Dec 2022 01:04:30 +0000 (UTC) X-FDA: 80213714700.07.6F65CD8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id C585A80015 for ; Wed, 7 Dec 2022 01:04:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nx8dow7q; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670375069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qxJvPmTDzrUowOgv9kFAxFo6fopi1FHVW2nB+3FCG4M=; b=VtXYG52Txzo0+Uwd8eQ8n6s804A9nUMoWmspmY1zMhzePFw+EQosq5cMnWCI1e8tQVyoOS vbyU1lu+YweuDsvrJil+ok9Bq5CSiJliGplIq0znNqc6Nm6yauvyScT8Ew2DFhTd9vOb84 9VrQ7xVFhGRGPIE+vm7yRlRvorlo/f0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nx8dow7q; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670375069; a=rsa-sha256; cv=none; b=JOmIIqYKc/srg3UNH2LYdd5ytwSpkxJQYnfqoBC4X23U6N7jrG7SqCu2zLpgyN03dYUe3J 3L6sDGjBKz7wxpuZ5Ns5XHU58lYh3GxglzMRR7cE6RUyVpn5WOiYli9YkGCN/8TwzRu5hu 4pp2VNZRUZznqWmMzwo3PO+yxoxxXo8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E455D61811; Wed, 7 Dec 2022 01:04:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6010C433D6; Wed, 7 Dec 2022 01:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670375068; bh=9gwl0LY/3FMbEpKl4mJ8EGxqS2Ahze8GFg5DkQ1lXFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nx8dow7qTQelkxuvV+u0My9Ah8byYNPpFh2MzfcY/5IsiC0S1JD8bJQMe/E0YsvN6 JMf8VyRP8T7ELx18r8FdupsBAnNDiNS31D5ayi9FbgZJv04VPPF+fjg0Y1NWPAx1l9 gJW0GMSMHeXBFyU0MPxABCLd47CEbDG0oTuBq+nEDWMU5ilOxWQWoRmm8rNTV3mYOg grssA3lnRJlbZGVdsZOc2m8o5VGg0GFhGc76pvrDGjY+eHzyKtNd5EF8CDp83EKUrl W9kbKGj9EgZVqDQw8soSembvxkb17CShe8TtmnbwJ+OK386hC7brKi4Dt+z/mF8t1J vvULbIa2FDRKA== From: SeongJae Park To: SeongJae Park Cc: "Vishal Moola (Oracle)" , linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() to use folios Date: Wed, 7 Dec 2022 01:04:26 +0000 Message-Id: <20221207010426.146353-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221207005624.146281-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C585A80015 X-Rspam-User: X-Stat-Signature: msh5c938xd99fsonqqk8g4bmuu1rtuk5 X-Spamd-Result: default: False [8.09 / 9.00]; R_MISSING_CHARSET(2.50)[]; IRL_BL_25(2.00)[52.25.139.140:received]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_CONTAINS_FROM(1.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; BAYES_HAM(-0.01)[46.91%]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[kernel.org:+]; DMARC_POLICY_ALLOW(0.00)[kernel.org,none]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[kernel.org:s=k20201202]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+a:dfw.source.kernel.org]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1670375069-222496 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Dec 2022 00:56:24 +0000 SeongJae Park wrote: > Hi Vishal, > > > Thank you for this patch. > > Nit pick. Could we please replace 'damon:' on the subject with 'mm/damon:' to > look more consistent with other DAMON patches? > > On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" wrote: > > > This change replaces 2 calls to compound_head() with one. > > I guess you mean _compound_head() calls in page_folio() that called from > mark_page_accessed() and folio_mark_accessed(). s/folio_mark_accessed()/deactivate_page()/ Sorry for the typo. Thanks, SJ [...]