From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8F1C352A1 for ; Wed, 7 Dec 2022 06:52:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67AD88E0003; Wed, 7 Dec 2022 01:52:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62B488E0001; Wed, 7 Dec 2022 01:52:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F29B8E0003; Wed, 7 Dec 2022 01:52:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CDDA8E0001 for ; Wed, 7 Dec 2022 01:52:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0125C1C5E23 for ; Wed, 7 Dec 2022 06:52:29 +0000 (UTC) X-FDA: 80214591660.13.261A668 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf08.hostedemail.com (Postfix) with ESMTP id 95F06160004 for ; Wed, 7 Dec 2022 06:52:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S9Ld4ogH; spf=pass (imf08.hostedemail.com: domain of error27@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670395949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=KrgPaWpSiWfbgkib36PHrrNJFFJqDZKPMYP3jnPykck=; b=bs9EODsklTLRYng4QvQnfhxeNCH42dcteI+QkmZpyz2xhjooOD4RLmRnR1+UUftxQZjY4f /wzErZjsDThVlTN1qVb32g4jZFMOPrwnaq/gu/fbDrPv7bf6nU/GtaD0zUuaWDZblg5Kz/ 9AShdx6HMueB9f9s9ZNsQk3PVrP7zkU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S9Ld4ogH; spf=pass (imf08.hostedemail.com: domain of error27@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670395949; a=rsa-sha256; cv=none; b=0bq0/KgEkB6w/ypshwnQ1+rXHRMfCq5pMdiP34mAhoc4YHHPuG+/b9dlBwKJq/P4YQgNKR qjqt1AnsY98AjZGkzj0ABc8CpQH0m1spBBvPYPzSSi93OzxKl0GaGDJiaOW7byqjaSngCr ZeAjvaDrwjJKAimrBGIDV2KzK7gXJO0= Received: by mail-wm1-f45.google.com with SMTP id v7so12876164wmn.0 for ; Tue, 06 Dec 2022 22:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=KrgPaWpSiWfbgkib36PHrrNJFFJqDZKPMYP3jnPykck=; b=S9Ld4ogH/ezFMOweMznaOq3kncJUiI0+ZnuB26UsO6ds6UzpoFcXEK5bh4wlk524wV OWy3M2Rx8dSTnAhY4tJIoYMCfcTmjBHnPUCnfion6fEQS8o6IVZzc7irY98WHdNflHSA tNqX1F69mG/R6AtrrpCDSc8nmIbjHDDXxwANQ0+d6RvIQvwoVxKW6yKJ8pbrvQiZOM00 Awpyk/x3cKHCiIPf20MKjSbxTbkB8Hm9rXAYNeT6fXBBPYwfouC7qRDbDuqjns3bqrvG qPrSC0XDYolMw+vroAI53ubb/e9Gr8EKtKm7wCPxTDrJXn9obTSejbX8XKG4vkSAOv1q engg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KrgPaWpSiWfbgkib36PHrrNJFFJqDZKPMYP3jnPykck=; b=pLPkWAZaF30AqurguNIsK0Ntvmp5Z//RdTAF3oK7wJu/WEZoJQEqUywOGRxc5Hjt8g 5GPHW9pnHfqQ1X/5z84DyvwZgESYi/ZOrR2E9+FH/LnlUjd21rIh6x7vjGxfiQDwlZDQ vicxEWgFISDGQrSFT3Qsf5Mzb+gud+7OvPeMZ3ca2i3rTrt0NAzvrBUrLFqCMXWucdDX mwO5Cx5tgxmPHTGiwNn8WrkTeJEMFXrfapalTzNDUwhEyATFdd54uJ9mpMjxIUhsytUf gjQgRxqRJARz2HlXqFKtGO3L3vJXW+cjFyvra+sq0kDNJZPPA9dAv+X4au8RTOGm9w0A DR1Q== X-Gm-Message-State: ANoB5pmoJuKDS6KgjWf35swdJZpOh13XTSWIBqbADEAWZp3Y6+65l57+ UzhfesdaGWnCXCG0a7497L0= X-Google-Smtp-Source: AA0mqf6T7QUHrXNoiBVrw2zq5mDP/QdEqV8LDjlnhlVOKbLpGKD5GvliZXhurz9o3X2CWjv0/8MXQw== X-Received: by 2002:a05:600c:2e0c:b0:3d1:fa2f:b279 with SMTP id o12-20020a05600c2e0c00b003d1fa2fb279mr296865wmf.130.1670395948051; Tue, 06 Dec 2022 22:52:28 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i22-20020a05600c355600b003b4868eb71bsm634392wmq.25.2022.12.06.22.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 22:52:27 -0800 (PST) Date: Wed, 7 Dec 2022 09:52:24 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, David Howells Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:master 11514/13282] net/rxrpc/local_object.c:365 rxrpc_unuse_local() warn: variable dereferenced before check 'local' (see line 362) Message-ID: <202212071248.8BB84G9K-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 95F06160004 X-Stat-Signature: szndsz515qjdd5fcsas7pz1dtp7u6dfh X-Spamd-Result: default: False [2.22 / 9.00]; SORBS_IRL_BL(3.00)[209.85.128.45:from]; BAYES_HAM(-1.88)[86.47%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; RCVD_COUNT_THREE(0.00)[3]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_FIVE(0.00)[5]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspam-User: X-HE-Tag: 1670395949-580702 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5d562c48a21eeb029a8fd3f18e1b31fd83660474 commit: a2cf3264f331acfeb7e463ad7b7fe1ac647a829d [11514/13282] rxrpc: Fold __rxrpc_unuse_local() into rxrpc_unuse_local() config: arm64-randconfig-m041-20221206 compiler: aarch64-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: net/rxrpc/local_object.c:365 rxrpc_unuse_local() warn: variable dereferenced before check 'local' (see line 362) vim +/local +365 net/rxrpc/local_object.c 0fde882fc9ee9c David Howells 2022-10-21 360 void rxrpc_unuse_local(struct rxrpc_local *local, enum rxrpc_local_trace why) 730c5fd42c1e36 David Howells 2019-08-09 361 { a2cf3264f331ac David Howells 2022-11-16 @362 unsigned int debug_id = local->debug_id; ^^^^^^^^^^^^^^^ Dereference a2cf3264f331ac David Howells 2022-11-16 363 int r, u; a2cf3264f331ac David Howells 2022-11-16 364 a2cf3264f331ac David Howells 2022-11-16 @365 if (local) { ^^^^^ Checked too late. a2cf3264f331ac David Howells 2022-11-16 366 r = refcount_read(&local->ref); a2cf3264f331ac David Howells 2022-11-16 367 u = atomic_dec_return(&local->active_users); a2cf3264f331ac David Howells 2022-11-16 368 trace_rxrpc_local(debug_id, why, r, u); a2cf3264f331ac David Howells 2022-11-16 369 if (u == 0) a275da62e8c111 David Howells 2022-10-10 370 kthread_stop(local->io_thread); 68553f1a6f746b David Howells 2019-08-09 371 } a2cf3264f331ac David Howells 2022-11-16 372 } -- 0-DAY CI Kernel Test Service https://01.org/lkp