From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E48C4332F for ; Wed, 14 Dec 2022 12:34:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C46398E0003; Wed, 14 Dec 2022 07:34:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF69A8E0002; Wed, 14 Dec 2022 07:34:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96D48E0003; Wed, 14 Dec 2022 07:34:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 993278E0002 for ; Wed, 14 Dec 2022 07:34:23 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 57D44120D53 for ; Wed, 14 Dec 2022 12:34:23 +0000 (UTC) X-FDA: 80240854806.22.37F185E Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf10.hostedemail.com (Postfix) with ESMTP id 3F50FC0005 for ; Wed, 14 Dec 2022 12:34:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OjXE7Sbc; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of stanislaw.gruszka@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=stanislaw.gruszka@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671021260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8fHtCn1wGZy1yshZGB3Mgbesdhg77tKQQBrdDv3Uygg=; b=mXT71laz6i6yCGEcpsjXQIXVSP7as2kKCEIKBx5V3cAGgJiai6u/x5RKehoxwQMqdqdra/ Rn+ydMYBQKKxdN90cPriB8ihVcH5R+tkPhmNEHjH157vjNEwZfTkcMJ7jxwcTT82uW6X6h keanX7YhRxv+2yU3kEkvDbP9zHN0tUs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OjXE7Sbc; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of stanislaw.gruszka@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=stanislaw.gruszka@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671021260; a=rsa-sha256; cv=none; b=s2DWIetQ08BAY1afb1SE95ndiWuDLNZL3441BbJInaL1d1IB2hNBZQWAS0BWoi7S1Jhft0 QteJ7UrofzzDLnuAZjf5ypNwlG6KSIjFctdDUGpx3MNqx9ncmRKavp05B4M3kOdtVLLMed JUq+zdCE/m94T19gZqiud/+gUjsGF1c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671021260; x=1702557260; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gLUmLxK/mwLgHaeh9UkBdZ9YGpWxeUp7JgHpb5LXdic=; b=OjXE7Sbc+NHejth4lgW0afmEb/hq0blHtC6Uz3H82UXRR8zKhW/GteEe vgkll6v8kgOJY7Qe3ihxU2sLaWBaaC45Sa+/eJkug4Exx+AkML/uw1qPR w3RGYAuPBnwMO0RG/ySN7pFiZNKC6kZu3BgSnOYZ6yI0e7UI1qJMSAosz 4+PIiHtluG9kafvaHMJc6ceDWWkbJ8Y9VxnlZrcOk9ZuHkANNCir3QLuK zhocs8FU87mc8ohX9/ZeXK19WrprslfK6+yKS5fJPwgsgul/2CwuqD+3S qL4sWwI0DT01cD0lWbeTYtomqhnQDDBUIzzBe7/S1Uxr40dFRquv/Ezv8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="345460252" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="345460252" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 04:34:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="823243981" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="823243981" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 04:34:00 -0800 Date: Wed, 14 Dec 2022 13:33:58 +0100 From: Stanislaw Gruszka To: "Jason A. Donenfeld" Cc: david.keisarschm@mail.huji.ac.il, Vignesh Raghavendra , Peter Zijlstra , Dave Hansen , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , Eric Dumazet , linux-mtd@lists.infradead.org, Stanislav Fomichev , Miquel Raynal , Roman Gushchin , Christoph Lameter , "H. Peter Anvin" , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , Steven Rostedt , Jiri Pirko , David Rientjes , Yonghong Song , Paolo Abeni , intel-gfx@lists.freedesktop.org, Petr Mladek , Jiri Olsa , Hao Luo , "James E.J. Bottomley" , KP Singh , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jakub Kicinski , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Rodrigo Vivi , Thomas Gleixner , Andy Shevchenko , Andrew Morton , Vlastimil Babka , Tvrtko Ursulin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Joonsoo Kim , Martin KaFai Lau , "David S. Miller" Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: <20221214123358.GA1062210@linux.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3F50FC0005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nstt1go35zbejsdmurd3xkftd7arafs5 X-HE-Tag: 1671021256-641511 X-HE-Meta: U2FsdGVkX18oR6obc64dtSQqiGCImdvkIAJefo28xMe5yCv9PSC5a7TT9iP7laVhyGmr77cpz/k2JBfYDS9fG5X7Ip7hDfkDiWLj0VUsKYniZWzmRPgcaeb0WcPLObM9B3cORNqbfw4IZWnr+Lq7on5MHQMsSoRbEckfJ/u+C335exWCwboRHlgy7fGU2d4ioIDIj0ZLH4S+sbPkDn7F4lkVASMcRel/8BWY9bVP73w3ugcFAqTRjq+oaQK/DlOMrx1r5aCQfrH7yZfR5p3ROi0f93SEosJ2/hzwV7NGeogaRPZyj6ti3GtGiZ76Zf027QTKFJA4IK1I7w4cOtfDphRhlEtp3PMcfAPDsUP84u/axCBTo5AleDL0qPsysvoRD+0wD5hlO8CGkYBu2rmiIP8BSTIgt5wzcjMZUVDGYBBOSG27ZT7Nv0HaPY6xrXYvdxshZAi5+u2y3uYGw9RT7+fpSz3lWLZqeHJu+aZqb5RNU1BhdNmYgcZ2Yf7y65X0fSmw7FaOfmx3/cLhNFjDI2i5CCVRkJ0Id2Y4+Rf+5Au1pRS53G9yBk2pZm3+o2EpDjMIav5w2yqvZgA1hHPSN+iFviFn6b1l7iz9z8kbPv3R8bfHjsvDNtQJuITdvSxe/dRCjTLIGPVK8daUpZM58eIiuUAPICSkGg+etCrcIApfvvTznVECo34GkjAtBIzqKyO8ZCNlQe+3SALyNMNENzAHNv6C9RUMdjoJ0hyjl98WSS7H13Ee2kkS5NO8Ljw3Wss+I/iQgBP1bqVLNCbFFCCRUoumqeqPTjBe5RfmzH5w+DT7J1ZIBsZI7tHCeQvlKKm9EfqZGgY1aLcq2Stqh9r3umDTuCKQTcKPwtNXrDTrSzBdFtEfyueKAHUshH7t6ZsPMuxVcfSxaNaL+833P1PasdJ/ayTsBUtS9M9LBZKdxKjvN/+dhHQimuNIjl8Q4yNli9T7YQy0PJnJisr FNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > Please CC me on future revisions. > > As of 6.2, the prandom namespace is *only* for predictable randomness. > There's no need to rename anything. So nack on this patch 1/5. It is not obvious (for casual developers like me) that p in prandom stands for predictable. Some renaming would be useful IMHO. Regards Stanislaw