From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E10C4332F for ; Wed, 14 Dec 2022 13:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21CE48E0003; Wed, 14 Dec 2022 08:06:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CCF88E0002; Wed, 14 Dec 2022 08:06:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070338E0003; Wed, 14 Dec 2022 08:06:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E7F338E0002 for ; Wed, 14 Dec 2022 08:06:30 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B374CA0E83 for ; Wed, 14 Dec 2022 13:06:30 +0000 (UTC) X-FDA: 80240935740.01.6EC40A6 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id E02C4C0024 for ; Wed, 14 Dec 2022 13:06:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bpOQNBvO; spf=pass (imf22.hostedemail.com: domain of frederic@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671023189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yc1QbOzDORGaoRGyGig0/w2cuK3MCeo5UhxjCF1vFnE=; b=mGdfmwi1r4WF/tjADyJMF0ZX2YUXYxZqReXdL1dJaVIvz4irkP+iHmLKc9qGEIF8OJGd2p 2U5IwTTu1PcmmNyx3NZIg/V3M/hRojCc1BmIA1bXQy/HvNhgUkONLIz29Ajzf/CZXvQd/9 chcB+xqat7gVOtYEIOxObkb4Se9YFXU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bpOQNBvO; spf=pass (imf22.hostedemail.com: domain of frederic@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671023189; a=rsa-sha256; cv=none; b=Es1ByVGXmH1mZW8dBb+D83ApPnmAzf6Njd5pHLnj2a9gLZAJ+Rz9N7tMsg+iTiuwzx10Xq uSGWhNbP0AbeaBKvpz/PIGzbdHfjS5JhKy5N9IQh/+0Z3IY909Gu0O7DR7JAczJM4peZy/ Wze/V6DbbNyXoDbnluTdHAfVONW4+Kw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C88FDB81694; Wed, 14 Dec 2022 13:06:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12022C433EF; Wed, 14 Dec 2022 13:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671023185; bh=lDTCePU+j9rTmUoYes8Iq93CXo/8hTpg8U7Xkcd7nSs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bpOQNBvOIxYPP5gha0MzWOwEbjSLjH+Dpxd5pdWy+dq48PGHa0SHi25xqKtlz/dX+ hPakhCKAJZHH7tb/0jzt3zANCux/YV6pzDnuh+4FoDdWqYOtCRFcBlbSw3WcAk5KLx d5iUM1Qg4MyMbe5KaCL78nXlHvtzlEA+5ycESor5Fg1O2ekz1dMvAllkulDvwE1BVs 1FO8mn0hJdG2tMoFZ32AqEpT3KPX4HBWo3jZrkignyxDCJzoUzt5jOGMKndrH9SpcY hhDyLR3BGEDu73I3M7qCEYQkbnhJO9Puq4EBFuQyi8/lfd7YxFQEViYfw/pLHV3mW5 TaYYMklb2IGZA== Date: Wed, 14 Dec 2022 14:06:22 +0100 From: Frederic Weisbecker To: Marcelo Tosatti Cc: atomlin@redhat.com, cl@linux.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 1/5] mm/vmstat: Add CPU-specific variable to track a vmstat discrepancy Message-ID: <20221214130622.GD1930067@lothringen> References: <20221206161826.698593151@redhat.com> <20221206162416.404740300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206162416.404740300@redhat.com> X-Rspamd-Queue-Id: E02C4C0024 X-Stat-Signature: bcbb7e3r349sxs4tpk6n6yiro8otywdx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671023188-262037 X-HE-Meta: U2FsdGVkX1/Ud5q8qARYRiP36XcIsbwxsNDQbcO0TabA6gGcO7UXQb5Ej/mcoxA/9FYQN7uRBq4hCZ1yD3xskyfLh8Tcye6u73za7lR+/PV6TH4KxhcYEp/9vF76rYq4Oiy66NFsj8TsleVdKDC7gQWa9folYh/kLdPCuw/X9QVKOT7DU719zyYzty9l32DQBjdsWlQDMLtALpXBAh4H6s+z/yBKH8JzLYiVoprhXeR6wvXkkVJ094h/MPoE18BAQ50dp/x/t1J9pJEy00OR0S6I4jVz91PIc40NgE9/NgTL2Jo9ZJDZndpmzVdG38VO0CTWm+6WjfSKKgbaCZMqozRL5OPqPKiVeRfUJyLcJVkpnynsUy+FKUIXUS3mM2SW2wK8wdH+MZzgMxN1tKgwgs9eucmHl2IOc0TI/C7rFkS+E5N6ud594AAJu09uSA1891a6vfvDfsVEVqj/i+ZMpQKy91YyzU3lNcfufUHR4C56B3qh5UV1+ETn4RLQwmGuuYg2IedECV9gs9m7kB/RaXfwxSgEyfXtX3XAQoCgCej2Xx9m4fPx5nqIlnsE+6BgrH+WbbDm2JnIhf3sxDN1sKsCpAeV96j5wwj95jedW4UnKEU2pocwnfWkqR4C61uy5ZCOxsicTAPizJosd8aGh3KWidircFVEdsbfoLWLq55SNRfF0lHHA/Aa0QsQKRinN5mBS0bzTcVOOzowUMMZOjsinC+DtJZse7PDl3+3M8Dvw/3rPDdV9FnSYCNj03fERB0mjkz4aHI68EAYQgyHygtJw7W3RuivXmC8/CcjYZfGzaZfmRtNLce9Y/G90HTk3gIvqjBbUxifowIYQWMiQXNOdvycJ5N0LtfzXDPE7P+AP88yGJ4/S45ennHmsriY4lxN6OpcWIK7WYBrrMaG9XkDbKoajtQSMZQWWiEuEXqtDMFphImn1lm4jSir9t8YrIk+SiDgOGKzj/s7gj+ RZb4zE7M HOsj3abL5qxdwx0fYfi0PYAUZ8bnhvdyBeLKr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 01:18:27PM -0300, Marcelo Tosatti wrote: > From: Aaron Tomlin > > Introduce a CPU-specific variable namely vmstat_dirty to indicate > if a vmstat imbalance is present for a given CPU. Therefore, at > the appropriate time, we can fold all the remaining differentials. > This patch also provides trivial helpers for modification and testing. > > Signed-off-by: Aaron Tomlin Your SOB is also missing here and on other patches. Thanks. > --- > mm/vmstat.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > Index: linux-2.6/mm/vmstat.c > =================================================================== > --- linux-2.6.orig/mm/vmstat.c > +++ linux-2.6/mm/vmstat.c > @@ -194,6 +194,22 @@ void fold_vm_numa_events(void) > #endif > > #ifdef CONFIG_SMP > +static DEFINE_PER_CPU_ALIGNED(bool, vmstat_dirty); > + > +static inline void vmstat_mark_dirty(void) > +{ > + this_cpu_write(vmstat_dirty, true); > +} > + > +static inline void vmstat_clear_dirty(void) > +{ > + this_cpu_write(vmstat_dirty, false); > +} > + > +static inline bool is_vmstat_dirty(void) > +{ > + return this_cpu_read(vmstat_dirty); > +} > > int calculate_pressure_threshold(struct zone *zone) > { > >