From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5409C4332F for ; Wed, 14 Dec 2022 16:21:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532F28E0003; Wed, 14 Dec 2022 11:21:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E17F8E0002; Wed, 14 Dec 2022 11:21:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B488E0003; Wed, 14 Dec 2022 11:21:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25E678E0002 for ; Wed, 14 Dec 2022 11:21:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2D76040F1B for ; Wed, 14 Dec 2022 16:21:38 +0000 (UTC) X-FDA: 80241427476.10.7528902 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf20.hostedemail.com (Postfix) with ESMTP id C11F21C000F for ; Wed, 14 Dec 2022 16:21:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=A6o7WY6q; spf=none (imf20.hostedemail.com: domain of stanislaw.gruszka@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=stanislaw.gruszka@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671034896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Cfk7Vpgjar2Uxb7F8fzvy0x2c9hKDfhS/SOBKcilxw=; b=a88oh5cFu5qkWKGERovXdgRTVBlLgbUF/0Y6VViGERApKekaoG5weR79ZaYTDhU6Q+pNFs Pxq/nLFNFFfsNqzxsPQAF/1cwGqICRy31XgwAqwBK6wNMkzY5fm2GzrYm5daLGk1TROju3 Wg/BRMUVs8+O0ZrHDQPp1oPAZhbOJHw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=A6o7WY6q; spf=none (imf20.hostedemail.com: domain of stanislaw.gruszka@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=stanislaw.gruszka@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671034896; a=rsa-sha256; cv=none; b=cq3/iDC0ecNDHaHgxTVi4IJFO2KlNJFQXJ/Eo9zuo8ZHczxo/pReltswmao8VR6OMxzRYh IHyq7zzk7ZEGljQLy2OsjjUPeyvYkKkn+KRhedSDxuQWh+qxhuY8nuNwqXi86NZHVDDFfH ALnR37PMTH5TK9QH7nUznDUTYXicjAg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671034895; x=1702570895; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sugwmwrUIAbwUVd9kUUcbnqMzWklglljdUgzpTG789o=; b=A6o7WY6q1gpfO/R3whZdG/MncXkq/rBYRK/CnF7fgYhYVrv/7KDMk23W QXg0qun2nigHzbPDUnubfYM+X1Blobyn0Tm75vdYHx1AigJQQiOgehw47 1pubMNQhnFEUIuTvg12FWE2oUTlgOBtqq2dpYJwDSAXe6/B2LyTrN0DiH JNOlOopzvLZY3d3/HHlEaL3BgR86NdCeoAZr6wO6EDwZxLfmpLkXb03E1 cJXi2x6vw/aO8dXkD8mJrwx0usmc6C8RmdDTZTGo1gKkUY0xrmOGi30as NclaeRpeABZM916Ym72szcL5aljkScsxIgU1/AORsjn3UJcX7QfFTqU2M Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="404716295" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="404716295" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 08:21:33 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="642559944" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="642559944" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 08:21:20 -0800 Date: Wed, 14 Dec 2022 17:21:17 +0100 From: Stanislaw Gruszka To: Eric Dumazet Cc: "Jason A. Donenfeld" , Vignesh Raghavendra , Peter Zijlstra , Joonsoo Kim , Roman Gushchin , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , linux-mtd@lists.infradead.org, Stanislav Fomichev , "H. Peter Anvin" , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , David Rientjes , Yonghong Song , Paolo Abeni , "James E.J. Bottomley" , Petr Mladek , david.keisarschm@mail.huji.ac.il, Dave Hansen , Tvrtko Ursulin , Miquel Raynal , intel-gfx@lists.freedesktop.org, Steven Rostedt , KP Singh , Jakub Kicinski , Rodrigo Vivi , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Jiri Pirko , Thomas Gleixner , Andy Shevchenko , bpf@vger.kernel.org, Vlastimil Babka , Hao Luo , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Jiri Olsa , Andrew Morton , Martin KaFai Lau , "David S. Miller" Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: <20221214162117.GC1062210@linux.intel.com> References: <20221214123358.GA1062210@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C11F21C000F X-Rspam-User: X-Stat-Signature: h59ikitcchict5iachkt4ninfrug5tzo X-HE-Tag: 1671034895-325164 X-HE-Meta: U2FsdGVkX18ctClqKGFpBLNW/TINO48KF4qKS0Sh1tv+gSk1Ucdjoo0GnYkL9r0qcA0W6AhrYvvGRY1fniHtDh1g26iHVjCPOMWHr2XbYtOXNB1yMbRmZcpaR/0ZZNXO3o7VOKUFfIkbMsrOFjWjsor+dSVKOXaSPZ/TBJITXYghwX4eiyC0jd2tRg7dT1NXmla2qPKPHRPaxo8aSFuAE2jxQdBt87w46M1mZpJw2ns1aVz49LkEnzi9rc2bkO3xOh/InfYIGlBjizWit+GNQchmpjjoWOVn13FZtKmgBPW4VlwYp/CW+80DO6syPTvyg7wMrtEaSy5lF+qdnF0xpFqe/Q3Oe/ns1AgewgWvxsfRy9utG8chdIE+jLWGElENRz4NjZ4hN70wNdtd7hLfO5sU/QDnP5zvSZPD7EIaXq1S41KreF2/kijqRlLlcRhMtUk6vXlDXchdN73TDR9Dfv7dJpx15sHrr2ZiQKDiAq8DwtceoTd50MUP0/Ja9oGJYpeje3Sw23h0odBAiX6JrSGSlH/glt9A8fwL3dnW13VptzjcDK3mizoC8+9yJfPkcBopOM9+8vbYbB9CKJImSCqFI2s+YyTv+3ZXOnxb4GhbO8l1Nw2g2yjs2AaYN5PdczBITazqanxfoRK4VFVEdixHl+LTHATi13UtNrnxZB4Nb8qyVIsRb7rwwqR+YDLqXjx+nfLA/lUU8ni8RhR8e/aMwaG3IyhJGZMXzVtY4vZtuldWQpdgqqo577Q9/Cp8+6YNoFFcCG2akI5LdTn23IzjNvdp4QVEEhoPBT9m8L/8oJJ/O947gtFeKsnhltJH72hU1xF+HU64srlJ7Sv1aDtyJb1nJMVsn1uVjgMcS5xuSCl5O1e2zNto7YphOVAzRDLVVCWjmlT9lqftQ5Mx+XO/qDGU+s+0XKRVB2iKSx6N+S6GBeS6lY6PVATFXRrzN42oP3m37H7g/zAKhv8 HlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 04:15:49PM +0100, Eric Dumazet wrote: > On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka > wrote: > > > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > > Please CC me on future revisions. > > > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > > There's no need to rename anything. So nack on this patch 1/5. > > > > It is not obvious (for casual developers like me) that p in prandom > > stands for predictable. Some renaming would be useful IMHO. > > Renaming makes backports more complicated, because stable teams will > have to 'undo' name changes. > Stable teams are already overwhelmed by the amount of backports, and > silly merge conflicts. Since when backporting problems is valid argument for stop making changes? That's new for me. > linux kernel is not for casual readers. Sure. Regards Stanislaw