From: Mel Gorman <mgorman@techsingularity.net>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Marco Elver <elver@google.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list()
Date: Mon, 19 Dec 2022 10:07:34 +0000 [thread overview]
Message-ID: <20221219100734.jag6zejp4tug77yq@techsingularity.net> (raw)
In-Reply-To: <Y51/Mt70d++6Zzzq@lucifer>
On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote:
> + Mel
>
> On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote:
> > I think we're waiting to see if any users show up. It's only been 18
> > months or so, so perhaps wait a little longer?
>
> Apologies, I should have researched the background of this further. I see it was
> added speculatively in 0f87d9d30f.
>
> > Also, if we do get rid of this, then __alloc_pages_bulk() can lose
> > the "list" argument.
>
> Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage,
> otherwise we can drop the idea and wait for users to emerge.
I reckon we should give it another few months until May. There has been
one user recently that tried to use list but it turned out arrays were
more appropriate.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-12-19 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 0:15 [PATCH] mm: remove unused alloc_pages_bulk_list() Lorenzo Stoakes
2022-12-17 4:56 ` Matthew Wilcox
2022-12-17 8:34 ` Lorenzo Stoakes
2022-12-19 10:07 ` Mel Gorman [this message]
2022-12-20 17:56 ` Yang Shi
2022-12-22 12:44 ` Mel Gorman
2023-05-31 15:24 ` Lorenzo Stoakes
2022-12-22 10:03 ` Christoph Hellwig
2022-12-22 12:38 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219100734.jag6zejp4tug77yq@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).