From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A7CC4167B for ; Wed, 28 Dec 2022 17:55:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FC958E0002; Wed, 28 Dec 2022 12:55:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ACD48E0001; Wed, 28 Dec 2022 12:55:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475128E0002; Wed, 28 Dec 2022 12:55:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 360A58E0001 for ; Wed, 28 Dec 2022 12:55:11 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0E9ED40417 for ; Wed, 28 Dec 2022 17:55:11 +0000 (UTC) X-FDA: 80292466422.06.529A93F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf16.hostedemail.com (Postfix) with ESMTP id 7A53118000B for ; Wed, 28 Dec 2022 17:55:09 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NqhyqECt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672250109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8qpS2YnwcxR/5KmuaGiAH+UbEjCD37BBLTvoifB1Qxk=; b=Dwci8JBH+rBgYquCnDniTTda5y41l5fyIKh+ruyfOn9xFflqCUpVeUeWHNvvF+1usYAglY azX6oc16ouBgSBeQsCRGrWuNZmbJYxCwiP2Vi3UPNU+GYe19IZPgVYeWkqVvGo49ilXUsi vmZq9WBEQz1LnNzc7eTMYR5lgZV9OZs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NqhyqECt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672250109; a=rsa-sha256; cv=none; b=WoiZSikcIw0MF3Y+pi/VUa6dlxrYIzPP/Zf+xGyM0uCnlsYIUgRGZwAqFzPW/CWI6rNj5X Kwvime49OGladzSLorHKmWuRrGsNMBRKovwpaL9rs9cZL6sSPcz/QEDsTTiMqW5yKaBEGL e4K9JMw1XuhBUJboMt3JHIqaj6JCF2k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F26DBB81710; Wed, 28 Dec 2022 17:55:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25CC3C433EF; Wed, 28 Dec 2022 17:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672250106; bh=R4VIrBez7zH9MYP4YY6ze39/ChSx4hb6ppbwjxME1iA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NqhyqECtyME/yqrpVaueW9+tRVTRF1BCu4Nbc/P/tAGBhoK4f7RoSsC2IBkhs8pWh VBpwm29g1Nl/oJ+JizOczncIh4WxMovAGvgNzds3M4FC0Xz87RkRRMOy4B/OaJWMWO pzwQiflKbkpTpzf00zjQ16GGKVN10ZbePSvhABEn3G9nwh9eXXbRJL2bMBEbs/bA8V 9Xq2GZ2hso7X9dRDXtU7RVtwhVrzHWEMC3R35ZrenzIgxE3b7AyDFwuLCSpvx2OXPT loxViyye08fiB6wsiSWNIBQOVOagkMzI90z2jZ+a1uwdkLhUuZ4s0PkVoPJ5/N5Ugu c+nha9nNWbIxA== From: SeongJae Park To: Kefeng Wang Cc: Andrew Morton , SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, vishal.moola@gmail.com, willy@infradead.org, david@redhat.com Subject: Re: [PATCH -next v3 0/7] mm: convert page_idle/damon to use folios Date: Wed, 28 Dec 2022 17:55:04 +0000 Message-Id: <20221228175504.149395-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221228113413.10329-1-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7A53118000B X-Stat-Signature: r6dfm9ykngh1krn74oxpfqd6pcff4rn9 X-HE-Tag: 1672250109-41578 X-HE-Meta: U2FsdGVkX19KfrtkWikFP/OPxb5I/QanBTRSMBbmdA6aq6f81vR6ktYzww14Q4lnJPdyL4u5DG8Sv6aaAkL66FTahuqN2BVY/WWulHugT1lT0hPG59JJ1wa/PfO2u784KLYe3/9dvcG6amgFhs28Ca0oyvDx3h+pYWN7V5gjCT0QavkE6FbK59r1UTeaNXOTSMrubqQCD3G6lNPA58C2jvOjESCJ7C5mXqa/pcuYEwBXPtPSA+baPgh+pvhkvC4Yl/14aCGovZmYXyvUv+JpvKGXnK7Cs+/Ta/1ud5bm2Rx5hoXpiNFzIgMc6H7JkjMHmigboh7KjHa7jbe7fh/xYqpIK8yjPMSyYhHKK+Be1C9fPHVIx+xUUWocdYBi3okvPSjmrHch9AdltPnL2WWXEDq7k1uoSmhfAVAbvj+YKupB+nyaX3raCxh0l8cHJo1geJ4yWkf/ARmYv9Vo+ePTJlHeJZoxRMS8iEUWJBg4pyZ7uGfPDM4X4QlD4ZrdvD+GW1WmFYAXmtXs2ah7FDtM8u4+8/T87bv5GctOht6xySoDW1+NlPL1IH6Bu89gBECKObaGiv03L+c7yWUXwzIIbRLE2VpIljqmM3pwX/YgCOS4xEKp7N9tLYZq6J+OZEPU0FpLrf2qPYPsiSy28keHc3QgbzFTixf1hUy+EoAUwXgFicDrnityF1fQJ5WaW2EgglB93EmOw1dJ0ZtJFi6UsoRa1FDDtqS7/V5DNDSNyYtuKAkmqwARuF1f7CwWxq2kVxjJWJf55Nv4dQdn6HWY0qv8DNe1wSOtQwvfvVTbnvicEtUCvwDh5WwrjUAvbsRms26HRNjnL5OHpEtUj/8Bufmg6wahsCXnb8s0GNjnO+OzKWfJjwoSfhvzLIPA3GpNlZ9gx9kmhGr70HeL/4xXsPgeHHobAXdRjeeAHCxFZAydwjBCXBI9QeewFSCu50SOh3/PP/v1aKDdXfa+nx8 lMrJ0SeX YBatd2EL0eyf93nlRIybMJwUoUdZGFTpCDCardmNHic+m+IYgZsFOEDp5OKhn4bzb0nrYIfS6rsGt2il51H5G2BUfAkIjpO/+9MhCDnAj5WMCE6m93AreyZPrjNaB/4WQVbpqCNC/VMuqXqv15VYCp28sx1eEr7ahtt8umDvlHoMJIyjsfZvoCyv4ckq2mW+ndA5n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kefeng, On Wed, 28 Dec 2022 19:34:06 +0800 Kefeng Wang wrote: > v3: > - more thoroughly converting in page_idle_get_folio() suggested by Matthew > also do it in damon_get_folio(). > - address some commets from SeongJae > > v2: > - drop unsafe pfn_to_online_folio(), convert page_idle_get_page() and > damon_get_page() to return a folio after grab a reference > - convert damon hugetlb related functions > - rebased on next-20221226. > > Kefeng Wang (7): > mm: page_idle: Convert page idle to use folios > mm/damon: introduce damon_get_folio() > mm/damon: convert damon_ptep/pmdp_mkold() to use folios > mm/damon: paddr: convert damon_pa_*() to use folios > mm/damon: vaddr: convert damon_young_pmd_entry() to use folio > mm/damon: remove unneed damon_get_page() > mm/damon: vaddr: convert hugetlb related function to use folios Thank you so much for your efforts on this work. I found I forgot mentioning some trivial typos in the first, the sixth and the seventh patches, so commented. I should have commented those earlier, sorry. Other than those, Reviewed-by: SeongJae Park Thanks, SJ > > mm/damon/ops-common.c | 38 +++++++++++++++------------- > mm/damon/ops-common.h | 2 +- > mm/damon/paddr.c | 58 +++++++++++++++++++------------------------ > mm/damon/vaddr.c | 38 ++++++++++++++-------------- > mm/page_idle.c | 47 ++++++++++++++++++----------------- > 5 files changed, 91 insertions(+), 92 deletions(-) > > -- > 2.35.3 >