From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BF7C3DA7A for ; Thu, 29 Dec 2022 21:31:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D77A8E0002; Thu, 29 Dec 2022 16:31:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7873B8E0001; Thu, 29 Dec 2022 16:31:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 676DC8E0002; Thu, 29 Dec 2022 16:31:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5AD448E0001 for ; Thu, 29 Dec 2022 16:31:18 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 308FA1C6168 for ; Thu, 29 Dec 2022 21:31:18 +0000 (UTC) X-FDA: 80296639836.23.07BEDC8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id 8C2041C000D for ; Thu, 29 Dec 2022 21:31:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MVwsIyiS; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672349476; a=rsa-sha256; cv=none; b=IhN3zyB2ur9ds901vRxpMTdBoXO1iThvlN2wnliRJNd0aLLhwR1wCS/q/DYyDAzDQfpqTu yXwMKAHX/y+H8UK+erxNd6VeCDN4s1FHmeguJlIO1ZNbHfOYug76hd3McJLUlqTZI9x99+ Uav8dXdSJVbIRpqDP2aXt/cQfIar9Kc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MVwsIyiS; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672349476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g25nrK1LvHeZBm5UbJfUIrRSCRBVh3OgpT+dzzr4yYQ=; b=K6yJaJbtj3uK7dUKzV1gY1qPVOLpiVNYJdCysfNoLpij/AR9Tss+CsckZDjraQNJu1lhYy a729mtUQiiWn5DTfEhdgYo9oVlB7/Vjl5FZgyZLUQdupyCBvOHR9C3EFJgisAQ+YNq5mhR zPaW9DZisDEIcv7Revs2i7x/MCIy7Q4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E4F5B801BC; Thu, 29 Dec 2022 21:31:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C46C2C433EF; Thu, 29 Dec 2022 21:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672349473; bh=2Y3imQo7xBglzfZKMiOT5BUj+bBiKnbjHMGtXf4KXvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MVwsIyiSLE+qdHHryUYdFWEYA0z29hbOruGvTKsou3fuioE+rWLn81bWLU+2mfT8b nY0aDxVk2C1RpGhrHEC0+1Ctu8CDIXMNk+jVN0MLreoSrKaEM/PWmbWE6k5nz1LODA I79i7rLW9IrL6qIwox9EiY/MNSL5Ipf3VY8/m86GL7YnPt6sybtwqaDSvk5M6bILiT 91s3U5BVy+5KfSwJolIkfAEFmE+rUtHetFSyZVLF8kSedIkwWIUvSFd6p1LetzGw+d CrIzCqMEXdwchu/jqTgE7q57bWEAHdsbahYXBcBTD4QZ55u/wEK1F2l49kY5RJki3Y RFeRofCmla5qQ== From: SeongJae Park To: Matthew Wilcox Cc: Kefeng Wang , Andrew Morton , SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, vishal.moola@gmail.com, david@redhat.com Subject: Re: [PATCH -next v3 5/7] mm/damon/vaddr: convert damon_young_pmd_entry() to use folio Date: Thu, 29 Dec 2022 21:31:11 +0000 Message-Id: <20221229213111.163524-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 8C2041C000D X-Rspamd-Server: rspam01 X-Stat-Signature: qf7rta8wkp1ys9egkqkxrwesnu4yg3kq X-HE-Tag: 1672349476-427703 X-HE-Meta: U2FsdGVkX1/Iut2U3RH9dYtmCvkQXUd/7RFqyhLcFrjAXpAJZk3RJVG49SoEsfUSB+owo3qW9Md10fJpM2tzr50+yS+XDZj5anSlw9OeAZLQuXzy7zRhF8eQjLujjaBjrJORFgzT3V/+dAR3dVwDuXA1ksmwjUq6eOq4Pb/m0FfMItpd9+hXV85ozKCcWDy2z3N6Sez5yS2K+93mFBuQUEjZn9jsMHzGlaXYsv9WU1aElOLlHqw1PUokR3v3Vnyj+Nzy3RvkahIgAEZIiy4yCSuR00OyeoJnAcjl79Lzjfz1EvBq1zMn26s5enyBHygEWTdASYCKPCHhV4VO/6vUAPZHWF+yNjSv9XLT+61oZJsLTTcPYAARjQGIpA8zSy868AufXht6ADKZO9w+pB1M5oNJV+6lXH4V1gMtoCnzE8jAbfrZTfgnpPS67HcTODs0eFrBvJtq9mUbv+539qNgHz5qEpcQa+/mCaPoA+rcZQL27LsIiQM0y1dqBhEgu+M0YSRLQDdoxJZ+yhQMS0zifmrk13gcOYpR6dDt8ordyjzI0Cc4Fdpmw61MYrmCbniwgoinvwl6DSx28Yl63NG0tOFWhEZMsBjChd0C6ukrUKgIb7fWfk6iYUyF4Jyhxes9eQzD4+sSQjz/2AKq9WYTTW48mD9N3fCPzT1O5jKi33zr5NKmrnMeWe4GnbhodgGX1DoRtvKPq05kJj8vG/No1PKtG+/RrjHCv0/LMX/NpjCopCBqMKM6hIR9++KTArOqo7/UEMqfgW/bNpm32F57ibe6tkneG301SHXObb48L6Da45+7nyvc4JpjP8Ux3DsgIx0HOIzXhcCISeRxC1RUx8qFwXZnz9EFX1irkLW+DgxWGqSk65c1UReEEAPKywTJO6Do0LsNc/43WKhCuhqIr0JjGhHBWaTdNnBldqk50P8y1aFcvYScaXAjk2dvFVukaYSc1J7AyxghQXklpfe 3wWbJSKg JsUn1BcJ4oaBeWrYYp8NOlycJGtCv8ZLQxTeCzEui18vehrNa55OP5SVhHnCH6fxp57CD5EsGjloj9LSObx4IRiGI+JX19oIwvrnkgofLwfjaofcqw80uFIhCdyE1oR58gSq/ekyJwG0OlZgHA62EAaRrp8UDi4EwETswWxRd1w/BhepWmGtNR6Mmgf6CO8jWkHUU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 29 Dec 2022 21:06:12 +0000 Matthew Wilcox wrote: > On Wed, Dec 28, 2022 at 07:34:11PM +0800, Kefeng Wang wrote: > > - if (pmd_young(*pmd) || !page_is_idle(page) || > > + if (pmd_young(*pmd) || !folio_test_idle(folio) || > > mmu_notifier_test_young(walk->mm, > > addr)) { > > *priv->page_sz = HPAGE_PMD_SIZE; > > hmm ... > > > pte = pte_offset_map_lock(walk->mm, pmd, addr, &ptl); > > if (!pte_present(*pte)) > > goto out; > > - page = damon_get_page(pte_pfn(*pte)); > > - if (!page) > > + folio = damon_get_folio(pte_pfn(*pte)); > > + if (!folio) > > goto out; > > - if (pte_young(*pte) || !page_is_idle(page) || > > + if (pte_young(*pte) || !folio_test_idle(folio) || > > mmu_notifier_test_young(walk->mm, addr)) { > > *priv->page_sz = PAGE_SIZE; > > hmm ... > > So why aren't we doing '*priv->page_sz = folio_size(folio)'? What does > DAMON want to do when encountering folios that are neither PAGE_SIZE > nor HPAGE_PMD_SIZE? Good point. We use the field to know if next address to check access is in same folio and therefore if we could reuse the last access check result. So it would be better to use 'folio_size(folio)' here. The field name would also better to be 'folio_sz'. I will make the change, unless others do. Thanks, SJ