From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4530EC54EBD for ; Mon, 9 Jan 2023 19:28:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F1168E0002; Mon, 9 Jan 2023 14:28:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89F548E0001; Mon, 9 Jan 2023 14:28:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 767928E0002; Mon, 9 Jan 2023 14:28:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 67C9E8E0001 for ; Mon, 9 Jan 2023 14:28:37 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 238E1A9000 for ; Mon, 9 Jan 2023 19:28:37 +0000 (UTC) X-FDA: 80336247474.14.86BAFC1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 7CF8E180005 for ; Mon, 9 Jan 2023 19:28:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OowNnYnI; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673292515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rE3kQy/LwZMTEosmlMgq1xfzlTNEk8MEynAN/Bg5qPw=; b=P10pd6a82hTKfGVvAClgpDAWbmIBmM1M0JvPE3rjYj2yQm2mSe8MLkAuVIQ46gtfWkEORp Mxg0wPSaIFByyv0PX6Uk9+AHSfDgaZv4P+SwPjSa5d/bS9Ffij+9+vw8Z/d/CkbcfN876y yne/3kyOWMT5vG7HvP3s56CleWhPA0c= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OowNnYnI; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673292515; a=rsa-sha256; cv=none; b=c/kE+lVU+VMFT0ewzJgVrzftx7lDyKrpBiyFkO16jVmxBQ+UWNl0m+B7Ll305sv6ZIkF9x d0rylM8eSJE67aWVey21T8QBk7cxSk7RCmNmO/Tv5yy0W4hmCqVuByVyAle2qU8d94XxOw ajI66BvFAGukbjytKEsiyErMYW2Wofg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CBDE61115; Mon, 9 Jan 2023 19:28:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ED8BC433D2; Mon, 9 Jan 2023 19:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673292513; bh=N4nFMKavoUqojR3nB9WdTnhsDQneBJM2upN298Etx5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OowNnYnIwRfcPN1hoyJEyTnQQOwaxsoMsmFDDxyvRL2NHuhPq6INcfewJfyy2RYmZ 9HELSYT3iwla32ma8gUl1IC40miQhIHuYNPESIHJciLGlGBxKcjInjZ6WMT/fCknfI O622+eZE3uHdGfYj7zp5Uhwo11ou4SfFS1JnL0k/GY8i1Y/W5o2LhmrR4ssP1IaiQ+ fyfvgkKQtZRQMwpWRCAy6NqwyDKcABvl83g9AGLJ3aOJK0wS10hUn872DnCyjeTe3l /dZtKyII/ytAREY/8Tfy8xONgv0LIAoDV6Dt7E9q0UEhlIIvIt48A4zPYaf3aBD2hX mbgjaAeajIhkw== From: SeongJae Park To: Liam Howlett Cc: SeongJae Park , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v2 22/44] mmap: Pass through vmi iterator to __split_vma() Date: Mon, 9 Jan 2023 19:28:31 +0000 Message-Id: <20230109192831.61258-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230109164533.3qkorup75h3zsi7t@revolver> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7CF8E180005 X-Stat-Signature: ep55n6wzswywif3frpj4yhxbuz7zos65 X-Rspam-User: X-HE-Tag: 1673292515-916225 X-HE-Meta: U2FsdGVkX1/li7lqlVV4mCxF3qSY2oKHwc3tet86SarHoAi0s2fJMesSY0a8IBEhz9utHejWSlf5wLyGn+5TLKkTJz6rVbKgWDRaUbJVIat+7lqr7ve1FkgPaSodSSjp7Yr6ZoBs/GJjmvZc8Ki8un7Inavr9F/Ed4KDvun1Mbua9FYzfvXiws886L7ChnNDxopyg120SV7tmE0Ehy2uRvAdGtJtIqiONgdd9L7jSkaz1E6g8XqBghx66YDey+VEoAlx5kd482vNmK3QMrMXiCr7ne31Pt2E6W6Rc3X7RNpMK4ciIo4HWORGSpm0RZFa28jfvVLtD43nqZufAe2uL+0+qKoIHzCixYVZaQtlpuM0bUpvYrTXSpCRkCuCXRYxKlJC/CeoWfi33ghlGoKspzxd+9b2gW5sh3Es0plG9xYjClTts+su1JT8erOqq+lZ0KXESYQVRh3h6vM+TnYfX/ElH0derJl7Ne8N9LAr7wtk7rZ7dKzE2YFrfTt+iWSizwBymDdl5DnspFkUYEBFooZouc37Tzj2YbwSVtJn5mUIXka6A6V8/NHGa+/VeA8JN4jI4B46dNL53MPRwsOCeK5bVMuPYDXmWYqUO5uoWJrX7ZwptBPkPgIb88E4MoMqzRI3L9CdWUIY7YUvDCh+bozqR5Lkg5FeHM4AKOr/RHPN70rAgHonSRNqvxjW8XFW6h1YC/x3yIGol96mq8PNIWnEdmweDjFJExs9l5wKk5LJsMxBE8COs+R21GMEvfylGaNvmSQMSL2Q/AEljKYJrCvSy/ep3tPRJXFS8cyk1WWDjsLR58PeUv22B6Gd3mZszw4J/vr4FXlqtvr8nC3T8qL5R3r0rVoG3uBTz4G4pTBcD+dsDYpKGX3iQP0czYBN3OPqXE9q+45P9jjdiUT+shw6XNsjoHDjBN7dbbcsK1Aw6Hh4HWrgghOiDKn2vcJxKvcX90HY487y80OLP5n XRmtyf8P dbYnY8CNbIvc6lvZKsB9Csqeur9afXoZYysmiKnQw4fvnYa6hmlJos3S+PmyAI6zmPEVNpNoPC/85CPdxov0O8Ke6IMwd009mysBzccqbDQ4PTDTnYKBl5PPjSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Jan 2023 16:45:46 +0000 Liam Howlett wrote: > * SeongJae Park [230106 21:40]: > > Hello Liam, > > > > On Sat, 7 Jan 2023 02:01:26 +0000 SeongJae Park wrote: > > > > > Hello Liam, > > > > > > > > > I found 'make install' mm-unstable kernel fails from initramfs stage with > > > 'not a dynamic executable' message. I confirmed the issue is not reproducible > > > before your patchset[1] but after the series[2]. > > > > > > I tried to bisect, but on a commit[3] middle of mm-unstable tree which this > > > patch is applied, I get below error while booting. Do you have an idea? > > > > I further bisected for the boot failure. The first bad commit was a8e0f2e12936 > > ("mmap: change do_mas_munmap and do_mas_aligned_munmap() to use vma > > iterator")[1]. The stacktrace on the commit is as below. > > > ... > > Thanks for your work on this. > > I have found the issue and will send out a fix shortly. I am not > handling the invalidated state correctly in the write path. Thank you, I tested the patch and confirmed it is fixing the boot failure. The 'make install' issue on my system is not fixed yet, though. While doing bisect of the issue again with your boot failure fix, I found below build failure on a commit applying a patch of this series, namely "userfaultfd: use vma iterator". mm/madvise.c: In function ‘madvise_update_vma’: mm/madvise.c:165:11: error: implicit declaration of function ‘__split_vma’; did you mean ‘split_vma’? [-Werror=implicit-function-declaration] 165 | error = __split_vma(mm, vma, start, 1); | ^~~~~~~~~~~ | split_vma cc1: some warnings being treated as errors Maybe "mm: add temporary vma iterator versions of vma_merge(), split_vma(), and __split_vma()" caused the build failure? Thanks, SJ