From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3435C5479D for ; Mon, 9 Jan 2023 23:07:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F02C8E0002; Mon, 9 Jan 2023 18:07:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49FDE8E0001; Mon, 9 Jan 2023 18:07:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 367768E0002; Mon, 9 Jan 2023 18:07:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 26D988E0001 for ; Mon, 9 Jan 2023 18:07:56 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EB473C06D1 for ; Mon, 9 Jan 2023 23:07:55 +0000 (UTC) X-FDA: 80336800110.06.2161C93 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 633B8140009 for ; Mon, 9 Jan 2023 23:07:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tBNY5A9o; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673305674; a=rsa-sha256; cv=none; b=qNr5wCwEyNX4gyIvZD7CevIG/IWtqJxEml0rO0f3z9AwjTsWJ1E4qa+8+wBl0hcrFfnAXv Rma4VhjFQI4P6eI16rtIXH45x9k+Fn/6/dyUNOfKqX12VmnIzBhHqJ/Zkphw89gqDIlhj1 XHg2lzHLdIZd5WR+peOZaMq1BTvBbo4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tBNY5A9o; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673305674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RI74sXlV1oYz9/TLIBHZWi3rT+fmeU3E/LfGXNNGwiw=; b=zeihixqiaqHM0n5WwR7sTq30d1CbNHFkVurEZ4/K3oXL47lVMPboDbM0CwClH0nvq9ozYS 70cpepufiRRLfJ81ysKHLr9TREO/RFl/NciOLJjyk7qxy0hR19oXsnkqihhZLU9XHy0Z6P UhiHeoJQr9tJk5KqLgnPD+aldBWGLnk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46CEC61466; Mon, 9 Jan 2023 23:07:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05239C433EF; Mon, 9 Jan 2023 23:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673305672; bh=L5utGm3sciYJfzyl8xq+sWm9uedBplaVJst8aID6858=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tBNY5A9odUkTWdZMLtW1JVqx7lQN5VNO8xIf1aStfqTY5H+QO0/oBho8oL1Q9Nj6B cse7V99LhOoqt7HhTsitgDBwKVx54aj4E8V4X8NjvIzSFiX7Iz1JFfrT5q0K2BHhVs rMgxWE7W9HJWmoCniTRr+blvWwRy522Br/wC9kr/CLyV92nFaQZCTcKENHE1rNBQ0M xuEf741egdpOlrj1V2tKMNVWZu9VQEEI5WSzFzGwOkOHSlRewI9il7Rxb/TrZsav4G 3Z+1Ost16bmlbzpFvIVRBdBuRi6YqEjbRyojgDl8kg611FUDUhxhK3yeyqDp4VpwNT RcxISpXLR1Qpg== From: SeongJae Park To: Liam Howlett Cc: SeongJae Park , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v2 22/44] mmap: Pass through vmi iterator to __split_vma() Date: Mon, 9 Jan 2023 23:07:50 +0000 Message-Id: <20230109230750.7211-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230109203026.nqwhze2d5y62z4tf@revolver> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 633B8140009 X-Stat-Signature: 6mmjdagn8umbzkugqsqb8n15nfub879i X-HE-Tag: 1673305674-165583 X-HE-Meta: U2FsdGVkX1/oKZb+6RfQRj/q8Xzlh8qrala/B3TlbX27OO7lSr8Ww8CMLnP1zV38u5EES/Fkx3Iv9D/NnJqtVSdYr1mvJJTcmJrW3vjxX0ao8MOcPEv9XdJHhaU9gvl5OgU8T5k1iiS0JbpDfHxotN/BjXQ0/tMxIDhTo/XcjvlvOOVVv3C06nijoaVJNOUCVbiw141UGdWuQwfPacninWQnwqueWby2s5Iai2AldoQUpFNTO8pOKN1ZKdfpo+us5trVrho3I6He3PtUA6wrlfM/Nv2bb5Yoyi70XwPN1/7aHks9e1z0eoD/p2lLT9OvCJn7+K0D2XunepmD1CcN3ZNWkA59dkaRIjgpKv/825uLVInN7hDm6DRUr8OHzW/k64uZTbUW0tO+86bdwKFDZ0w7Wa36YWEks0v8ebtEUZl03reom8YYqMBL6WIsclKqwKLuuRGhuCOpdexRAYJvROwRVSdYEWXoXR8CywHGzFe3fyOyTw+BXdJ8zMHlclhU6PVuSpjTqY5OckmwHIY2hjuo6nBIjdhb3rwzVYJdyfnKQf44MIbAJoj/jkG472qwzW2L2rmKzfCmPS5MboPTU6wPb8AFgCLMFQtc7bx0QxT4xlKZTUhYgIqyu9IqFynwBqLDdh37b9I2KwNa0ni/FzjeveJwFz+nLv2RxUTAiDypypWaSAs08hK8Pn9mPuLiaAAxdLe+6vx2Of9NYisjQBn8SatrB3RJ8qjuH/RAlYLxNioS1Sdz6MLVcx9LY5xa1addKR8TOHlQlYZKuoUVVR+sJaPGdtp628vB8PnbyRfBiUAg4kvcrwWNfdz42RQzSlgpoZUEA9avx4hO6INcsLafpPwq1NYxCR9e4pOPEHr2VBzC+Zky86MTL4FdqToY8VYc5PrFo07NMF0MmTPT7OtYkU2ZKeUUmLsV2SNz6xr8is4CvvfVs8gGLFZV8p/IMYyZRWL444YF3z2HXRH qB6s39q1 4rl+ymRy6nAojVvqKB6JKylKqh0zP36KNzQOtsh8v0ivOT4oPFkQtZpyDT1YGCDZjPTklGKjpCfvnqvcwJu3795hCIlKIr605/yWzChiFZvH2PBRy/C6Dss4QGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Liam, On Mon, 9 Jan 2023 20:30:50 +0000 Liam Howlett wrote: > * SeongJae Park [230109 14:28]: > > On Mon, 9 Jan 2023 16:45:46 +0000 Liam Howlett wrote: > > > > > * SeongJae Park [230106 21:40]: > > > > Hello Liam, > > > > > > > > On Sat, 7 Jan 2023 02:01:26 +0000 SeongJae Park wrote: > > > > > > > > > Hello Liam, > > > > > > > > > > > > > > > I found 'make install' mm-unstable kernel fails from initramfs stage with > > > > > 'not a dynamic executable' message. I confirmed the issue is not reproducible > > > > > before your patchset[1] but after the series[2]. > > > > > > > > > > I tried to bisect, but on a commit[3] middle of mm-unstable tree which this > > > > > patch is applied, I get below error while booting. Do you have an idea? > > > > > > > > I further bisected for the boot failure. The first bad commit was a8e0f2e12936 > > > > ("mmap: change do_mas_munmap and do_mas_aligned_munmap() to use vma > > > > iterator")[1]. The stacktrace on the commit is as below. > > > > > > > ... > > > > > > Thanks for your work on this. > > > > > > I have found the issue and will send out a fix shortly. I am not > > > handling the invalidated state correctly in the write path. > > > > Thank you, I tested the patch and confirmed it is fixing the boot failure. The > > 'make install' issue on my system is not fixed yet, though. While doing bisect > > of the issue again with your boot failure fix, I found below build failure on a > > commit applying a patch of this series, namely "userfaultfd: use vma iterator". > > > > mm/madvise.c: In function ‘madvise_update_vma’: > > mm/madvise.c:165:11: error: implicit declaration of function ‘__split_vma’; did you mean ‘split_vma’? [-Werror=implicit-function-declaration] > > 165 | error = __split_vma(mm, vma, start, 1); > > | ^~~~~~~~~~~ > > | split_vma > > cc1: some warnings being treated as errors > > > > Maybe "mm: add temporary vma iterator versions of vma_merge(), split_vma(), and > > __split_vma()" caused the build failure? > > Yes, it seems I removed the external declaration before the function. > Thanks. I continued bisect with your fix for this[1], and found my 'make install' issue comes from 'mm: change mprotect_fixup to vma iterator'. [1] https://lore.kernel.org/linux-mm/20230109205300.955019-1-Liam.Howlett@oracle.com/ Thanks, SJ