From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BACC32793 for ; Wed, 18 Jan 2023 16:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2D2B6B0072; Wed, 18 Jan 2023 11:42:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDCCA6B0073; Wed, 18 Jan 2023 11:42:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCC036B0074; Wed, 18 Jan 2023 11:42:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BEDCC6B0072 for ; Wed, 18 Jan 2023 11:42:15 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2CCC8160C6E for ; Wed, 18 Jan 2023 16:42:15 +0000 (UTC) X-FDA: 80368487430.14.BDAC0C4 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 315208000F for ; Wed, 18 Jan 2023 16:42:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674060133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6tNDSNkFiJEqqIZ//J/1DmHsVFKzcFqD4Ly/ZSfJnDY=; b=FMhLpoDhKalD0KSwzocvdFqLWu8tZsWs0B8J3elKisiALBEMYNFtGmLmzw6CBuTvkmDNdb 5z86/czwy0y9PUi37/qQTEWf2VUDeerzt6mttVEBHhH5SI6i6fPqTkwnP2XLnGf8a7g5Fg lH1pvmWcuykaXDz+mDJn/JnVd+A6ehQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674060133; a=rsa-sha256; cv=none; b=h0ShouAexDJBvULbbIq+L9nlDJea6df63m259ISqiiEh0D05BLfDJomBCo3PGwqpDOnZHB P1J6hcJWbF9oNFTIJvk7xc05UHWSzHD5lMtKbH35Ni+8vuAY5zTwLKe1Apy51SkyLZuvBS G13VZWhfPHbgBm56aZFN2+H2YYHg5L4= Received: by verein.lst.de (Postfix, from userid 2407) id 7BA7A67373; Wed, 18 Jan 2023 17:42:08 +0100 (CET) Date: Wed, 18 Jan 2023 17:42:08 +0100 From: Christoph Hellwig To: Ryusuke Konishi Cc: Christoph Hellwig , Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 9/9] mm: return an ERR_PTR from __filemap_get_folio Message-ID: <20230118164208.GA7584@lst.de> References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 315208000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gd3kpqkzj4e8ojb8fm7s6t4bw5anmpms X-HE-Tag: 1674060132-923319 X-HE-Meta: U2FsdGVkX19VGcmPWkdkzg6bYCj6V22UlcDF+0atjGhua8adN/jAgj2VxKTZuGnSSJjC1DV5p/A19FffUnoTv6Ggl0PZO/07yAtSxZJBAFrVO7IqRDjelrl4V7XkjnHafRJgj6wrkol5YXxj2XUCKdMB3dmZ2Ch7oSy5XibBcSa14ZaoxMrWUjNwJXMp4ifVKBTCt2HB+qZSLQY3zohhw3u8++s5VJgjVAp0n+5gxVUxPwIUe70A3ZLNLMqrpJam6T/J7CIfB+gu8rWn96a+YE7r1P3SJ4diH86PsaN2u+dY7klpl+BDZX+wyF3E2ehADQ4Bwe7xSvhoW4nnzexsiZMlkQuCbs+PvbsbCjS0cHns+OzqzHheqc8u5xUOXSvjCbU5HMlhP3w/Pgpcon5xS1WeBanA+zljLEQCURSqI3xdBK1MxB2KU18LbKBWgUZmB7bREBCPlHT+VgRIa4ACTuNXNMXCqUtkTGMJxJXkl6U84XLPBz9G12WieK8JhhNZq1IOclHsKLd0XoE5EF8hn+HfxQPxmA+WjgR8er9Ho2iIQgdU2gxw/B0yXfZQqd/5VktkHWPPwtBFIxiodHxiS5m+7VQwkzJuEy/LsPm9gHQVn4ePsKQFIiscaX2FgGK8VcGxvsUYWaLAzctaRiqkHDPqWoiv/3I4QK6EMQ6ku4lq04S7XfgYk9G/QWMLiNGiwzzWZ0eguaDZwRPHeVd2QOb+tJzNmOZXZRdaTW63sGTZzwURwl7icVbBZRYXe7L4HLGbSsHrhFtyiFu+fuZleKbwAiNfV61qYGQ9xAVhHgPrmdYRfSAO8/kvuyhVvg68883X5nQcxRbIDRJqlvwTYrKhwXN4JnF+LK0kjhilz3QJQ+unPVunSLD7L3Zr1c9UGFy0tiJ1A8w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 09:39:08PM +0900, Ryusuke Konishi wrote: > > Also pass through the error through the direct callers: > > > filemap_get_folio, filemap_lock_folio filemap_grab_folio > > and filemap_get_incore_folio. > > As for the comments describing the return values of these callers, > isn't it necessary to rewrite the value from NULL in case of errors ? Yes, thanks for catching this.