From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E139C54EBE for ; Wed, 18 Jan 2023 16:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7CF6B0073; Wed, 18 Jan 2023 11:42:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D67856B0074; Wed, 18 Jan 2023 11:42:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C30316B0075; Wed, 18 Jan 2023 11:42:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B1EDC6B0073 for ; Wed, 18 Jan 2023 11:42:39 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85D4F1203B0 for ; Wed, 18 Jan 2023 16:42:39 +0000 (UTC) X-FDA: 80368488438.21.6BEF39C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP id EE11510000F for ; Wed, 18 Jan 2023 16:42:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674060158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1RWaMgExx6Sevf+OPnH4ZTjbdCF9nCvVAtozvfTeZc=; b=MH2LNh/8LPUOP516WAWfKUJDW9mj0IsgZYkQl0T6pPxzsYQtoOC7y0AcW1n8n1XfkQX+Kb xoGxj/teUmL69cxY4XPdU1cgyI/ITnAoOKGvvhxX4BYIDUk6Z1UwGa8Rg91ZBEDBvdeh7+ z0mbT0SzLwVaxtV0ojjqdRNAHcrYPbc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674060158; a=rsa-sha256; cv=none; b=ty5HDsHt2ANYK4aV6nVk93tWpdk7dwZIRxJfry62HObuyYngNHaYxHAse7TcwW8H01ZEOX epdPvwA+XvishjAL5DhYYq2iTsUu7NQRt9ixGi3+ZdY6kDFZnA/WjXpKejzamfI2D15+Mf Vg1onrYZ55bWZn0M64i1/W5SCyA70R8= Received: by verein.lst.de (Postfix, from userid 2407) id AB09068AFE; Wed, 18 Jan 2023 17:42:34 +0100 (CET) Date: Wed, 18 Jan 2023 17:42:34 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Matthew Wilcox , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org, Hugh Dickins , cluster-devel@redhat.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org Subject: Re: [Cluster-devel] [PATCH 7/9] gfs2: handle a NULL folio in gfs2_jhead_process_page Message-ID: <20230118164234.GB7584@lst.de> References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EE11510000F X-Rspam-User: X-Stat-Signature: 5tm5717pwmpk6z69e6ckkqnikrkjw1xc X-HE-Tag: 1674060157-635858 X-HE-Meta: U2FsdGVkX1+PMUtlTKzt2Bg4ag0WOFvyVVqnHRDt4yC97Ziwe3vqNWehB3jOw+cjX0RB2iXL5Hpvq+LQdqh+G03GMmuM7DIyrkNTLoCeH+qEZ4mTgJEmgvTqxFi30iYwiJp6dopMoegGFzMEhyCWARZhtKPNKt8RQzx6BpJYXcBDwt0ncV1GoD8/1YpiABSrFXjUbQOzJcmy277s8fczt02dGeSQ2jJcmps1SaFtgg6ORH9pEJKLiW4RdvXWk4WKfDDs4EB0LcFkSoRaBKNr4A6Oig8Abunswex2fZ4m8ukSi1v/+ss1w0YbmWcj3qcUzS2YPR5uluAm0eI0bB4nRwLs1/0tp/zD+P1boRGjsB6sJrsiiKGiri+GGSujx7cs5yCaWtP5O8J6YmDUyZnSMbE5MjPARcvUplrp1ylrNl6KQjkz/cUyKqT9BHSZXNCQ5XQ1QsteTsIDej4N+1KESVc7wghY17UmZCxWyl+zpIxlJ8MDGFGFtZtjeMbGeGgUYFX8p325JtTDFbD7XTZi0BVQFadVp6y3Vw4ONZTcVdd8h+GPZdZPLiVLlSHKg473qNrpFfTPE4QbW2cJ0K7YhSHg9FLcCRI6vHFx8sjbQtFxvn2HT2QyPMOCRiAcZJ9kFGIF/SyNvEIj7kq6mef6Wq3xv745OgLY51W2G4QsTZOlUKAEbyVdIhmkvisPrsiYmfpyxz+rqYYuiZKKm1Xf+QNqT5uffejJPmk2nDA2zI+weQAE+Z6cob9P03Q3QyrED+d8Q3ZQHrHV/eMEslXM+yXp0ltCPu5lsfMhIk1M8x9oLM+Shq2kYWvGT6lY1+wO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 05:24:32PM +0100, Andreas Gruenbacher wrote: > We're actually still holding a reference to the folio from the > find_or_create_page() in gfs2_find_jhead() here, so we know that > memory pressure can't push the page out and filemap_get_folio() won't > return NULL. Ok, I'll drop this patch.