From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0158C32793 for ; Wed, 18 Jan 2023 16:42:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BAAE6B0072; Wed, 18 Jan 2023 11:42:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26B106B0075; Wed, 18 Jan 2023 11:42:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15A216B0078; Wed, 18 Jan 2023 11:42:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 05F2F6B0072 for ; Wed, 18 Jan 2023 11:42:53 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CD7B41A02B1 for ; Wed, 18 Jan 2023 16:42:52 +0000 (UTC) X-FDA: 80368488984.30.987D035 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id 32E2980012 for ; Wed, 18 Jan 2023 16:42:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674060171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FsdtOAivn7H/W1rHOHf4orscZrNspuC1yh//ShcpMIY=; b=16CIRcurpIPqOFKGSe0sPruhrxvwHlWVXymJL8/FA041xJRcPXKx+sowB8EyAe3G1jFaxG qD/087HyKW1vV8e5ncK1SeP2C5HHmQ6HyM6JPGsBV6JKRwsW9bA6dr8hUB8CXvkIAXc6Qi lYjir62dIREOMoCMQD/0HQqNqZ/oYJ4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674060171; a=rsa-sha256; cv=none; b=VptUphEUHtmlXGNF0b3TYezURVrfebz3w7n1HPIrue1Frv+Hriqi9kB4CeHVVAnMaBdh3V W6I1yZS7JNuyp9OuukdQu1mbAUV3IotXl15gOpjquggUbursNhbOOeIsMPX/R5UNVGIY0Q tRoOp/P481XkDyN42iXkWlmsAIixY6Q= Received: by verein.lst.de (Postfix, from userid 2407) id 4E41468D13; Wed, 18 Jan 2023 17:42:48 +0100 (CET) Date: Wed, 18 Jan 2023 17:42:47 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io Message-ID: <20230118164247.GC7584@lst.de> References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 32E2980012 X-Rspam-User: X-Stat-Signature: jt6aeiu94t5qm38ihk8p6owkhdaq6jyf X-HE-Tag: 1674060170-729487 X-HE-Meta: U2FsdGVkX18+p6/N6E/6JZaH3BgubpskoOmA4Eu8/FVEDCaUKQloH0179jTPiZ6siXI1gzJAjJaGyESG26C2GRYtVTZwd4DPcj2dMFsBb4PZfA0fNECDIUSmA1H0bAe5JBnWm9ldPKgZbNf4D4cIWJBO8x+aeqC44Nm4cD8sc73PM3kTwiCmcDJtitvO02s0EOqEWiYGCPBIwk7wK+R3iE33OOK8s6XQ2jlLZiHK2WzVWZuOWaKFMcIYTvEAFrD/Ok6soaWPXIKq7u3fec6Isepwv0VRN9i/MY/yz4aUp0wBFtESTDjC1xtp8RCeVqfusUg5sdYSC07vXUUKkqkada4Q+R7O4jK+hv6xHbX3FOr1b6yPK3a4KHqUUSubH8IrC4LZpyZhOH5PYmAREptf2gijGZTb1J2qvBvjouBSI53rjm051MNWDZkF36ieB8HBybHckSl3JUsoCXJCBKT5qlaKWbXtYNIPJC7d6QrXKQuZTjR0hKIGQxTfD2qeJTonVIpTgTN4N4XtyHEgvCn8mv6RbqkXaOL7MxsAS+vLfV3I8Ptpmm9W6Uj+vvONiNTCQF2DtP+wvrG/qkFlP1IkHRzBcurzBA5Jl57RCglZuMHrfVToLVYbBxsIt1EBcyS/owsg74k427eS9DnU4DpxcSo87kyBnT3L5n1LNN+KVxwQH4+QpNZFP76gtKYp80piYVrWVQ6zblpSUTMF/IOWXkfN2FF18HMgfRSFyt9uxEc3bUybZ5jut6/Vf6fYiryAiFG+IAUVZGUxasYzEsz2HLNVyj2Rjr6VELI0V3P7x1ae6jSVa/1zjhEvdyRcIBis X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 04:08:57PM +0000, Matthew Wilcox wrote: > On Wed, Jan 18, 2023 at 10:43:28AM +0100, Christoph Hellwig wrote: > > filemap_get_folio can return NULL, skip those cases. > > Hmm, I'm not sure that's true. We have one place that calls > extent_range_redirty_for_io(), and it previously calls > extent_range_clear_dirty_for_io() which has an explicit > > BUG_ON(!page); /* Pages should be in the extent_io_tree */ > > so I'm going to say this one can't happen either. I haven't delved far > enough into btrfs to figure out why it can't happen. I'll drop this patch for now.