From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C69C54EAA for ; Fri, 20 Jan 2023 09:57:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FF5B6B0072; Fri, 20 Jan 2023 04:57:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AF176B0073; Fri, 20 Jan 2023 04:57:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677306B0074; Fri, 20 Jan 2023 04:57:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 581E06B0072 for ; Fri, 20 Jan 2023 04:57:56 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2935940E32 for ; Fri, 20 Jan 2023 09:57:56 +0000 (UTC) X-FDA: 80374726152.26.932529B Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 522C140017 for ; Fri, 20 Jan 2023 09:57:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q7bKtcsn; spf=pass (imf12.hostedemail.com: domain of error27@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674208674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=4DBEBeRvdSKbe+o+qYl+b8CSc6/SIHPSVX9tdSemlLY=; b=W4CX+qqV/Fiv0CFlL0XmjzkViQEATnPt02sTUJoqQMiRLqDvXnwOIwvpLpvp9uP+zaZArZ y6oUXsOgdMM/se5G651GBNNJSb/ARClH2f7TtmVYWcNSccrj+WOQ5Y0cpLSzQZZNm/jfTe NsbK/fjA8RxH7MZYc0+Ha03d6CMuBwc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q7bKtcsn; spf=pass (imf12.hostedemail.com: domain of error27@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674208674; a=rsa-sha256; cv=none; b=VHLG+E6TX2+SEuC1GPUaczGXx9sUNOgosooi/ccDUTaZwXxIqLLqGkadvgVDIJ6PGCs/SQ IqAXsc9HOuBxWUlMwkk3heiMuzbmCHi71ZcuaCKzVt0KwtaXI/cqEZTvdLsTDMA2xP/TdY iLXzfCHgs2gIN5fUImISIS+dSHZpK30= Received: by mail-wr1-f49.google.com with SMTP id d2so4331154wrp.8 for ; Fri, 20 Jan 2023 01:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4DBEBeRvdSKbe+o+qYl+b8CSc6/SIHPSVX9tdSemlLY=; b=Q7bKtcsnSZTD1fDv5/N4gbyNDP7pQOgjX7TKGq7oj28sB0Ukni5IXNwGj69pYoz1mO fX2ymC1sR5HkWwlik1Om40Jjrgh5AiU/aXBAt/Hj7XV/hpNNFyAUcF0GtcZivOS/oQ3i vhXRwSp46neqgiolQmSASTb7wiQ1CQ3c/1e/zLmZT5t+bMf0A5gUk49tbSoa9Y5MnhTl j6/mzREsQmvnmlyS7drCy4qHu4TOw5BUMSKhBc8So/gQBTCzh/EYWl2PoeB71nnVmFeu 0DGjCEv2INSJz1RIT/EZqDFG8QaQr/TaC/QB+WOjEW8Z0P1oPRwbeUuOLPO57Vj6vGob BPUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4DBEBeRvdSKbe+o+qYl+b8CSc6/SIHPSVX9tdSemlLY=; b=Ex9aEWY7+vgDOJlbWDQytsPj5ptDM7wbY3j5C2NV22WAFTggKYsBXkw2Lmg2qaD4eE oQSZDqQhpWTtlyhGTMk07wAav4HhX9K0KPnfb9MtYBwjFIjqFKuRB348iRKE2VYfgedJ gYLLUdx6XvZAqRBFe+omd7N3MGfOTZ1rohJ/wYjndGjiBe5xczJFsubZ5ET4iq2WNZ5l VpmjXy0mBpeYu2Ukl5ph2icj6oIEMSg+p31Ctq20d8A/GLuDlyj/ejkZn1ROHURJP/EY 2gmRx+t7KNzh+pcWOk99m4FdQspfrx8RY2c2vDERLabMld9aYsKIuFaUbOYoqgD8uOZa yCkQ== X-Gm-Message-State: AFqh2kqAGYh11MLs7FlfgTBiNqfCg9pEY+CEzcGNjIyY8x9QsgeqRDo3 GdDMc08ajvP+bbINkIPcbVI= X-Google-Smtp-Source: AMrXdXvoJYiDwaQcIESfi+0EhMHMrpWpwgzHvibXtLrikSgPgxdrXOye1AIzJs9e7UrUhlpqgq3xOA== X-Received: by 2002:a5d:4cc6:0:b0:269:65c0:79fd with SMTP id c6-20020a5d4cc6000000b0026965c079fdmr11380546wrt.53.1674208672786; Fri, 20 Jan 2023 01:57:52 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id w5-20020adfcd05000000b002bdc914a139sm26986440wrm.108.2023.01.20.01.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 01:57:52 -0800 (PST) Date: Fri, 20 Jan 2023 12:57:44 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Ranjani Sridharan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Mark Brown , Peter Ujfalusi , Rander Wang , AngeloGioacchino Del Regno Subject: [linux-next:master 5407/6912] sound/soc/sof/sof-audio.c:329 sof_prepare_widgets_in_path() error: we previously assumed 'swidget' could be null (see line 306) Message-ID: <202301201736.O3WvrMfz-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 522C140017 X-Stat-Signature: k98sa8t6e6z8obp4a1fuy8g4c48c3h33 X-Rspam-User: X-HE-Tag: 1674208674-205744 X-HE-Meta: U2FsdGVkX18Xz+CHsUsyRuWxIan0xiPLzwLzrU94kdlcHF0a6DkvU9dWIChk0qnGEsBZHIwexoss0fuhOFgtLyWrfOyfHI+UnuoNmphW1333mmIYCfQozqFH77EXv6lk5mofwjlT37GXaRp3PwE6z1l8tdMFUwLO+EvoUDvK8Dc+phTpU4mxav8DyhRTWnVHxunJiabVy4LEuhNpZSc5ElWKXtz4EISA6Adzu+VDsSPzMtuv1vgsNgJOMwHo7klJnWTS7PUVJdhfw/MSiuTu+Z3GSVa9wX7/3Yr79YYJpMN2iSHx3ESBE1mS/3Tv2OwFfG5u9Mh5REfqo7VmWkz5FCN8pW2hqtDr5BjE/nwKHUjD0in+Si5T8ic+/nBxI9tVwzA0OSrxw6tNktNPDBLKEf5VqbeQ/b6yBf5zxdgkZxbHlNr96KKQ7sLCchf+MKVM9ACQnYcko5BDnM81kE42gYSnZMVpxsj1bzaMOQ8BfpaKgAJwG5F/vIk5T4Atw7WbP2mA8J7iyUI9yqpvpYEvmESYkKKXLNPDJdY4Yew6sdZ/Womu1a6tZX+xHU7j6LNif5tMTROaFI+FpdgEi/5oG8Df+iAiNoueOYO1jL2Qpp1SOj7cohV31HhEges2DC9ghMUzqlZE8ZHVfN5i0MlZBKQ6JKaE5O2/fHiczsUiE1hVJ4JmqNDz2Hm+csz10e+OpvIn+5pXI3qHGOoL/04Rwl6yODNmnNiitb802RJDCLhzFGWsQJ0NE108ConW2Bh8VVVwI3oAwKQEIxJpEsmTw2Y+yr3C2jAppV0ezkFuYo0O/5Q4ik69IZp5RiZHunJi3zmmJ+kASQDwETCKyKEKTsHmb8N4S7m9Gb1s3rEmKq1QuXpp1Xlra85b63D3J5q16NjI5phMxTDtNYEToGbkSIFAlAkPfjdVozoA3LunAMdOAnD5OKSp+DMziydlkX2Ukb7KggOXm4twqEVHwXy f1NN6tqz 4yjjSPbLiKYngFJ4/6oI7yM7oqADaKT6BpELVN2mUdXbuYDK3OhyyCCC24lzondrMT6BHQhlxlSuAw5kDlT+bN+THSpbayqt+kGgosXpuz9ai2bBbytWlvYE2CwqUn6LjLCnkH4TrCMpLcUyeJynVAyYi0DhyVNubzoZTMAx2TnH77jaJI2NFCVN3XBr+rVe74ZfMJI3mh4FHRzl6BsW2IgRFCk6mI0q7v3z1/Mro+VW211CRkO88xm2ibLpfjDCmuuXHH9julXTmm3/EanIWWbZxOAwr9M0cq33S8op9rYqJG//CFh/XI2aJ2pbpxQIlCiLA1NkMmpIkaFTagqrOyT51nQaKQTd3QHcy6ovdkRFim+l3br3WMeTpzR4ceqCWTiEt2TU6aTjQnR5aoZnLYMBlmmaeirIVWixbzL9FrvsG2pvqvqlJxKHC49RGBi3CJMrxgDKVPdaX7hq3aIXYTQQmZOUBSl2QvaVguaK0n3J3FsjopDVlZ3x4hf8Z7DrLsVIxeTUpPJVWCld5xkQeVVwKHn2OzBnNsSytYBIvb1hq8FXUA/DB8YqnNT8y1KMAwemZPHrevYGrg23KdPFYTLfocJIIYQNikVPE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: d514392f17fd4d386cfadde7f849d97db4ca1fb0 commit: 0ad84b11f2f8dd19d62d0b2ffd95ece897e6c3dc [5407/6912] ASoC: SOF: sof-audio: skip prepare/unprepare if swidget is NULL config: csky-randconfig-m041-20230119 (https://download.01.org/0day-ci/archive/20230120/202301201736.O3WvrMfz-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: sound/soc/sof/sof-audio.c:329 sof_prepare_widgets_in_path() error: we previously assumed 'swidget' could be null (see line 306) vim +/swidget +329 sound/soc/sof/sof-audio.c 66344c6d92113e Ranjani Sridharan 2022-04-26 294 static int 66344c6d92113e Ranjani Sridharan 2022-04-26 295 sof_prepare_widgets_in_path(struct snd_sof_dev *sdev, struct snd_soc_dapm_widget *widget, 66344c6d92113e Ranjani Sridharan 2022-04-26 296 struct snd_pcm_hw_params *fe_params, 66344c6d92113e Ranjani Sridharan 2022-04-26 297 struct snd_sof_platform_stream_params *platform_params, 66344c6d92113e Ranjani Sridharan 2022-04-26 298 struct snd_pcm_hw_params *pipeline_params, int dir) 66344c6d92113e Ranjani Sridharan 2022-04-26 299 { 66344c6d92113e Ranjani Sridharan 2022-04-26 300 const struct sof_ipc_tplg_ops *ipc_tplg_ops = sdev->ipc->ops->tplg; 66344c6d92113e Ranjani Sridharan 2022-04-26 301 const struct sof_ipc_tplg_widget_ops *widget_ops = ipc_tplg_ops->widget; 66344c6d92113e Ranjani Sridharan 2022-04-26 302 struct snd_sof_widget *swidget = widget->dobj.private; 66344c6d92113e Ranjani Sridharan 2022-04-26 303 struct snd_soc_dapm_path *p; 66344c6d92113e Ranjani Sridharan 2022-04-26 304 int ret; 66344c6d92113e Ranjani Sridharan 2022-04-26 305 0ad84b11f2f8dd Ranjani Sridharan 2023-01-18 @306 if (!swidget || !widget_ops[widget->id].ipc_prepare || swidget->prepared) ^^^^^^^ Check for NULL 66344c6d92113e Ranjani Sridharan 2022-04-26 307 goto sink_prepare; 66344c6d92113e Ranjani Sridharan 2022-04-26 308 66344c6d92113e Ranjani Sridharan 2022-04-26 309 /* prepare the source widget */ 66344c6d92113e Ranjani Sridharan 2022-04-26 310 ret = widget_ops[widget->id].ipc_prepare(swidget, fe_params, platform_params, 66344c6d92113e Ranjani Sridharan 2022-04-26 311 pipeline_params, dir); 66344c6d92113e Ranjani Sridharan 2022-04-26 312 if (ret < 0) { 66344c6d92113e Ranjani Sridharan 2022-04-26 313 dev_err(sdev->dev, "failed to prepare widget %s\n", widget->name); 66344c6d92113e Ranjani Sridharan 2022-04-26 314 return ret; 66344c6d92113e Ranjani Sridharan 2022-04-26 315 } 66344c6d92113e Ranjani Sridharan 2022-04-26 316 66344c6d92113e Ranjani Sridharan 2022-04-26 317 swidget->prepared = true; 66344c6d92113e Ranjani Sridharan 2022-04-26 318 66344c6d92113e Ranjani Sridharan 2022-04-26 319 sink_prepare: 66344c6d92113e Ranjani Sridharan 2022-04-26 320 /* prepare all widgets in the sink paths */ 66344c6d92113e Ranjani Sridharan 2022-04-26 321 snd_soc_dapm_widget_for_each_sink_path(widget, p) { 66344c6d92113e Ranjani Sridharan 2022-04-26 322 if (!p->walking && p->sink->dobj.private) { 66344c6d92113e Ranjani Sridharan 2022-04-26 323 p->walking = true; 66344c6d92113e Ranjani Sridharan 2022-04-26 324 ret = sof_prepare_widgets_in_path(sdev, p->sink, fe_params, 66344c6d92113e Ranjani Sridharan 2022-04-26 325 platform_params, pipeline_params, dir); 66344c6d92113e Ranjani Sridharan 2022-04-26 326 p->walking = false; 66344c6d92113e Ranjani Sridharan 2022-04-26 327 if (ret < 0) { 66344c6d92113e Ranjani Sridharan 2022-04-26 328 /* unprepare the source widget */ 2fe08216fda33b Amadeusz Sławiński 2022-06-02 @329 if (widget_ops[widget->id].ipc_unprepare && swidget->prepared) { ^^^^^^^^^^^^^^^^^ Unchecked dereference 66344c6d92113e Ranjani Sridharan 2022-04-26 330 widget_ops[widget->id].ipc_unprepare(swidget); 66344c6d92113e Ranjani Sridharan 2022-04-26 331 swidget->prepared = false; 66344c6d92113e Ranjani Sridharan 2022-04-26 332 } 66344c6d92113e Ranjani Sridharan 2022-04-26 333 return ret; 66344c6d92113e Ranjani Sridharan 2022-04-26 334 } 66344c6d92113e Ranjani Sridharan 2022-04-26 335 } 66344c6d92113e Ranjani Sridharan 2022-04-26 336 } 66344c6d92113e Ranjani Sridharan 2022-04-26 337 66344c6d92113e Ranjani Sridharan 2022-04-26 338 return 0; 66344c6d92113e Ranjani Sridharan 2022-04-26 339 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests