From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFA3C38142 for ; Mon, 23 Jan 2023 14:43:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BF1F6B0072; Mon, 23 Jan 2023 09:43:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F436B0073; Mon, 23 Jan 2023 09:43:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 111746B0074; Mon, 23 Jan 2023 09:43:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 01FB86B0072 for ; Mon, 23 Jan 2023 09:43:08 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9E5CA120A53 for ; Mon, 23 Jan 2023 14:43:08 +0000 (UTC) X-FDA: 80386331256.29.D0E5D16 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP id 8DE13100009 for ; Mon, 23 Jan 2023 14:43:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674484987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwo5GffP8KsynnMNpf79tUE5ko/tH2KBo6xdBDgEFig=; b=KB/ScjfcD/pjzB/ndxJdRvZ/r0AX1DHq6xK6jc8QL6enQ3ZSG22xwXJwmz9i1o5dwbkccB WapNhNRvTNTDOQ7r2r3T4r4B4djRQcpY0wf+dquILtX3jA1HpS8L0WOcsBCUfAhyfxxQiS 06Kq78ToZPwerSAR15ujE3rDgqgaHUU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674484987; a=rsa-sha256; cv=none; b=1NEIKeJgMY8ZXYWD6p/7xostn5EA79Zd3Uu8dbwGoU0UTxV+3FOYf4DrGm9zceoprXbj5I vOM1xuN0QbxwpsmNn0U1tGO4TZqjaihkMFFOu4YVWG9Hh5jrS0z9Z/grvzrUDunHD3EcJ2 HYQhrR1RvVICWLDv+lo2pgbHQ4uz5RQ= Received: by verein.lst.de (Postfix, from userid 2407) id 99D8C68C7B; Mon, 23 Jan 2023 15:43:01 +0100 (CET) Date: Mon, 23 Jan 2023 15:43:01 +0100 From: Christoph Hellwig To: David Hildenbrand Cc: Christoph Hellwig , Andrew Morton , Uladzislau Rezki , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH 05/10] mm: call vfree instead of __vunmap from delayed_vfree_work Message-ID: <20230123144301.GA31126@lst.de> References: <20230121071051.1143058-1-hch@lst.de> <20230121071051.1143058-6-hch@lst.de> <96cd68be-674f-8def-b82c-a0e17256ed05@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96cd68be-674f-8def-b82c-a0e17256ed05@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 8DE13100009 X-Stat-Signature: w9dj4w7htnx1joh5jb11ycx3oorurssg X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674484986-837445 X-HE-Meta: U2FsdGVkX19uwp6Nsf4zG4idAY4otMCqGPXOnjcrOESe5yS0S7LIly71E5gGHW7BzwzSNLcKW5bnAnMLnKzKK23P1MEvoXreDydzoNKkRBgr+/sBPVBxqLzymXfuCSi7X09/88eSKRNFrsGoobHsucRTi9pYG/vbUnGTfu8EqWEZC6b/n/IrbmUreMxpvCzfaCQZVTWGZhUKwO/8D1ssNNhchjnuWeUjzs0kOyK+oPD3JsBtw/ZuT7yVF8OrZ+XTAsgA6qniuzIicD8tctRqhTzSQ+73Pw+7loo/HeS3UqTslWBzpWW6DD2nogad3aEex091vNr+zHcuI0OgA49JH8ka4JgVbDkkKgQMSqTWu86Y+J6ppXx5TWqSuNHcOTC5+RRlEsMSPTulM2meunL7PvIUqltQgaqbXZSuZHc2vaT0S7qHnX73Fr2nM79G2N3XPNV668offh3xMQLKzpmrUV7CYBVq3bqt5FASxEKXUVDLK4V7D1UzE8aoTHhmBRtdGhCfjPm3H2+14S3OtHTxl5YvDMzlEwlRkQwyqMAkyPv7H4ws5qJiByv/+6kwMT/34GhqEXi83HZPVRXfk/4N5xEd+IydA+zOmZ63jhKXTxNFqpSHzTHsyGw9OIDMwwckCND1JCQvujAvRfkVgZInn4gYYC2lj/ExEm5j9cneRkvYpzHfs6PtQbp835DC/MmyQ6dQnnfR7P8Kr6oAV1+xvqcVmnTluRjn5vnncemJ6uSY7DPRT/cydT5Abv79y4EPSU4ZCK7JgZ3aMta4TpIS5PBY7Hq/ItTSWUbmPniU3w3xURnotDOsTdd+je8r3663n970eewB4hKWa9009qcrNlO+ued5mZ8+4MF4k7ygunz+Gp0M3usHYb+Os6CDHxIfmQXA2gelh/DgaZcM45+LfSb93N9voh8A67Xa2yrkh7TbsE6b44UaXQxg1kyhpYDZo6RB+VvKj3YqAHTwTON ErqXurH+ J9IhCSsuet/+b1BTUfRsIdBihLK15Vz4TESEiUl1s9xPFZwCtpdRxx72xwzGoiWqB1BSKkNRiWnU1LNUtHVi1+AhnecjtfDMaz+IXcieC2lXxOqg3I5+H8ZYROPdV3B2vcL+WSQUO9+lhXZrh2DDM1cNKyTGkS4ezfxh5DML0rKpbma/esUAYCzNJjzEqgLPSNC7y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 23, 2023 at 11:38:46AM +0100, David Hildenbrand wrote: > On 21.01.23 08:10, Christoph Hellwig wrote: >> This adds an extra, never taken, in_interrupt() branch, but will allow >> to cut down the maze of vfree helpers. >> >> Reviewed-by: Christoph Hellwig > > Self-review? :) I assume that was supposed to be a Signed-off-by ... Yes, this should be a singoff: Signed-off-by: Christoph Hellwig