From: Christoph Hellwig <hch@lst.de>
To: David Hildenbrand <david@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area
Date: Mon, 23 Jan 2023 15:50:16 +0100 [thread overview]
Message-ID: <20230123145016.GA31543@lst.de> (raw)
In-Reply-To: <02bc3d67-3457-ff17-0810-e75555609873@redhat.com>
On Mon, Jan 23, 2023 at 11:43:31AM +0100, David Hildenbrand wrote:
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index 97156eab6fe581..5b432508319a4f 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -2588,11 +2588,20 @@ struct vm_struct *remove_vm_area(const void *addr)
>> might_sleep();
>> + if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n",
>> + addr))
>> + return NULL;
>
> While at it, might want to use WARN_ONCE() instead.
One thing at a time. But yes, this makes sense and could be an
incremental patch.
next prev parent reply other threads:[~2023-01-23 14:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 7:10 cleanup vfree and vunmap Christoph Hellwig
2023-01-21 7:10 ` [PATCH 01/10] mm: reject vmap with VM_FLUSH_RESET_PERMS Christoph Hellwig
2023-01-23 10:34 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 02/10] mm: remove __vfree Christoph Hellwig
2023-01-23 10:35 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 03/10] mm: remove __vfree_deferred Christoph Hellwig
2023-01-23 10:37 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 04/10] mm: move vmalloc_init and free_work down in vmalloc.c Christoph Hellwig
2023-01-23 10:37 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 05/10] mm: call vfree instead of __vunmap from delayed_vfree_work Christoph Hellwig
2023-01-23 10:38 ` David Hildenbrand
2023-01-23 14:43 ` Christoph Hellwig
2023-01-21 7:10 ` [PATCH 06/10] mm: move __remove_vm_area out of va_remove_mappings Christoph Hellwig
2023-01-23 10:40 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 07/10] mm: use remove_vm_area in __vunmap Christoph Hellwig
2023-01-23 10:42 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area Christoph Hellwig
2023-01-23 10:43 ` David Hildenbrand
2023-01-23 14:50 ` Christoph Hellwig [this message]
2023-01-23 14:52 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 09/10] mm: split __vunmap Christoph Hellwig
2023-01-23 10:47 ` David Hildenbrand
2023-01-21 7:10 ` [PATCH 10/10] mm: refactor va_remove_mappings Christoph Hellwig
2023-01-23 10:52 ` David Hildenbrand
2023-01-22 1:20 ` cleanup vfree and vunmap Andrew Morton
2023-01-22 7:20 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-01-19 10:02 Christoph Hellwig
2023-01-19 10:02 ` [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area Christoph Hellwig
2023-01-19 18:49 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123145016.GA31543@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=david@redhat.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=urezki@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).