From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C545BC05027 for ; Mon, 23 Jan 2023 14:50:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48F566B0073; Mon, 23 Jan 2023 09:50:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4174A6B0074; Mon, 23 Jan 2023 09:50:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B89D6B0075; Mon, 23 Jan 2023 09:50:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 175E16B0073 for ; Mon, 23 Jan 2023 09:50:24 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E407F120A43 for ; Mon, 23 Jan 2023 14:50:23 +0000 (UTC) X-FDA: 80386349526.17.8A8D8D2 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id 33B3740014 for ; Mon, 23 Jan 2023 14:50:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674485422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5DZKS4NnWojlLCM5gl6FbhPLtm469wVljSa2U7EFRyg=; b=Ds8hP6XVrhfEeKehXBqDRD+6eyDdK8D5EO3eW3jx3lMVJAaNm+GKoLAB9kLExDBg+ZlAcw xZh5qb5mExoDY4Pa2I9sfJHK2m+XdoaPoHAqq7IimIv+Afk32wPzNPj5wRf1VvGIt25+Ft TDVXp8kupxI8cKrmEvMY8LaYHe9QmR4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674485422; a=rsa-sha256; cv=none; b=gBwUgswQyp2VXnstAiXJ8AyWWfRszrv7z7/S+gta7be0c3GpWQ6Qia8VO2L/Ur9hj2V+jq Zu3YsuXtVEcbTc53Y+9MB+6r/R9x2pSo3dtTLr6x068jX2ck/f1AKyaN93MSj4N70CPduM SRpopOuahl2XXbq98bcAFrQKIJJf9nQ= Received: by verein.lst.de (Postfix, from userid 2407) id 35D0268CFE; Mon, 23 Jan 2023 15:50:17 +0100 (CET) Date: Mon, 23 Jan 2023 15:50:16 +0100 From: Christoph Hellwig To: David Hildenbrand Cc: Christoph Hellwig , Andrew Morton , Uladzislau Rezki , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area Message-ID: <20230123145016.GA31543@lst.de> References: <20230121071051.1143058-1-hch@lst.de> <20230121071051.1143058-9-hch@lst.de> <02bc3d67-3457-ff17-0810-e75555609873@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02bc3d67-3457-ff17-0810-e75555609873@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 33B3740014 X-Stat-Signature: ig7ygwew74f97zwp68cc58o8xq5f3rnx X-HE-Tag: 1674485421-161977 X-HE-Meta: U2FsdGVkX1/1FEZ1nZMD682a8xKWkX+d2rwnln54Ni2JAJt+wCXlX61OOQAoQgdQCXL+K9q4Ph3GEZ7O+gGpoyCeAwWqkdaDqd7mSxzDLYnulLAjIE9nskFdAv5b2EoMXAhOqhZ4N2DNc/s/bJR1vBKiBW8w8eyCIGRfeTowXNfRL4/clHObi1+0jlo5WQS7G23W3P1YINK7ZGm44+xKiykbKSsnvYjwlAIykVcC3oJGdnmI6eOZDDRsT3UMBdgwU6Ll0TjO342DqtG3z+2k9DrzG//A70pkV3RY0zv91AFMedt8VVcVZyqV/1nwyPnTxpw+LQDJjWbk3UZ6aYIbExq+Djki+LFXUE9utnHzr66sDjr6olwwCv3aPy7nY19T1Sr8YqAqDvazbLpoRABUwu06sgdsJmG3JS+Igg+hww0Dd/+zRWQpub1TNeCE3uqjXzWM2dPCYpRD+rAJOhWfJ9YLvf+kE5zwH5zxp9pihzjHflNYDG/1ERoLlK1AY6nJGEEXzEOHn5aFkIjUD7hg+o10C8kZXMkUacemxgCCxUXqGAPGnKwptnCA38KXKxPDatnhl3FwMRnnFz+vjwLOWL5coDr05gf3I847ChvZePo7md3/mkgEUihA+x/PC33MBfZc0EFnmQj5xJ/ebNLBFWHM6rzhwE9OH8rlL/aCZwztklwNCGYdM51veZfx7iYQg4mFw2/ovCX9YuNLrrEyZCEkbZTyZ2MERwRTw2s8EOV0tS74J2nGG6+JrGwNPCfmGhE64hS59fLCp2kcoDS338kbudJ/EuQaf0xs00ys/A0Yyp2m2xK+VCSXX4aqeq0+cDQYrVdOA5njCsV2sRGtEWevtozSgMQ3BaNimZitVNYYbgPV65j16fmjNUsOKo30MuYnybA8uPfste6e3b+2FbKGNfPSuqREz2LHWrUnItn6lt+qvnQqn6hYyzc/jshV6qCUGkQGBwvbFe7AUgh ZDkxARI1 la/gkJQjcc0Z+xa2ytGVlpi29Xh28KJ2cIULL+ter1LfsOb+wyY84w+Sg0J4ZxTwqo1spoXCrZdrzB0uQNp8aamUP2uvA7BMQ9XW43HG++aFDlTgokDGa5dwEolKpQX3+QZI8jlYG/VzOXmrNoCCrlDKd2QXPHsMEGwmDmSIACDLn1lCPGvaq4W2TKLrIxGyceKje X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 23, 2023 at 11:43:31AM +0100, David Hildenbrand wrote: >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index 97156eab6fe581..5b432508319a4f 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2588,11 +2588,20 @@ struct vm_struct *remove_vm_area(const void *addr) >> might_sleep(); >> + if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n", >> + addr)) >> + return NULL; > > While at it, might want to use WARN_ONCE() instead. One thing at a time. But yes, this makes sense and could be an incremental patch.