From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BD9C25B4E for ; Tue, 24 Jan 2023 05:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47F876B0072; Tue, 24 Jan 2023 00:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42FE26B0083; Tue, 24 Jan 2023 00:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F73C6B0085; Tue, 24 Jan 2023 00:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1FA456B0072 for ; Tue, 24 Jan 2023 00:55:20 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EF425C01C5 for ; Tue, 24 Jan 2023 05:55:19 +0000 (UTC) X-FDA: 80388629958.19.9457CA8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 7151D4000C for ; Tue, 24 Jan 2023 05:55:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h1vl50Bc; spf=pass (imf12.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674539718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9+nMn4Y7ib+ksp4an8hs+mxpzKixV/6cqrHGLxmxmZs=; b=CjpQrdpMeIeDVtus5j1QtN4uYFLixArwWAthN/PZrH90UEN8l90kmuZEp7HGJP2Yec3QKF GVRS6C+cq2+Nr1LDUxgKOE6GUfKroToFRoIdWu4DUqZ9H9da5DcJTcuvZsM5Jr3bZ4LGWA vmlntmHABSoWaQaAvBSDmncJ1GN9FOI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h1vl50Bc; spf=pass (imf12.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674539718; a=rsa-sha256; cv=none; b=j2pAQ/pSemMeK6Pa7pyoh9rRAp8z69sRa626UA3LsphGuKkccNeeIfT3czVZdbRqXcRANH 3jK6Hiz2V5NSVLiQAPvwEF9ZgEcwFueEQ71dKJEq6mK95EswYLFuLd/hjueG8RIxIRfRjL HTjHa8uLM1pkRrx4EiqSHzqXltGpxuI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674539716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9+nMn4Y7ib+ksp4an8hs+mxpzKixV/6cqrHGLxmxmZs=; b=h1vl50Bcg/y7qUcrh4KpKzfxl1Bpx3aNimHScedk8BFeahynqXQY5Cs0+pm/0pD2NGQUC6 jGWWjC2ir1XWfu8+Mb3QAWT774gqDp5wfK+IU6UmMsOiLb4OebgScwWMHvvOyB9T+dTmZm Obn2SDmcAuonEWPJ9KAmgHHReButQlg= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-390-HLMXpF_xM2GfrtYhudCNoA-1; Tue, 24 Jan 2023 00:55:15 -0500 X-MC-Unique: HLMXpF_xM2GfrtYhudCNoA-1 Received: by mail-vk1-f200.google.com with SMTP id w6-20020a1f9406000000b00388997b8d31so5790174vkd.3 for ; Mon, 23 Jan 2023 21:55:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9+nMn4Y7ib+ksp4an8hs+mxpzKixV/6cqrHGLxmxmZs=; b=oFUZug9dvp3MToWEhTZZ4pXXyfzoplSIM4ykIlRakgYMcyxwQqZZ/ESl+IVx11kHEw Bch+jHedPDBVNBwM1h0w9Qn7d3Bxj3uqLMTJrvlBQ5gf5j9fTta/Mu1W0h5vSOcZ40Zt WotT9T1CVXGyMW188ewtMwK5y9qMgHR9RQ2P+BspivHwLwhKO4Yjqk0wfyq40eHCQGQn 637UAJLO41oow3ruUHR+zC61IVdN7XQLrwQFgCsbtYfq9EI4UtnjXx5zYYsypnMXfmhe M21EdVViceMR9qKgm/wsPMx06Iag4ipwQ1umQjTyHQ6P1zoBjWvs3j+d1mn5ZiWEliQI sKeg== X-Gm-Message-State: AFqh2kp7b8zlR6YyQqaUPJ9s84o5+C4ZDvXYfs6s4w5jqYrc5bt0yCqN pfuTIIC5Dv6LZIyXeoOpLtb6Qyzj6qFzRA/yK3KTCyDzq8aR2Q3cnIsUfzltUBFtVVtjlBE/sDp NIHY8pM4Iewg= X-Received: by 2002:a05:6102:1517:b0:3d3:c855:bf54 with SMTP id f23-20020a056102151700b003d3c855bf54mr16402952vsv.34.1674539714848; Mon, 23 Jan 2023 21:55:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXtIO8aXO9i+HLzZc6kLGRsWHVrO9s72UFSgMG1EytTFL2SpZojIc12K4cwqrrKZT6og3irEcA== X-Received: by 2002:a05:6102:1517:b0:3d3:c855:bf54 with SMTP id f23-20020a056102151700b003d3c855bf54mr16402943vsv.34.1674539714642; Mon, 23 Jan 2023 21:55:14 -0800 (PST) Received: from redhat.com ([45.144.113.7]) by smtp.gmail.com with ESMTPSA id r15-20020ab04a4f000000b006180bedf1b8sm83195uae.26.2023.01.23.21.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 21:55:14 -0800 (PST) Date: Tue, 24 Jan 2023 00:55:06 -0500 From: "Michael S. Tsirkin" To: Alistair Popple Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, jgg@nvidia.com, jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch, Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH 02/19] drivers/vhost: Convert to use vm_account Message-ID: <20230124005356-mutt-send-email-mst@kernel.org> References: <97a17a6ab7e59be4287a2a94d43bb787300476b4.1674538665.git-series.apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: <97a17a6ab7e59be4287a2a94d43bb787300476b4.1674538665.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7151D4000C X-Rspam-User: X-Stat-Signature: bebtohea1obkzocxaugw86kz13doj58w X-HE-Tag: 1674539717-516956 X-HE-Meta: U2FsdGVkX1/YB1aO2w+mrDo/WvIU55xHFSrk1ci+ODu6F1LWImLs/59gH8KT8hXy8hkYvo/wxNKJ2HSADxUm222MY5Eo+IoT+TVQzDrBTgocXngYjlW+p1Zxbvc7HASOD17XDRgXOQn+I/Ao1d4+DFYIaa1LrPDwhRKzLvNS6GpQU4QXMsfjlKTC3qg6+APXb0SH0fSxZh/UbYLXXg7eQni50SHahSQ4uHiPgs/XMEnPLM86mdMLerZyEfxd/NpoKu9YLLLb8xbmKWBmYHaY24qAgi6/YbRDse5rijz13J+olVoT49DnIn+E2UARleJDkeWr5qN4sJEY7MYDy3byWBIcunnizcg2ldLO88X6AxPOrDNnH11DbGI1R3ZhihXfuLLFp0+At4D6AnoHplZrrnVmN/OJ6EZF3xJp+CwN+ckTZnvABkzM1qniqyC2CAOd69SuCHQ2GEmO7QQ0GU6QX9OjZmwe8NXFr7QImoeEx7cUzAd3cLNJ1aq5dIL88ZADqTu+Acd6pqyUNJTB/EeIx3hjYQv59FzTFZNF89BLi20GmoXsEiMp/iAqPPDKL36ucIvqXeAdSTFIJj5J6GA1H8VoZCC0isS7Ns1sPqBgEoFQ93HRllAJ3gOW5rFZGLlUZcIUdgbbec+h/DoB+XAaS5Y++6Oab83qnkXl7QukVdo2PM9M7L9t1S6cviGSzSrmu0Su7DGD07LFaxJ+dKt/yJG95jTQvUl0h97BDwDWvLR0TCeEj0y+yo4qkvIo/CoKe7Upbhi35DKs6aFYTb/UZEhK4vxvHQXSMd6ZL7yFoQTK83kb2xt14BqKzgDw5DEkxAad635q8HG7i11QhJHGSon2Gg5JiMizJx8zsWsxz1X78337EC49BDUdE1xMEMru5TLDu9MbE2Uvf7IJAd7IFyWxCxG6O+q4jpH7AdkyiPvgP1+lWTgqOr4VRdSl+iYrmaYPfNVPuFcvFvzWwlk OLfD2MGN juFQJ01wlFfIiEmJlv1ief2bCtyD5cGC3pZxqyGDmG4u4sEl1Td+/SPVzf8ZKEYlI5gKxCvHMUvbtt2rjgjsZScZ9ZIO2+4tyMXjYoMtOpBe2b5Ug1cO9C4n6j3iwbkS69NeQBtXl2HURXceVeLFeHokksxXZIsDgXUPrQU6CJ60UstV3hvkf4xiMhJpiKafCXDW7E7SJPM73xwxH9sCCnZiaLd12yOOYdfR9550KPs4oIEfMbY9dqudYxtP+3qo/3Y+ia+MaLs2X9bzJ6uVv/4kiwMVTTZobWxPdx36+4+HULwB5SMdEbf9WLuwB26Rlsb8PwLnQu1kG3R9zCbW53vIg8ByIuLqrokV/4FycxyapOSXnhNKv1kQgb6bjoRQnUSJrx954LGFwBtI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 04:42:31PM +1100, Alistair Popple wrote: > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index ec32f78..a31dd53 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c ... > @@ -780,6 +780,10 @@ static int vhost_vdpa_map(struct vhost_vdpa *v, struct vhost_iotlb *iotlb, > u32 asid = iotlb_to_asid(iotlb); > int r = 0; > > + if (!vdpa->use_va) > + if (vm_account_pinned(&dev->vm_account, PFN_DOWN(size))) > + return -ENOMEM; > + > r = vhost_iotlb_add_range_ctx(iotlb, iova, iova + size - 1, > pa, perm, opaque); > if (r) I suspect some error handling will have to be reworked then, no? > -- > git-series 0.9.1