From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB5AC27C76 for ; Wed, 25 Jan 2023 21:02:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A2D86B0071; Wed, 25 Jan 2023 16:02:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64F2A6B0073; Wed, 25 Jan 2023 16:02:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 517116B0074; Wed, 25 Jan 2023 16:02:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 420E16B0071 for ; Wed, 25 Jan 2023 16:02:20 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EA4141C5E96 for ; Wed, 25 Jan 2023 21:02:19 +0000 (UTC) X-FDA: 80394544398.10.3C5DBE4 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf27.hostedemail.com (Postfix) with ESMTP id 0A5AB4001D for ; Wed, 25 Jan 2023 21:02:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of robherring2@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674680538; a=rsa-sha256; cv=none; b=yhriLers3oe+lMAVfXCWRdeshBIJAwNvwGxQAPmEQdNf3lHJND3VGTe78hD34sLmOYFflY P7hZ3T5XtpzW0pkFLziFQurxF7E383nflk3KlEDTDWv70UZR/LGI9vUjYiH25XzkqMqifT T+2iiY1a+ahoEJYPSWwtq2uTlPTHRW8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of robherring2@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674680538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qy9hdSdytx4WlUpLP7AkbgycuXVsEcln1aautfJdWs8=; b=3xGjmvXQM2E8FdlWhbo3lnnehGwlc6nnUMAkEZM09cQDtePDQic94B+54koheMvrCY7zVK F4E/tnbxEslAx7SAuzAOuxXd9n0+2L4/qVb8Q9LZR2O1X/yqoGLSTqJqw4U8poO8/bUknf gyJ6pPMxRDpy9VYR33XEWsjcvvzgGl0= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-15ff0a1f735so109433fac.5 for ; Wed, 25 Jan 2023 13:02:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qy9hdSdytx4WlUpLP7AkbgycuXVsEcln1aautfJdWs8=; b=KS67pgpRRSwBnkK6ZLboT3YHCyDLXlY4fWgO16AvWXPHLbnbYNdgTCKD9ssvVxwv8O Ru/Bl0xLGl0pzTXv+x6kV5uWHYDtBbuWrZ2gYLeIty30r0MfuvgiU1wME8Q2RmGqeACc n+fO7kWf7RvZ3Xt1amPcMKGNhvMrpGj3ZvtdlcKjXBBjaNWzU6pltXXXgEx0a6oC6wMm 9TQ/87Lgdw5FNIdCtbs+tAixsKMApK9VfZ0Za2M/RYcdCjcgULM1Bi6rnccoHUy8K3A6 KA/BfwTgdACpnuH7YSG+Ikbt/tAcnUhh5pxWVRoZElXTSqDgw5QXEGxg2C2HTGJxbfs5 N53A== X-Gm-Message-State: AFqh2koqbq3QvrfvpJ7wBBupDxp82Dq84nhpd5km6U2sXMTOzP8kUytD 5iAcfGV6HSFbJpAndvKvBg== X-Google-Smtp-Source: AK7set982YuB9zviVDeEJ8iQft1DYsVnb0qtXC/RPUZ4pZC3ngkO0EG1QPjG0FKrtdt1kl6Lz/QPxg== X-Received: by 2002:a05:6870:4722:b0:163:18f6:e5a8 with SMTP id b34-20020a056870472200b0016318f6e5a8mr4192613oaq.42.1674680537120; Wed, 25 Jan 2023 13:02:17 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m24-20020a056870059800b001446a45bb49sm2355759oap.23.2023.01.25.13.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 13:02:16 -0800 (PST) Received: (nullmailer pid 2890158 invoked by uid 1000); Wed, 25 Jan 2023 21:02:15 -0000 Date: Wed, 25 Jan 2023 15:02:15 -0600 From: Rob Herring To: "Isaac J. Manjarres" Cc: Catalin Marinas , Andrew Morton , Frank Rowand , linux-mm@kvack.org, Saravana Kannan , stable@vge.kernel.org, Calvin Zhang , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved region with direct map" Message-ID: <20230125210215.GA2879887-robh@kernel.org> References: <20230124230254.295589-1-isaacmanjarres@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230124230254.295589-1-isaacmanjarres@google.com> X-Rspam-User: X-Rspamd-Queue-Id: 0A5AB4001D X-Rspamd-Server: rspam01 X-Stat-Signature: xrqh39tpfoypd78znqw41auw4fh4jbpo X-HE-Tag: 1674680537-691001 X-HE-Meta: U2FsdGVkX1/giIaunkIyUfzKeBqqTvKlNx8sxKuzOY1LXYKAHh9MA0PVcCoMTzEmbYjRGa56A/yi1y8CGZaCUYffpzsn4SuyKBaUEMZzKrMS1XckQioF06Va0O6PUzyxeECh3wbCt0auLcKhJ7wEj7jAoG4pw36Mf30TQ3qHJjse9olddGX/OoDBol14J1995quXsWO/fLeSsMY2yITQ7jrYSxl3pcG7OpL6Nwa0s9mkbp/h73HsC+XuBhAAVqV0klQLaSlX1sCpB9kY6nfGl+j4d7qNu2S9kVtYBsjZ5ZFI88Z9I6NPzkKBLl06sGgJ/54y2BvlY5mP52fCE095qSHWQ+4cItlPiSFz/KA2f32yBdYFblNYsobCg7tQgDDzdIqYIGktMTn59MqXIr3fCuGD7hmJVhY5bEScE1SHSaKKA1cGJ5h4gYXQzkWTUTLZambtCaBKmx9RmYjVErAuXlhzaiTQZoiRhyEXCsfwHb4igpTFTxfrsXe84GsX6KoBWPhUOSGy3Z5yZYcnmwlAPbenDh33IC0IGK8xTYHukhPEX5obR5NqOpUH9bzapdseEA1i88/rQQN5kHajvZ2Gf6Huao8BiauvdgJpomkgKNZXQA//9uOkWIbp4jslvMcETdTuWQUm7slb/x+o4C3Ki4pMjrtV+BseB/5u83a8JfAX1lBu2Vz2N506oD/3/ZmViYzwf/GWS9h3V9nYyGiVh+fPOwUfyAiSkDvuV/OoJZxeA1JRr5/4btIEPDU8byNgH6GUAQoMadz6BeStteSBbQFSlX5/6mdH0OAwSEE/Hs7GqtX1b7NnY9z5J52bjft6eqfH+I7Duq2OqBd+w63/C3IhhPVmdjkrKtdQaf1S42c41WFhabE2qXbRpBwfNJ7sv5wKxb828FgY+6vGfdSOqWUwyl7lhmQkaATMTymDcTY9lwVxV2f3bzjpHXErJlo6HEj0/+BpMiHlGiVuU3/ ojMfKlmc Rr6T531uUOEgybtT8BRe8vXmdOhZCEzm88bbqn9rJIYsAIf5o5VlGQiD6USi+fb5/uGTpGyTyTnPMqo6h2sJwshqJiN0StnwKYrE5p1OG5q0le4edjybfcr04/6RA52c9dzD+Cu7ErDUxVZ+xmWSG5NIyUUOd/ZbkwvddLLk8THCDxYUPDdC55PFGzqB3b/N45BcM+UBFIRxKrocGffGt/ioBa8cYFhRDU98PFIu8EqpZTMlZMkZhgB/CjNRj/So0oQVFUg0rPes7Q5A077sBcVg+BdUm/+eu5e6WToObgo72U4pOvURDzYKKwLiFszX3vG7gw6oJamnbBpWn/ArXcKRYod0maXk9x9/m6dHAXZc1RQ27tT92QvJi4WFXElH0nnDnb4/1UAFponmasSl5CtpN6GilWzX9/IiwcfLhCcQqGDWZggiMZ4262T1oMLNoHSnqPvx0Viq/tzqUnAP4osGFSVewt+GPt5hE7vk/AoU3P92YpBNoBqlsdrY5m/DLSNz8Qd2pvFjaVgzJWOxLYNJnH07k3wINk2wpc6zgNF6v5fQy4u6DCmOMqE8yUnKu0PKqCvVA3/tTM5MC7U/GI7g8xcGsHWji4FE5j8NLmpPbjQtW+gZc7M/2jugETvZmHc4KYinW9z9dE62oq/gQpIAhcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000783, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 03:02:54PM -0800, Isaac J. Manjarres wrote: > This reverts commit 972fa3a7c17c9d60212e32ecc0205dc585b1e769. > > Kmemleak operates by periodically scanning memory regions for pointers > to allocated memory blocks to determine if they are leaked or not. > However, reserved memory regions can be used for DMA transactions > between a device and a CPU, and thus, wouldn't contain pointers to > allocated memory blocks, making them inappropriate for kmemleak to > scan. Thus, revert this commit. Both commits talk about the same type of memory as CMA is used for DMA. Neither commit tells me what are the implications of kmemleak scanning or not scanning the region? Are there false positives? > Cc: stable@vger.kernel.org # 5.17+ > Cc: Calvin Zhang > Signed-off-by: Isaac J. Manjarres > --- > drivers/of/fdt.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-)