From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06341C54E94 for ; Wed, 25 Jan 2023 13:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8617B6B0071; Wed, 25 Jan 2023 08:39:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 811E86B0072; Wed, 25 Jan 2023 08:39:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D9296B0075; Wed, 25 Jan 2023 08:39:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F3106B0071 for ; Wed, 25 Jan 2023 08:39:37 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39D65A01CB for ; Wed, 25 Jan 2023 13:39:37 +0000 (UTC) X-FDA: 80393428794.28.677A2AE Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf03.hostedemail.com (Postfix) with ESMTP id EC3E320014 for ; Wed, 25 Jan 2023 13:39:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=daGawnKQ; spf=pass (imf03.hostedemail.com: domain of lkp@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674653974; a=rsa-sha256; cv=none; b=SYd4T4jvxoS24gPkIuFCHU459bCTXSamH5uz5PmsGw8n2BKzK07N/jI4o0fa4hlP99vdzN Sd2eVJsZ3xKyiOqbuQ5CdNPvD2D1g+ggits2QazwMwdM6D13xcxFhp+8olwF0tkjpUIr9P daVwtp2A+3bdJHKBmrCRDm3bkXXHnkY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=daGawnKQ; spf=pass (imf03.hostedemail.com: domain of lkp@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674653974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2J+k/+AYWfNxa7yoa1+q6k0bG2DrSRTBzqZ1OnH+LHw=; b=bwjBECA7mk4cXPxnItkpg7iTiOuHeVcuCHksKvKixieJXymJ5487mp2ZoqKa1l0LlB80fb cC1y7Cvt6WdtGwhJjH6LEiQHwH16bin93OGY8s85QKTfvaNolvbLUPzIt3l9zY+nQAof5y +FIGXEvgGH+px0o0NnMan/9rw2AHb6A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674653974; x=1706189974; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uVNuIPRm9QPwcd4oqZ9GXJlGxWAucFgmjYS9xfDWMt4=; b=daGawnKQKkK9WIBSLxhVgjzlYAnYeuYEtQMsYuSIzod4wEu8F3aiZFFp 0JN7fQjfXVBnoDywikBJlVXti/1ID+VHcTFytC5eTYx8gReJbgfk+bwFL chaiTf5h8oLmuSg3NwaCYvB05oVkPaXLSzAqc9uqJouJOoxF5RBTJN/1p SvfKVnFg2Nj99N+1on62Qjws5LYig73FXeS1GFCPmTnL5ceO87Pt/4a1a PoJEfhSHMwkYl9MwaS51xsPSgElsA17OV7xOfmumjLegUGl2tPK7Tjl7y 4DJhhyw7WgnFrjan5rKSy8sPTodfRHU/BvCFEwFZesZme2u5dqkQIyZzA A==; X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="314457761" X-IronPort-AV: E=Sophos;i="5.97,245,1669104000"; d="scan'208";a="314457761" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 05:39:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="639937713" X-IronPort-AV: E=Sophos;i="5.97,245,1669104000"; d="scan'208";a="639937713" Received: from lkp-server01.sh.intel.com (HELO 5646d64e7320) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 25 Jan 2023 05:39:29 -0800 Received: from kbuild by 5646d64e7320 with local (Exim 4.96) (envelope-from ) id 1pKfzs-0007Km-1U; Wed, 25 Jan 2023 13:39:28 +0000 Date: Wed, 25 Jan 2023 21:38:20 +0800 From: kernel test robot To: Zach O'Keefe , linux-mm@kvack.org Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Hugh Dickins , Yang Shi , Zach O'Keefe , stable@vger.kernel.org Subject: Re: [PATCH 2/2] mm/MADV_COLLAPSE: catch !none !huge !bad pmd lookups Message-ID: <202301252110.hFYRsbrm-lkp@intel.com> References: <20230125015738.912924-2-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125015738.912924-2-zokeefe@google.com> X-Rspam-User: X-Rspamd-Queue-Id: EC3E320014 X-Rspamd-Server: rspam01 X-Stat-Signature: eh86c4kbyqesw7yydm11tz1ozjojja96 X-HE-Tag: 1674653973-887908 X-HE-Meta: U2FsdGVkX1+naU16vS+CTAs363miR6nxFjACq9XK7lAqK5wMqjgrPsZxGgTxjpKtd95Lmo99YvpdhQQQZGS7cP1L49GNPozw+vvVShwBAOoyNhU+lMQ9HMgL8Tnv4X5a4iBxuWTL5s4CrP280JJrxOWv8aTLfdJOFc/USfPhevhQC25CkLDY8acmFbWjEtRHLbZTeIyewTUS3ukX1ViDN0Wdmy0eKIXw04DZfksXuGsrUbNBj6j+XFIYfbS5thm2dQoniZVf4ODRno9pM0P+c1bJJuUF5NolwZs8BAoKePimFf0ozQA/mDiO8J38BvquWxC5OW7jUUzIxAhAnVVgY6ltDPFGy0rx56WlF8M6MwvssCAPKb52mTQlzXMMlpeHfwSIF/A1Fk7zDA1+vEmEprh+YzXNcH5vndvAA7/c0lrYxCXzSfkzZpaT4ziEo9a5pN5u+RFTP7F2hjGNvY+CPbA8LCtYLWVI37XNzD6LFwlcoUGcCoFg2OX3SRCro4ZItedWT45NFHCOX883Kb9KO3oOvXdQYTUk0zu+gFmfFwm0odbvkVogWPVp6UN/gJV/AY66Y4fJ0j8YwsPCAvTom2htbsPdO1DQWWuTrYxKdg0FEE2VRhCUUCHNFAoc/Y9UxfcFDr2yauJF6YEUMWANFoGQ7K+0JBpiv2Q7euPXnO84qUBTRVP0oa1FYylxTfT5lfmCX+j20XUkct44PUvckooMGbc4Gsoo2DBeh0sFF0qvM6uNRUnydLGE+enUtBw4ukGWt3fAoraccL0eotlxZeuSRW9XW9TJzTfH3qvbJZ6MGZOz7RIgOrSKonS2E5siXQyGT45X7jap9F1w1CfJDFAKpLTtiKRsDDvhQA8ssYJGieY9Hm3Ptcu6swNPOYfcLW+0jrPlVnF5QMSwIt8zZxESpQX5HlYu8rOJUhnAXA4IrO1/n0fTlcGDrwO9jSCKZ9AEWK65iRc+CzNHMcy yXN12+Fn m+hXNS21gDGXpafJwJcYHqBZTP0lTksvR5hzgIMqYc/T4EMOkC6dzVdGTsC9O3xrf9wTUVqLIMgsR780B54ShYMn2JPqsSxjGeOZu9RNNNHLBxoweVAPYyLX2DVQNzT9j9u9QQYrGBkD7PObHXooicku6xMvDQqc6MTjaemMYrNIek/QKpV0yPBQ6fRyljWELIovnjYiltFS8vJ5v6tkR+W9Lhr2JZpgrhmGniLWLvxhjbgpast6u5Z+dC/fhLMN9xb2nD5o+vxE1yuW84SSp3QvaIK73jvGYycm2MtLA9l0vs9jBnYkY1IEhnyvOkTrSYJrcPK0rMFxmKwbDrGsFSP3yXn+bKRhwARG7fGPOzB5aUmCfWY3wW+Lgnj3i2Y1GwF01ZUd3Qv0wHAE0930W/FQR5bVULpt+7JolNi0r/+e8aMRfR49gyTGaPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-MADV_COLLAPSE-catch-none-huge-bad-pmd-lookups/20230125-095954 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230125015738.912924-2-zokeefe%40google.com patch subject: [PATCH 2/2] mm/MADV_COLLAPSE: catch !none !huge !bad pmd lookups config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20230125/202301252110.hFYRsbrm-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/6001eb9a8f1687a1d0b72831d991886106cac37b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-MADV_COLLAPSE-catch-none-huge-bad-pmd-lookups/20230125-095954 git checkout 6001eb9a8f1687a1d0b72831d991886106cac37b # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/khugepaged.c: In function 'find_pmd_or_thp_or_none': >> mm/khugepaged.c:972:24: error: incompatible type for argument 1 of 'pmd_devmap' 972 | if (pmd_devmap(pmd)) | ^~~ | | | pmd_t ** In file included from include/linux/pgtable.h:6, from include/linux/mm.h:29, from mm/khugepaged.c:4: arch/x86/include/asm/pgtable.h:254:36: note: expected 'pmd_t' but argument is of type 'pmd_t **' 254 | static inline int pmd_devmap(pmd_t pmd) | ~~~~~~^~~ vim +/pmd_devmap +972 mm/khugepaged.c 945 946 /* 947 * See pmd_trans_unstable() for how the result may change out from 948 * underneath us, even if we hold mmap_lock in read. 949 */ 950 static int find_pmd_or_thp_or_none(struct mm_struct *mm, 951 unsigned long address, 952 pmd_t **pmd) 953 { 954 pmd_t pmde; 955 956 *pmd = mm_find_pmd(mm, address); 957 if (!*pmd) 958 return SCAN_PMD_NULL; 959 960 pmde = pmdp_get_lockless(*pmd); 961 962 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 963 /* See comments in pmd_none_or_trans_huge_or_clear_bad() */ 964 barrier(); 965 #endif 966 if (pmd_none(pmde)) 967 return SCAN_PMD_NONE; 968 if (!pmd_present(pmde)) 969 return SCAN_PMD_NULL; 970 if (pmd_trans_huge(pmde)) 971 return SCAN_PMD_MAPPED; > 972 if (pmd_devmap(pmd)) 973 return SCAN_PMD_NULL; 974 if (pmd_bad(pmde)) 975 return SCAN_PMD_NULL; 976 return SCAN_SUCCEED; 977 } 978 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests