From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8933CC27C76 for ; Sat, 28 Jan 2023 11:33:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C434B6B0072; Sat, 28 Jan 2023 06:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3536B0073; Sat, 28 Jan 2023 06:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE24F6B0074; Sat, 28 Jan 2023 06:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9DE946B0072 for ; Sat, 28 Jan 2023 06:33:51 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 685BF120350 for ; Sat, 28 Jan 2023 11:33:51 +0000 (UTC) X-FDA: 80403998262.23.4701949 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf22.hostedemail.com (Postfix) with ESMTP id 93229C0004 for ; Sat, 28 Jan 2023 11:33:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="nSIjx/E5"; spf=pass (imf22.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674905628; a=rsa-sha256; cv=none; b=zOz8Xge3VL24Mo4CBLNElXb6u81YqiASarmS0aoJ3TuIxqa8zBAlQ+uSzpk4h1uImnglhg kWhEk/7jGzoYVflx78otHoOMZRFaq2mE1S/EFaXFE459tmdhB0497CdV3wGexIZMuA94rt zFUQyLlOsQtZlDf1gnc3H/oLPPRgvZ8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="nSIjx/E5"; spf=pass (imf22.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674905628; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=0+vbyXEO5ZjGT+93R/0smtSFLyUkyWND86MvhSizTJE=; b=nJuhmkFibIb+m60TyFAMwEcFSdocCRe8/36lPMdA5TlNZ1nfBTTVA/YL7cDLXu8DSs96vJ l6PsPq0e/uDTSkwW3r/aeiyZFJYdVSczwDAz2hiTvWm5inMDr5lO8WFZoKYpqnrn6ZHaQX lQnaL+AL+f5bLi0Og7HWPBBnA1Ob6cM= Received: by mail-pl1-f169.google.com with SMTP id b5so101147plz.5 for ; Sat, 28 Jan 2023 03:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:reply-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=0+vbyXEO5ZjGT+93R/0smtSFLyUkyWND86MvhSizTJE=; b=nSIjx/E5hZc7SLk8D4Jz/YgjkJJ7uwde0+7TDidW748INJ5hMQ9eWt34STpe6jbwCe wHjk8Sl9+HIyY4bIRYkdGTJlACSA8t02WmGwuEQ3J4l+SnRbRKB6hFHPebSz6mUXtuBY 678AWnKtBNbkPKL/BPsLOdFW3hLIPfbzTCPZrvy4OQMsW4NzfSaRUBhqtNLdhjBybsvh DUte4QoDxdlld6NTQN2GnR1Qwt6MffTvnCUwm+P44uBjNASyrnFFz4CQoqM8For4VPHs WknIoyAJ++lnTUCRnLlxlBK9SQSvVKcwUY3vmD37hUPHk/zZbUteUVNQz/bH/MmBVV0Q Pk8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:reply-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0+vbyXEO5ZjGT+93R/0smtSFLyUkyWND86MvhSizTJE=; b=0prJ3lmCtkpNux0mli6QxPGAytmVOqlj3g5JxpLU4T8PItn9HEg+d0Whx2zATTC111 /d9X4aLjAtaJcmO8ga1/9H5mx/FOJO7Fs9DBUCW67ZbXMNcpnTJxEna32R41U9FHiVje k+H27wM1Ea5KS3i7KkExOvHyWmONo51ZwqfbQiW+5NyYzpVGjJOUeYpwDD1Wu8mXoxux 8GaxoqvtAzSoR5OkCavCsbqSlNh3I6EW/ufm4MJzmAx4nkxXh+R8c+hkclN3ZusG3eKv r/SJxILZBglpXXcyz4RvH4ekqB3wDYtoDasH21sfPH1aflvIkxuZPRd/kobd9Hpb2kQN OKfw== X-Gm-Message-State: AFqh2krFmlIUkVMbJtvoQy/O7vrsMdYAV+VsZQqYejO1IS0LlIOeSolh +JCSppkhF5o6XIxA4YNHX54= X-Google-Smtp-Source: AMrXdXust+O1bkLT1e54NDlo7jlLm8yw9QPmOTn14gd8+7KsCWht7KxIDy2ajF87971shDASiQgW7w== X-Received: by 2002:a17:902:cccb:b0:192:b927:39d1 with SMTP id z11-20020a170902cccb00b00192b92739d1mr45094625ple.3.1674905627356; Sat, 28 Jan 2023 03:33:47 -0800 (PST) Received: from min-iamroot ([210.91.70.133]) by smtp.gmail.com with ESMTPSA id j22-20020a170902759600b00194a297cb8esm4345544pll.191.2023.01.28.03.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Jan 2023 03:33:47 -0800 (PST) Date: Sat, 28 Jan 2023 20:33:42 +0900 From: Hyunmin Lee To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Uladzislau Rezki , Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gwan-gyeong Mun , Jeungwoo Yoo , Sangyun Kim Subject: [PATCHv2] mm/vmalloc: replace BUG_ON to WARN_ON Message-ID: <20230128113342.GA1164537@min-iamroot> Reply-To: Y9PntwfqtarxWFUq@hyeyoo.kvack.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 93229C0004 X-Rspamd-Server: rspam01 X-Stat-Signature: fgqao3sq8utdk3r3xf3wouua6d4oeb49 X-HE-Tag: 1674905628-905863 X-HE-Meta: U2FsdGVkX1+tJP+mYfPeuwgHR9Ppb4TYhNkJmZcE5CmG+MRkM3LkTneDvjXAnaM3u9M0COGEFgQw9dtTLPAmV4XGn9Ea6zZ8f2Y7GnnJJp2IK0GD6/mcvef0usfhkz/GWzy/+w1QO2l0g2+93XlNIJ+XeaXECmSlNfGtRlMZ7KpTA3YhDk1G/VYP73ZZPTd63/NnRfGbh61sr2XzL/E1hfqo8KlM4vkfnw4ZCDc9PXzyBl2kZo6cBmimHl4Aht3CUNcT7tRLbdNTy5piP8po2Ri4MCQ2p0bNrl99C8W9VOhOez/rVMCjaHxrbEzMTfriQOX+007R6hiokJgs8Lo8WFX0eamQ09gUUMkhI1PR1XWf023dSKlaWaO8a6KRpY3DVu5IZf8vnHWnHgGFXqkyqBZ++5Eu4dynL2hVLT63IP8IIUmOMaqm/8TAfO2UaDxntBxOSeBlppGWENpeQBwglLOqVrTom9ELo937cBMEYnwmNwOX4fzN+1CJnK2JFQVa3n/HM9D5eKTs07Qx3m5w43JFw+p3PG1hbcsSKWBGJHr9b+3pxlsYR62kLhlnlmPITuGhmzYkHnQTprxRjC1AWjbKMVJcLMQk0CBpl/Hws8iQy+mFSYvQvArZLD5ViC0d8y/46Rw94O+IzzPfSaTsIQU7zi3HubpW7xMXaLqYEgL20WSaxs2lsoCX6kgwqbN/GZEQd0XPk0cjTiZAiEklNVOCAdp6cjCiWtedN+mn+8cNmMoZGeyj9TZ9pGMPUph75sPe0I4cBJLVYtfc1bpDg5asKvVtD7lSubB8qUJ1mbCUylB7K5Fr7A/8HVcwwbYbldCv8ySUF+qRaPauxUjqVnIPgLeU/SkMahO8OfI7qmKQ6bULZnmZwuvnxcpHtK0tay+SOSWMFjuDvjj3dT2tRxKaARn/rkmRd8cNPW1/McVZt35rwRASVDe5LVIgASoXNu4emHqrThyXpWbwriR 1SZUuJgF 1PxAsDB7TnDomrFxjEJy4eqqy30CQzcHRASQqEA86WT/4PblUIQo7HNAPrt+aaRuuPIFuXWYOS5QQ1reEQIXpFxFmuD7a9GmzmS+4VAk6gXtd8Q0vvNhzUwqj+eXvRFXhfiS/SsGO3yx472u3x7N0MX2tVunv8yXB9qn11w8RSWobJLCVqy0Fxq5g8+eWyllIAqfsQsUCjFHZaGXYV5AhPJCcr6fyAG+JxNHHjub1iCjes25SualZkvtDY4+0kDxNGa39xCbLSnTm09bReLkj6lAz4EnH6FSMe1BIlUpF99+sd88QYV3aXkBnFRbbW5Ws2j7BTupS+MjadCKh+a9uEaKOwYwmb7xZ2Os6s2wQk1/7QMnl+ZkUxsXP0yF+U+lRp0PBbot3iQW0lXmohrm0qCg/jrCwZggidHaqrv4caKL/1sknm2WuZyhZqWc9JiCRHNxPl82rGHTTEMMlf4cYW4Y8HhCtHHVUI0sV7aSCY6kTG9LIPbx6O5HNkWRT4GhHwF3JIT47WDJOMcN6FUSZVIhefmcQq+qtZynFq9c25pEHpFxPD1azcZymsXXowr6h1mQsz9vEtVPlzOSe3v7Pionws8iDeHn56DK5Oo8njqAgGsxtGHINFTOiS31TMHhwIou9S9u+dURuMfe1WUU+nYQJeSa1rguQlszsNq2Eizdt3tYfsM31NOeqvYSkbQqX3ByYovoRKFQlEWz4wZiobrhjzZjzqX8cBvRzjE3I3iBtR5kBqFwBUh2Y0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As per the coding standards, in the event of an abnormal condition that should not occur under normal circumstances, the kernel should attempt recovery and proceed with execution, rather than halting the machine. Specifically, in the alloc_vmap_area() function, use WARN_ON() and fail the request instead of using BUG_ON() to halt the machine. Co-Developed-by: Gwan-gyeong Mun Co-Developed-by: Jeungwoo Yoo Co-Developed-by: Sangyun Kim Signed-off-by: Hyunmin Lee Signed-off-by: Gwan-gyeong Mun Signed-off-by: Jeungwoo Yoo Signed-off-by: Sangyun Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/vmalloc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 74afa2208558..9f9dba3132c5 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1587,9 +1587,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, int purged = 0; int ret; - BUG_ON(!size); - BUG_ON(offset_in_page(size)); - BUG_ON(!is_power_of_2(align)); + if (WARN_ON(!size)) + return ERR_PTR(-EINVAL); + + if (WARN_ON(offset_in_page(size))) + return ERR_PTR(-EINVAL); + + if (WARN_ON(!is_power_of_2(align))) + return ERR_PTR(-EINVAL); if (unlikely(!vmap_initialized)) return ERR_PTR(-EBUSY); -- 2.25.1