From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3EAC38142 for ; Sat, 28 Jan 2023 18:55:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97CAC6B0072; Sat, 28 Jan 2023 13:55:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 905AE6B0073; Sat, 28 Jan 2023 13:55:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CDB86B0074; Sat, 28 Jan 2023 13:55:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6A2A46B0072 for ; Sat, 28 Jan 2023 13:55:01 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31799AAC5D for ; Sat, 28 Jan 2023 18:55:01 +0000 (UTC) X-FDA: 80405110002.23.91E7B9C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 4D05C10000A for ; Sat, 28 Jan 2023 18:54:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C5Se+sjU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674932099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y9dnnXSs2EHDOIGXQVAy1pwbGZDVO7Xp3YSBTFgkaDw=; b=UXU0QRdkik3ypaw4Lf1k5h0IR3/fg/lsT/Z1J6wUP533EYxV0hd7D/qClpV3OiYvWhlLER 8LxHLK8JdbdC+W0mzcbQ1TwZqpaoiMPxGcvxH+/3nKl2UxbOAuPj8GwBt5yMG9+zQ9Q34m pzYFZY0h3fMRUKAUxBo6NW4cI3z5ZyY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C5Se+sjU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674932099; a=rsa-sha256; cv=none; b=UzMbdpl0dJNq15tmwFIHFl3RGuWQtvAeUL6ekjuL0jKt7tvo0SsbI5j2PkP9tvF+HfjerU tPcknhYy8TTOypQiOSNhRX2Kgg62YR/IWYDqSiI4ABKupAuHSLCD+V7UE+T0pIeqM0OJXL igqIYCvqjo7QaqvrC41NOjHTs++ROtw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 856FAB808CF; Sat, 28 Jan 2023 18:54:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5355AC433EF; Sat, 28 Jan 2023 18:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674932096; bh=b3LC7GzJbKCQgoSIJh2AUXE2SY/l0rvrW75DR/3uPMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C5Se+sjU2iJ1IBGxkJQSZfWkUmGEQHJJciDry/WOxVI2jP+O9XwMTS2mYVpstaXFt uTPduMZ46mj9Fonxm3rwvjctPwaGxWGGKIMGM1YkwLcqRVQa/C1/rFgB8I4FTmQM+s 963+jkwhe77UKjqPOMU/JiriyNe4tDkMxp9fCtmfovMgwgId79LSkcbvPdUxzOpgO7 YGPHEleqhN4eIaE9WFuvlgZ9hStjGREK3jjiuNm1NEh3kX8UqtrAbxmxj2BzNqt3nU fHjMOYIpjyENkhMN3mfi5RXwwLCVpfcX9laWQ/68zjHqS81+my3XIjKSIJn2Qh7zps ZQfiYYurRE+4A== From: SeongJae Park To: Hui Su Cc: sj@kernel.org, corbet@lwn.net, alexs@kernel.org, siyanteng@loongson.cn, rppt@kernel.org, bobwxc@email.cn, damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Doc/damon: fix the data path error Date: Sat, 28 Jan 2023 18:54:53 +0000 Message-Id: <20230128185453.131270-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4D05C10000A X-Stat-Signature: ki9npzjo9h7jxpb4y4k1hjof3hqywkeh X-HE-Tag: 1674932099-541789 X-HE-Meta: U2FsdGVkX19wgy8DmXC1mhjL0hmAd+cpbk394GqpK07pGZX6OG+1EhudOOiXrAJKeqBFwHlWYhbinYoPFjs1TnqpPKmRWNbiMRpfg94JoTFZSbe8V7J1WxvkF/mROiA+60QDMM8e9ZgKR0Yq3LU44rQbhKlgu118uiX/e7pSY1QtAhiCQkI+NcE03FI8g6BLfWUpz4YqY/7M5EoOFggXPW+7mcu8tnkfuD6vk8S65UrYaoFrvGAzNVCu5dogi5ODo5yD7Bxwsjr8aVsyGjfDnSS8J9U2APhgRZiWpTVgPk6Wr9vsQgQxtdvWikA5cMwNVrSwWHp/y5Z00WhvwOli2pZO3Vv12dgMUX5ntlxRNQWSeXRerVwJh0YpB5sbqeYs9hSZN8E992qHoDdJa15jPGuMlva2c+/a4dUuXn/JL15jnMyUfhKxvf+RtulrNS5E5imm1JZVu0piZE8n+Dg02cp1ytIDlJwa2lqRIrGyCwizxcJ7b/RlDsjV82E5+GSqQ5s6qjWQbJk4g1QKm9l8ALOcd70sqzJFYvZjx8G77npTf1/ZRzMlxafFz9kruTL8nkVdV4wQvQHb+Fh876ZRPd+um59GcNbTZ+ymq03fPZaIAj5PIGhIQ7WQXo762236cm78KWCFo3eXLwnaPJYg0xVST4sSbidkh7MJgd8FgRIoPx0ZD361HyNpnWo0qw9D7AWSwCtaczqMwlxoDL2HR5zCHqYWfhILp7AIWs4smn+cp+4UUOSd0ux11OeYkqH3Upa/O5a1QelnqEVQx0xdda64Ghwqa1xwGrY9IP8FEhyy/wBQZgA4xaXflwgdsIO/whIV1/2KFqDjtdLuPN5aSOIJnj2oWv4N59Pd+uRem91DrAsanmH71rfdVVhZpDhKmDERpsHj4oC3UZ1BSIrHdfseiMcX1qklieYN3Oh3zkyLhpTrVfQd3aZkmO9Gb5JGTK/omWUmkwXYFS7ss7B RYBeV+9E S3uvIEqm7ZIkXqtcMPRp8ErZibXsWHTPMDbBDurR3hsHRRc6PPTuGMezKGz7ke7EJpXfIazWPTv+FlFWXCVYW5bMKKmHgozrzokxYvDi+XK1MAo99G8DN1PMqE7BMCL/vuMGN8LLwz1HysP+K4AqIZkStKbj2LRsSqpwnWoZb2TbDHfSnJbzDDR5avJfp2C6UGN+CBNBa3lzvkLYXuuaVRBwekIjXWZWksUOxcg3dBaWLS2d0N6X6LoQFobPlG+im9AKpzqpfSsHrXrufsp4tBQmSltttD3vk0ftoKwWCsXEAYv8UmggjdVWVS53/T3DLNiLtPyaCuHUhWlItfZ2p6EwE6OXxT0OXD/4Rh/o/L1xaxgBIvyY/XC4xhLQx1KiQhtbtzB22ZKKR75Iklv9iNNKHKHnl8h5WcBHyO82vUEphZQqDwZVwC2isFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hui, On Sat, 28 Jan 2023 17:11:48 +0800 Hui Su wrote: > %s/modules/module/ > > Signed-off-by: Hui Su Reviewed-by: SeongJae Park > --- > Documentation/admin-guide/mm/damon/lru_sort.rst | 4 ++-- > Documentation/admin-guide/mm/damon/reclaim.rst | 4 ++-- > .../translations/zh_CN/admin-guide/mm/damon/reclaim.rst | 4 ++-- I realized DAMON documentation is also translated for Chinese today! Thank you for letting me know this, and also thanks to the translators! Thanks, SJ > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/mm/damon/lru_sort.rst b/Documentation/admin-guide/mm/damon/lru_sort.rst > index c09cace80651..7b0775d281b4 100644 > --- a/Documentation/admin-guide/mm/damon/lru_sort.rst > +++ b/Documentation/admin-guide/mm/damon/lru_sort.rst > @@ -54,7 +54,7 @@ that is built with ``CONFIG_DAMON_LRU_SORT=y``. > To let sysadmins enable or disable it and tune for the given system, > DAMON_LRU_SORT utilizes module parameters. That is, you can put > ``damon_lru_sort.=`` on the kernel boot command line or write > -proper values to ``/sys/modules/damon_lru_sort/parameters/`` files. > +proper values to ``/sys/module/damon_lru_sort/parameters/`` files. > > Below are the description of each parameter. > > @@ -283,7 +283,7 @@ doesn't make progress and therefore the free memory rate becomes lower than > 20%, it asks DAMON_LRU_SORT to do nothing again, so that we can fall back to > the LRU-list based page granularity reclamation. :: > > - # cd /sys/modules/damon_lru_sort/parameters > + # cd /sys/module/damon_lru_sort/parameters > # echo 500 > hot_thres_access_freq > # echo 120000000 > cold_min_age > # echo 10 > quota_ms > diff --git a/Documentation/admin-guide/mm/damon/reclaim.rst b/Documentation/admin-guide/mm/damon/reclaim.rst > index 4f1479a11e63..d2ccd9c21b9a 100644 > --- a/Documentation/admin-guide/mm/damon/reclaim.rst > +++ b/Documentation/admin-guide/mm/damon/reclaim.rst > @@ -46,7 +46,7 @@ that is built with ``CONFIG_DAMON_RECLAIM=y``. > To let sysadmins enable or disable it and tune for the given system, > DAMON_RECLAIM utilizes module parameters. That is, you can put > ``damon_reclaim.=`` on the kernel boot command line or write > -proper values to ``/sys/modules/damon_reclaim/parameters/`` files. > +proper values to ``/sys/module/damon_reclaim/parameters/`` files. > > Below are the description of each parameter. > > @@ -251,7 +251,7 @@ therefore the free memory rate becomes lower than 20%, it asks DAMON_RECLAIM to > do nothing again, so that we can fall back to the LRU-list based page > granularity reclamation. :: > > - # cd /sys/modules/damon_reclaim/parameters > + # cd /sys/module/damon_reclaim/parameters > # echo 30000000 > min_age > # echo $((1 * 1024 * 1024 * 1024)) > quota_sz > # echo 1000 > quota_reset_interval_ms > diff --git a/Documentation/translations/zh_CN/admin-guide/mm/damon/reclaim.rst b/Documentation/translations/zh_CN/admin-guide/mm/damon/reclaim.rst > index c976f3e33ffd..d15a2f20bb11 100644 > --- a/Documentation/translations/zh_CN/admin-guide/mm/damon/reclaim.rst > +++ b/Documentation/translations/zh_CN/admin-guide/mm/damon/reclaim.rst > @@ -45,7 +45,7 @@ DAMON_RECLAIM找到在特定时间内没有被访问的内存区域并分页。 > > 为了让系统管理员启用或禁用它，并为给定的系统进行调整，DAMON_RECLAIM利用了模块参数。也就 > 是说，你可以把 ``damon_reclaim.=`` 放在内核启动命令行上，或者把 > -适当的值写入 ``/sys/modules/damon_reclaim/parameters/`` 文件。 > +适当的值写入 ``/sys/module/damon_reclaim/parameters/`` 文件。 > > 注意，除 ``启用`` 外的参数值只在DAMON_RECLAIM启动时应用。因此，如果你想在运行时应用新 > 的参数值，而DAMON_RECLAIM已经被启用，你应该通过 ``启用`` 的参数文件禁用和重新启用它。 > @@ -218,7 +218,7 @@ nr_quota_exceeds > 就开始真正的工作。如果DAMON_RECLAIM没有取得进展，因此空闲内存率低于20%，它会要求 > DAMON_RECLAIM再次什么都不做，这样我们就可以退回到基于LRU列表的页面粒度回收了:: > > - # cd /sys/modules/damon_reclaim/parameters > + # cd /sys/module/damon_reclaim/parameters > # echo 30000000 > min_age > # echo $((1 * 1024 * 1024 * 1024)) > quota_sz > # echo 1000 > quota_reset_interval_ms > -- > 2.34.1