From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8BDC38142 for ; Sat, 28 Jan 2023 17:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 383826B0072; Sat, 28 Jan 2023 12:14:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 332F36B0073; Sat, 28 Jan 2023 12:14:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FB4A6B0074; Sat, 28 Jan 2023 12:14:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0ADFF6B0072 for ; Sat, 28 Jan 2023 12:14:53 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CEFA0A0234 for ; Sat, 28 Jan 2023 17:14:52 +0000 (UTC) X-FDA: 80404857624.16.B28027F Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf27.hostedemail.com (Postfix) with ESMTP id 15B0240007 for ; Sat, 28 Jan 2023 17:14:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UJgxHpZR; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674926089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B7+g5VZH5xco/uCd2/vZ4Ceb0RM2/L1oHKtmM7kN3E4=; b=g+UQSRP6m6azO66Ad1qvc/CTsVLoWgl1/OxLtiIX0MEaFpS4+blOfQUPU7txNwX4cUvPzH 66so7okUNQuthZ/vIg4/sFVJ/2d8JwIcZ7/FSJ5eAYLWBSmcIp9PH+kZa9tHZ6aRTgvqmo TAeuAT9RkNJptjkJgnjMQ/3ThI5FDfs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UJgxHpZR; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674926089; a=rsa-sha256; cv=none; b=d+D2RYivI3HOGkNRYh5P9peEuC1rve/pMSo+B3FBGtHyFdSdz/l5rLKSA1EFFDpb4Wg930 6+PiXD9kn0VQdqP3FXhWYA0SDDyf25lBKWmEKQfKpndcy7GPr+pGdL3t0jo+tP/PDbkyG1 B0IxUSYcY3TCFmmIbzBT2CeA86BosfI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674926089; x=1706462089; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6tTRMsYGt6H6KUiFaird/wqszdo9PWRL7bOVgLw4bH8=; b=UJgxHpZRslnwRTNjke41jM8higkhSUyQvoJOUk8tJBMmjK4Unxg52tjk xIXoijBlDZftLe8uHedAG8tVhamdb2unyIX5NbZeK2Qp+ekg67K+Icr0D BVu18C1AaECpu6x1xJ1RaBokY1qlUb/h/yuD6sJQjM+mpZalgr50zDVGS 62BfmvouqQCA3ZUoj+jGVB9FyG4bdkts9cw7v+rraXGrbIuxNcyT0BeGc tsdMBNLFSzx/+lwQ47EAacScxauQx7arIQ2lxPRhOeb+LmvmUYgZv1pXn vj+Bixm4mvajRcJgmWFlk23JiK+071tWatOvtUwTzKv9+u/q8ClDjGXmw w==; X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="310932507" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="310932507" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 09:14:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="732208707" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="732208707" Received: from lkp-server01.sh.intel.com (HELO ffa7f14d1d0f) ([10.239.97.150]) by fmsmga004.fm.intel.com with ESMTP; 28 Jan 2023 09:14:44 -0800 Received: from kbuild by ffa7f14d1d0f with local (Exim 4.96) (envelope-from ) id 1pLomp-0000wP-35; Sat, 28 Jan 2023 17:14:43 +0000 Date: Sun, 29 Jan 2023 01:13:56 +0800 From: kernel test robot To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Matthew Wilcox (Oracle)" , Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] fs: Convert writepage_t callback to pass a folio Message-ID: <202301290130.frg9YGk5-lkp@intel.com> References: <20230126201255.1681189-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126201255.1681189-2-willy@infradead.org> X-Rspamd-Queue-Id: 15B0240007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 1t83uxs63qhdoisfsamd56p636tr6986 X-HE-Tag: 1674926088-88448 X-HE-Meta: U2FsdGVkX1/vhSeeBZY0fZ28vT4CjwBgPBTcJmE3zpD5NxR46xBs6BZE3Oi6wKEHo2zvPpA64dP7YaGJE6oJWpaFXpFi3lw9AtsAYBNGIJ2HpXteKdOvQ8LMA/PaJ8+JALDMYTr9dgNPKx+Rn4DSUb+FJ8o8GfGg53HLc61itVBZRN0wGvlOkfOj2j0xmub15OUBqlgelduK6VoFZ8FHcKtTi8tcQI04BlyQIq8L/HIPNQupXCOEgxwnzz2qgnzuhW6qLwwzVC8tKGDge8PqLPfA4tTxi08e89RzqarxpLxfWGSD2OQ8HzSlkpEl1yMTYmRULdhcV/ejlc1AgZNPf4LupEqFEBKvnCTp8W+ZT2cea9TdM6IXhy0XoobtKgBj812q4NdJDG7TGw+QG7g8kATh2VYInzrBHQ0p6j5I1scdMiqESq0sFszepbWxyg2o8utSoA01bFNZHGSVLyxkkmmwdN1631x7iqfN+mo0qg3JYUFUEmVt8ejqp8NyYuVxNsEjQUHl80kxYAr7EWfYhmeb36iLFd2H1WxzA4nDSVI4Wnas1ObJmBXO65K1YP3OT/CWnhD6a2zF86ifM+crdE1osLOt0gCBdT718SkY9M7Iqt80RC2MtEPdh+P39GCuEkb3Sf0227gc8SdMP8FKN5RfRUzSLzMkoKg1MNO7PjLW3IQXbpasSgsBgbF/KICJ0XNTe39zX+z0uUATE/nD277WDdonS6zLluEc7/lsN3v1mSUgZnopJJ2VsYoc097A+yxo2N3ExtoklLN6OImjfWqvIbEhyuQsD6neByVT8Kc3HwKRJYo43Gm9XRnaS10CFTPWFzyJ6OTefO60L77Rs6ICPbonpCdNLRSYCK4EDvIqWvSmbRAH027JbmARyF3Ya4fI9cl133/wsb00TImZMqzmyLfJFH22UvAFPzVK8SVmnNyP8nHbNQINeariOgaYL+SgMdosN2NuMisX+v+ LwIE8vE4 zOTPjs/q1kRpzNpNGUnbeUXisZ+RmvWK8KzEb+/oQ89N8XE50rpZZNrH8mPaqdCp4eGdy0P1rG5luPH1XyQiAtqgIv6WyNFoh6Pq+FCrrSpuCIQKCwQG6EkfM2Psm9cz9yCAVOcOh8pVDzHLACL7MTBFR4TT1Wad81F6SL26jPAsZLlJqZ09varIYQCmyEUJ+oepQgSNR6/RfzaaxfWogRT+USzULuyS9QUxnajz8f9+Ej51ewMs8QWxbPCFTICoK4bP2S2F7nw9xGNrMj79ygCAvk4wLdBeABetM6SWKt9c/Hu/dKO+v5NMZp5UEB8neWh7q3xu7TUGo0ss9TdMhzbKQBz9B/DsPNSLrnfDCpy7yC+nvuI9nPyjlu5jsMWd9tTE6ugsLyOIcZJhPKCTsJXmSLa4u/2gibxfP37RBXXQhCq/w7SvHZJLRz9lWV75jYLtrR+yjjvmurCx2ACb9b7OtvQVv+/IBQt2hOVm0LR5ka1SVfslIRXkmbt3LujDHkTVX0clVdiqixAo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, I love your patch! Yet something to improve: [auto build test ERROR on next-20230125] [cannot apply to tytso-ext4/dev akpm-mm/mm-everything cifs/for-next mszeredi-fuse/for-next xfs-linux/for-next trondmy-nfs/linux-next hubcap/for-next linus/master v6.2-rc5 v6.2-rc4 v6.2-rc3 v6.2-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/fs-Convert-writepage_t-callback-to-pass-a-folio/20230128-112951 patch link: https://lore.kernel.org/r/20230126201255.1681189-2-willy%40infradead.org patch subject: [PATCH 1/2] fs: Convert writepage_t callback to pass a folio config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20230129/202301290130.frg9YGk5-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/19e834de445f5d3a390fff94320e71e8077ce632 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/fs-Convert-writepage_t-callback-to-pass-a-folio/20230128-112951 git checkout 19e834de445f5d3a390fff94320e71e8077ce632 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash fs/gfs2/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): fs/gfs2/log.c: In function 'gfs2_ail1_start_one': >> fs/gfs2/log.c:143:55: error: passing argument 3 of 'write_cache_pages' from incompatible pointer type [-Werror=incompatible-pointer-types] 143 | ret = write_cache_pages(mapping, wbc, __gfs2_writepage, mapping); | ^~~~~~~~~~~~~~~~ | | | int (*)(struct page *, struct writeback_control *, void *) In file included from fs/gfs2/log.c:20: include/linux/writeback.h:375:66: note: expected 'writepage_t' {aka 'int (*)(struct folio *, struct writeback_control *, void *)'} but argument is of type 'int (*)(struct page *, struct writeback_control *, void *)' 375 | struct writeback_control *wbc, writepage_t writepage, | ~~~~~~~~~~~~^~~~~~~~~ cc1: some warnings being treated as errors vim +/write_cache_pages +143 fs/gfs2/log.c 95ecbd0f162fc0 Andreas Gruenbacher 2023-01-19 91 ddacfaf76dd620 Steven Whitehouse 2006-10-03 92 /** c551f66c5dfefd Lee Jones 2021-03-30 93 * gfs2_ail1_start_one - Start I/O on a transaction c551f66c5dfefd Lee Jones 2021-03-30 94 * @sdp: The superblock 4667a0ec328678 Steven Whitehouse 2011-04-18 95 * @wbc: The writeback control structure c551f66c5dfefd Lee Jones 2021-03-30 96 * @tr: The transaction to start I/O on c551f66c5dfefd Lee Jones 2021-03-30 97 * @plug: The block plug currently active ddacfaf76dd620 Steven Whitehouse 2006-10-03 98 */ ddacfaf76dd620 Steven Whitehouse 2006-10-03 99 4f1de018215fb5 Steven Whitehouse 2011-04-26 100 static int gfs2_ail1_start_one(struct gfs2_sbd *sdp, 4667a0ec328678 Steven Whitehouse 2011-04-18 101 struct writeback_control *wbc, 17d77684088510 Bob Peterson 2021-02-18 102 struct gfs2_trans *tr, struct blk_plug *plug) d6a079e82efd5f Dave Chinner 2011-03-11 103 __releases(&sdp->sd_ail_lock) d6a079e82efd5f Dave Chinner 2011-03-11 104 __acquires(&sdp->sd_ail_lock) ddacfaf76dd620 Steven Whitehouse 2006-10-03 105 { 5ac048bb7ea6e8 Steven Whitehouse 2011-03-30 106 struct gfs2_glock *gl = NULL; 4667a0ec328678 Steven Whitehouse 2011-04-18 107 struct address_space *mapping; ddacfaf76dd620 Steven Whitehouse 2006-10-03 108 struct gfs2_bufdata *bd, *s; ddacfaf76dd620 Steven Whitehouse 2006-10-03 109 struct buffer_head *bh; b1676cbb11153b Bob Peterson 2019-11-13 110 int ret = 0; ddacfaf76dd620 Steven Whitehouse 2006-10-03 111 16ca9412d80181 Benjamin Marzinski 2013-04-05 112 list_for_each_entry_safe_reverse(bd, s, &tr->tr_ail1_list, bd_ail_st_list) { ddacfaf76dd620 Steven Whitehouse 2006-10-03 113 bh = bd->bd_bh; ddacfaf76dd620 Steven Whitehouse 2006-10-03 114 16ca9412d80181 Benjamin Marzinski 2013-04-05 115 gfs2_assert(sdp, bd->bd_tr == tr); ddacfaf76dd620 Steven Whitehouse 2006-10-03 116 ddacfaf76dd620 Steven Whitehouse 2006-10-03 117 if (!buffer_busy(bh)) { 30fe70a85a909a Bob Peterson 2019-11-13 118 if (buffer_uptodate(bh)) { 30fe70a85a909a Bob Peterson 2019-11-13 119 list_move(&bd->bd_ail_st_list, 30fe70a85a909a Bob Peterson 2019-11-13 120 &tr->tr_ail2_list); 30fe70a85a909a Bob Peterson 2019-11-13 121 continue; 30fe70a85a909a Bob Peterson 2019-11-13 122 } 036330c914365f Bob Peterson 2019-04-10 123 if (!cmpxchg(&sdp->sd_log_error, 0, -EIO)) { ddacfaf76dd620 Steven Whitehouse 2006-10-03 124 gfs2_io_error_bh(sdp, bh); 69511080bd6efd Bob Peterson 2019-02-12 125 gfs2_withdraw_delayed(sdp); 9e1a9ecd13b9bb Andreas Gruenbacher 2018-06-07 126 } ddacfaf76dd620 Steven Whitehouse 2006-10-03 127 } ddacfaf76dd620 Steven Whitehouse 2006-10-03 128 30fe70a85a909a Bob Peterson 2019-11-13 129 if (gfs2_withdrawn(sdp)) { 30fe70a85a909a Bob Peterson 2019-11-13 130 gfs2_remove_from_ail(bd); 30fe70a85a909a Bob Peterson 2019-11-13 131 continue; 30fe70a85a909a Bob Peterson 2019-11-13 132 } ddacfaf76dd620 Steven Whitehouse 2006-10-03 133 if (!buffer_dirty(bh)) ddacfaf76dd620 Steven Whitehouse 2006-10-03 134 continue; 5ac048bb7ea6e8 Steven Whitehouse 2011-03-30 135 if (gl == bd->bd_gl) 5ac048bb7ea6e8 Steven Whitehouse 2011-03-30 136 continue; 5ac048bb7ea6e8 Steven Whitehouse 2011-03-30 137 gl = bd->bd_gl; 16ca9412d80181 Benjamin Marzinski 2013-04-05 138 list_move(&bd->bd_ail_st_list, &tr->tr_ail1_list); 11551cf15ecc17 Matthew Wilcox (Oracle 2022-12-15 139) mapping = bh->b_folio->mapping; 4f1de018215fb5 Steven Whitehouse 2011-04-26 140 if (!mapping) 4f1de018215fb5 Steven Whitehouse 2011-04-26 141 continue; d6a079e82efd5f Dave Chinner 2011-03-11 142 spin_unlock(&sdp->sd_ail_lock); 95ecbd0f162fc0 Andreas Gruenbacher 2023-01-19 @143 ret = write_cache_pages(mapping, wbc, __gfs2_writepage, mapping); 17d77684088510 Bob Peterson 2021-02-18 144 if (need_resched()) { 17d77684088510 Bob Peterson 2021-02-18 145 blk_finish_plug(plug); 17d77684088510 Bob Peterson 2021-02-18 146 cond_resched(); 17d77684088510 Bob Peterson 2021-02-18 147 blk_start_plug(plug); 17d77684088510 Bob Peterson 2021-02-18 148 } d6a079e82efd5f Dave Chinner 2011-03-11 149 spin_lock(&sdp->sd_ail_lock); 4e79e3f08e576a Bob Peterson 2020-11-12 150 if (ret == -ENODATA) /* if a jdata write into a new hole */ 4e79e3f08e576a Bob Peterson 2020-11-12 151 ret = 0; /* ignore it */ b1676cbb11153b Bob Peterson 2019-11-13 152 if (ret || wbc->nr_to_write <= 0) 4667a0ec328678 Steven Whitehouse 2011-04-18 153 break; b1676cbb11153b Bob Peterson 2019-11-13 154 return -EBUSY; 4667a0ec328678 Steven Whitehouse 2011-04-18 155 } 4f1de018215fb5 Steven Whitehouse 2011-04-26 156 b1676cbb11153b Bob Peterson 2019-11-13 157 return ret; 4667a0ec328678 Steven Whitehouse 2011-04-18 158 } ddacfaf76dd620 Steven Whitehouse 2006-10-03 159 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests