From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A21AC54EAA for ; Mon, 30 Jan 2023 15:18:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A801C6B0072; Mon, 30 Jan 2023 10:18:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A318B6B0073; Mon, 30 Jan 2023 10:18:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F7E66B0074; Mon, 30 Jan 2023 10:18:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C6D56B0072 for ; Mon, 30 Jan 2023 10:18:14 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3EE6C160AC4 for ; Mon, 30 Jan 2023 15:18:14 +0000 (UTC) X-FDA: 80411821308.13.401BE13 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 0AE6418001C for ; Mon, 30 Jan 2023 15:18:11 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GzSUktuL; spf=pass (imf16.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675091892; a=rsa-sha256; cv=none; b=jqplNvwmM9FM1AdAkUsF851DzVJnYYJiidU3sbbjKhbUP5Mgz3zQZuJ+PJOTRcrNji9pvC xCxE9Q56dVpx3OTBLfSC7WkLcfbMrf5iM9B/S9xR2YDxrNW2Gck3njO/AyKSo14xap0MQ1 L2AZYmnb47WgLxPneZBqcEBL6AsjbZc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GzSUktuL; spf=pass (imf16.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675091892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=URESPY8B3rO6+zudqQ9a2I8Kc4P4ekxUO74igKr3Ygk=; b=029xeVsmSm1pUNTyVsYjk/X13SXI6RWflFYD/ZR5uzjv6yXnO7YWXzPnLGBOoGAktay5gZ K+s8XFRmCULJFqpnxjs4w2mhsjQR5Jr0SPJelFXdzJLZbxPftiZmCRyBPUGM171m0vIIzT zSMfv9exoJCrTxlwAQi0v/BMs516/z8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675091891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=URESPY8B3rO6+zudqQ9a2I8Kc4P4ekxUO74igKr3Ygk=; b=GzSUktuLiu6L3PNAaV4XZt75Ws7Dmnv9PQDjfA3x5vkyjSNSii1VtBo4YsjVJCE/jfiHNn avwG77EF3Q3sKFyQ8OMzaX0XKVEvlED1sWZpoAKF8JNg3SysxRDcGg+A9PPmntSNjNQS1/ nFXejVbRyxTXEcwlWRWR+bRA6HYYyS8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-25-zBQMy617PnGE_k6zs9g7cA-1; Mon, 30 Jan 2023 10:18:07 -0500 X-MC-Unique: zBQMy617PnGE_k6zs9g7cA-1 Received: by mail-wr1-f71.google.com with SMTP id t20-20020adfba54000000b002be0eb97f4fso2020413wrg.8 for ; Mon, 30 Jan 2023 07:18:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=URESPY8B3rO6+zudqQ9a2I8Kc4P4ekxUO74igKr3Ygk=; b=TvsUW2WgNiqR4WgFgZsDdHEOvteLyA+dpJBJUgiwQxXhFCcr97zcJNURonE8Y1v8zm 4oSwxin8X8CTpPoF68+mXso0xWbppGsMSASSN0LygudRwhmzSaoyn/DRzgsD7Zglm7Pw sA3k/p4KyAAuX3Uu3dXF+kdC5mHb4WSWCCcn50U3zL2ORFm7QXFj/JyJCeU0Wu/hnmFZ DTxKZdTqFm2ywsP1Ci15WNmtvExy9Q8qLAOEKOYX1KFLiMtutqAggBAWK0UdAYMVlaKM XFbB0Szl5o/qR6YdMO4rTuxIeqb3720qapXVn/91sjNfPNBUKhUoMPnaCh+a2gv56H8P wgBw== X-Gm-Message-State: AO0yUKUjBRLYk9+7gD8hO2vJayYbdiT6GdO0WrYMyZBT01XmMvgEhPIt lkBKxx3MAC7BhLDfAWZouSfReQg31KUnegNXhcrEm0k6zkuw7pSTXEf5I7yTa3s2KgMGI8CxeBj B0yPobBJp2Fg= X-Received: by 2002:a05:6000:1105:b0:2bf:b77c:df72 with SMTP id z5-20020a056000110500b002bfb77cdf72mr16512216wrw.25.1675091885651; Mon, 30 Jan 2023 07:18:05 -0800 (PST) X-Google-Smtp-Source: AK7set9hHGYe0bnBQdwa2LZ/rAVCRbopEtGk+crtv3OHnMIQTfwimU+PtBLrc1/FzlqOKTq9Gtug2w== X-Received: by 2002:a05:6000:1105:b0:2bf:b77c:df72 with SMTP id z5-20020a056000110500b002bfb77cdf72mr16512171wrw.25.1675091885371; Mon, 30 Jan 2023 07:18:05 -0800 (PST) Received: from redhat.com ([2.52.144.173]) by smtp.gmail.com with ESMTPSA id p6-20020a5d48c6000000b002bfc0558ecdsm11985935wrs.113.2023.01.30.07.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 07:18:04 -0800 (PST) Date: Mon, 30 Jan 2023 10:17:58 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: Jens Axboe , Ilya Dryomov , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/23] virtio_blk: use bvec_set_virt to initialize special_vec Message-ID: <20230130101747-mutt-send-email-mst@kernel.org> References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-10-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20230130092157.1759539-10-hch@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 0AE6418001C X-Rspamd-Server: rspam01 X-Stat-Signature: ei59x7381qjmosazo8nbiraadyqbdhc4 X-HE-Tag: 1675091891-468362 X-HE-Meta: U2FsdGVkX1/VYYxrMAbwe38ZnaIt4zZp+ELL5FiGFgYfa+eCRcJtj3WwjS3bj3lMZDpiRjorQCYBUr1EnMrVhoZ8An3NiR7IEZ6jVVftg60LqaqPjhWprb/LFWRgSqqgo23cslGfxD8JkniUvxj80qRs1v8KxGZT9HzokoLr5KVWBMeq9wZAmaHfkuPmSvIK+rQGT04PVYVWBta06x9ws27tUqaVleXtyPvtqbZTI6a5uzrpAnQvVNokaPCfnPTuuwo3G0UGh1Bg0Kx4qP+vYjzXEpSO5FJJe05VHr350OGubIznMShUwCexFgewOorUxpba6wcrJs+bsjECORKt0EMC6ysNopN1yUopYAKYadOaIfgsTQNJ/w3c8H67M9YdTGEfz4Kq//cn3ay6vHljAQ0fiiFKvV4nq2j84aTHOfow6aqPPOxF0FJxQSrc/jsnabINgXt2BoFston2PdvH8Dt5HNSUdQruU0MXwFSxpviCkllIB6hAuV+an/UlxPdZD7t6v0mXXb4G5+4EVLqg1SCv6OCAC56z9jfnhmoe2CW1lGLoe0IarFwdpWAM3tt/q5QC0BRQSkJhM3wGopFX4Lr5JotPTfk3QPah0LbrYL5CErdGaoLkt2kYH61ul9+Q2dRHcqzMkx+NM+J1/FV/g6ZYw8D2bio6vw6gUQfVwMCx8agLhITURULR8w42vQSJHES/mTYYNkDQzgWn6yv7sbA0ZEEPaavxrxS7U1dNwykMsssRVTfbMZwra5ouakgB8804oQtX70rMcgtAIb2o0RruXM2dxzISoaCjUoL4ARmI4IrcqMlaFtyrkq6gtnybHkvZMIvRgBT81vUjF5vGTFhZILKYlqFin3FcScaYL4Z2xV705o+ktnk5ocX/e/2yvePKD2J6va4X8lcWHDHbFTESFqFiY7jCZ3VBvbRBRkKgNvKj8OkpaLMaGqMy1KsIuqbfWTjYLDqMBhOfpN4 gjk/B6G3 ncei51yc0kGEce8Tv6JbrNw958jqbE1z9TltFVNEM73OiEa5IXOTxlxZgM4saYfudmLKK5N9uBRbDouRL/oHXNjkgM4yLUpm/Fnn5HZf7N7+fZCTKpKTPklOx2AhggwBN2pucbXiTTrzoWs54T+/BRIBUWNGGqUlTZr/QjmadokRNHgFgIvWffK4/AXklykkfh+QoYs1sG3fMS6mJJk9+QMhxmlJ9Nibwvz9G2IvaQYe6X85/1ASbuPQPDxivVJaiceNwADNCfj00vo/wq/1Fbhfkm1Qz6C/nAbv/E32AT4lSIdhgNZ+/MJleAEM9aEiFLWDh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 10:21:43AM +0100, Christoph Hellwig wrote: > Use the bvec_set_virt helper to initialize the special_vec. > > Signed-off-by: Christoph Hellwig Acked-by: Michael S. Tsirkin > --- > drivers/block/virtio_blk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 6a77fa91742880..dc6e9b989910b0 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -170,9 +170,7 @@ static int virtblk_setup_discard_write_zeroes_erase(struct request *req, bool un > > WARN_ON_ONCE(n != segments); > > - req->special_vec.bv_page = virt_to_page(range); > - req->special_vec.bv_offset = offset_in_page(range); > - req->special_vec.bv_len = sizeof(*range) * segments; > + bvec_set_virt(&req->special_vec, range, sizeof(*range) * segments); > req->rq_flags |= RQF_SPECIAL_PAYLOAD; > > return 0; > -- > 2.39.0