From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA6CC54EED for ; Mon, 30 Jan 2023 15:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A64A6B0072; Mon, 30 Jan 2023 10:20:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 156056B0073; Mon, 30 Jan 2023 10:20:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F37F56B0074; Mon, 30 Jan 2023 10:20:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E36D06B0072 for ; Mon, 30 Jan 2023 10:20:04 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A0DA8120724 for ; Mon, 30 Jan 2023 15:20:04 +0000 (UTC) X-FDA: 80411825928.29.2CECCDA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 713E51C001A for ; Mon, 30 Jan 2023 15:20:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZixdiZEH; spf=pass (imf20.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675092002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ah3avzpBOJRu+37auLlVBnHx/4BkYm4lFjO5EaAcHnw=; b=3Z6u0wRxuvYI7yOMswh2dKnBWujEZan3AdiitB4AzHZcCjyWPyv9EnibHdZiur2CjhY+Tl 2bMiFUB417GFhKFDn/eWspNx8/t9oWCbXCNaH+RcPw6s+BhPXi/3MiznZJnMheYg5f1yPC xTDlbAZPsq9b+lVC3ZgwBuVaYFFL0gA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZixdiZEH; spf=pass (imf20.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675092002; a=rsa-sha256; cv=none; b=SgiRm931vwl0bFox3SIfvlU1prF+6jCGMjBM8XC2q3O+qMhxNfJPzBRrOYFAXQjVqCFjX9 OIL4c02fmRW2c+WBVFonBTuqKjjZNFIAwrDEX0O9DiDmJNbadGKhtEM5enpZ7p2Z9ym3Ev 82byp9ulpqONJQVJhWnjzMDs9LOhvTk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675092001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ah3avzpBOJRu+37auLlVBnHx/4BkYm4lFjO5EaAcHnw=; b=ZixdiZEHXlxeG0tPYq9DWxZrGLaFHCbg9yQlNY27GtSmr8gr0MawR+p4NEFdBq7IqUuN6P w7pkxGT70zd1Kqnf/ko7SmX6OSIi1DZP0mTgP74U2UFwV6qrnPueYZ43MnsbVuYQxMEv7j oQItgestrlj5NsvAnvUu9oEL4vTCXcg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-331-jUilLOzqP7qpKECfzYLa9g-1; Mon, 30 Jan 2023 10:20:00 -0500 X-MC-Unique: jUilLOzqP7qpKECfzYLa9g-1 Received: by mail-wr1-f71.google.com with SMTP id y2-20020adfee02000000b002bfb44f286dso2051811wrn.11 for ; Mon, 30 Jan 2023 07:20:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ah3avzpBOJRu+37auLlVBnHx/4BkYm4lFjO5EaAcHnw=; b=S0jvd0dl3yMHHJRk+XQZwQi3xV5TmY1ARLibYMWfxhVJJ1UDLkCktphF47qTSLwOfw SdhisdBE3nbwxe251x4SR7RnA06U9M+ibZrhalP8F0iSk3EQKZAf+wJmqLGXRuiiAhL5 s5gM/sXj4iojTPezKB5lIdUNzIOZ2TyBRZQdVgZalUUNXq9sY1gbFJdCu76WJYuYeYrd RkvCag0XF9CAicNRtuyWjRDGzkBWrBeMPfETn4GqLc4z6S7hCVrxy9ypeXdTC9+VpVEc 7EG0qF6dVRRoBm8y2+NdG8XqVRhab7U85M1a7MIRM+D7PbjLes2M6kDiWMkv7VPR7P1I 1sUg== X-Gm-Message-State: AFqh2krIuouxsrzxn5sMnBPnfrWTRbJLHDR8n+iXrFGquMXkZ5mwwX2G sVLUdMbApHdRDMdKdr+uW3uRZw8TOcLHhw7MU43A1RcaWd0P9yexJmtpqn9aAll5MkFsocq8nSd CZ2DhJ8UeOZo= X-Received: by 2002:a05:600c:1e21:b0:3d0:7fee:8a70 with SMTP id ay33-20020a05600c1e2100b003d07fee8a70mr52242958wmb.19.1675091999190; Mon, 30 Jan 2023 07:19:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXsu1w8+EO1CI/aqnigYPF7jxubbyQ5nAweq8tir4J7qtyJNK1XxMEfGlrHUe8RqvFQGuvEBew== X-Received: by 2002:a05:600c:1e21:b0:3d0:7fee:8a70 with SMTP id ay33-20020a05600c1e2100b003d07fee8a70mr52242919wmb.19.1675091998974; Mon, 30 Jan 2023 07:19:58 -0800 (PST) Received: from redhat.com ([2.52.144.173]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c4e8900b003d990372dd5sm18938810wmq.20.2023.01.30.07.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 07:19:58 -0800 (PST) Date: Mon, 30 Jan 2023 10:19:51 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: Jens Axboe , Ilya Dryomov , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 22/23] vring: use bvec_set_page to initialize a bvec Message-ID: <20230130101811-mutt-send-email-mst@kernel.org> References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-23-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20230130092157.1759539-23-hch@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: b69ow5nhpxkpmoz5hrjtp51ojach1iwg X-Rspamd-Queue-Id: 713E51C001A X-HE-Tag: 1675092002-918932 X-HE-Meta: U2FsdGVkX18KHaMnRWKXnAs+6uFsNZASTE4GVjME72CAqufdPNkMDbgkiBRxW2oNz1x7DHYvrh/EzDW0JnETJ9g9EocTr0fOMHJiYxLt/lg31kf3Gq1ejKlnkj/hR7xXhvri0SJ4AtItp6YDJrvON51lGUbnfGE0OYzvNyokdekbBR00cFeXL67FpbN+Qo8ALd+5+gJ2SAwOkEnTNdyc3uKwGAc4q9uGnwcTabeHzQkgRJ44wHLfAWwJu2MCwsSqJ59oYH3K7WhIziNv95TCYzvg7Oi0QzQYfcrlGqNptde4uFxklaRETFI7G3my5HogcmT0ihqna03KamrMjPdKL2/SxVSvWa00Yd1G7WlvDMAezLuneb8SxRmsXgaALJMtcEdVVT5pxCnlMjSHHRE8DeZUXjjFDoFj/r9kp2fEOyCF9OUF4nxD8O5YrPvqFOGh1jwQ/DH6QZKJiDf3zy+U6cc0AqQxesVCLU8igDAeHeKFcLzKDICGvyhaOs2p1hxvtTa5KiZq5UhsfL3FWLb405SwbxVU9xWHqNRBVMYP7MEWBBcxQIHqUdHIhjovgWgrr6x1vesklSprkdKIrRwrNC5JKUKAv14ta4QgkoYImZYAPSLQnUQYCZ01Qg0LpwvcXs9+3IaEIFmNaiR2EJ5XLhA5VuRpj5ybBJnG1oTE0kiF16POX1eKWvxeii01ozXw7pASdX0e5FUOFGr1Zh1c/ilG1WESG9kc+6Oqj16j5vsZICtqXKreaUQ7BPBiSrMOHRcHTUZ8aPHPY3m2dlDemcH8JQ/3mP9KC2vc2vweF+nl0wK7hFFGQWZTPfRUVRlRLfoodAyH3/OXSB3dT3iK79boqLhZbhQ9hoDeiioZV+OaoNmneN0vHI+ThMdPLMg74l6pH6gGAzeBQkK+xTc2iK4T/azG3jx6v9FudCh4UcviG6cfajPo5wK7B3AL5XTvb7rPUQLPtTgtMGVFM6y 4lH1bYht Mi1YlRO1J+Vi2orzjLd7IyYx2LKncFsWXe27AmoHgcp0suBtpjbveRhctHjlM29CL5u8rNgpiTagFYOhVOTdvLyLyKFkYWJVPhnaCxqUKOzsmK/cM/GV+NRMEl77mf4W1w3CWY0akJzjrcnECCSr0A2rf7EAkpmf4I9oSwjeW1UBGzucPaBmjJrBUPHQQg1G8eBHZMycf+afwIc+VfAStml8uLNkoHHZO5S6CjRabPLKSyXVp3L1XItjsd51vm+7MNtQI4cFD82wXtKAniUR+cJJRB5KsP5hs8oSMN0M2YSE7u0wAaqXvVDqvx0B/NT4wrjS7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 10:21:56AM +0100, Christoph Hellwig wrote: > Use the bvec_set_page helper to initialize a bvec. > > Signed-off-by: Christoph Hellwig Acked-by: Michael S. Tsirkin > --- > drivers/vhost/vringh.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c > index 33eb941fcf1546..a1e27da544814a 100644 > --- a/drivers/vhost/vringh.c > +++ b/drivers/vhost/vringh.c > @@ -1126,9 +1126,8 @@ static int iotlb_translate(const struct vringh *vrh, > size = map->size - addr + map->start; > pa = map->addr + addr - map->start; > pfn = pa >> PAGE_SHIFT; > - iov[ret].bv_page = pfn_to_page(pfn); > - iov[ret].bv_len = min(len - s, size); > - iov[ret].bv_offset = pa & (PAGE_SIZE - 1); > + bvec_set_page(&iov[ret], pfn_to_page(pfn), min(len - s, size), > + pa & (PAGE_SIZE - 1)); > s += size; > addr += size; > ++ret; > -- > 2.39.0