From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E71FC54EED for ; Mon, 30 Jan 2023 10:36:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC65A6B0074; Mon, 30 Jan 2023 05:36:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D501C6B0075; Mon, 30 Jan 2023 05:36:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17EF6B0078; Mon, 30 Jan 2023 05:36:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AE4356B0074 for ; Mon, 30 Jan 2023 05:36:26 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 71D1BC0946 for ; Mon, 30 Jan 2023 10:36:26 +0000 (UTC) X-FDA: 80411111172.08.0805F7C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id BC14580002 for ; Mon, 30 Jan 2023 10:36:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675074984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvQv6Gvrh93BfEGP4pGR6LDQtNde77dAGMLN49gb1bk=; b=q3mi0ydNXVCF7vVpi7kYviQ1iU5NVKSwddy1DOp+BAawc7FtbPxWY2E5NWbN5Qxv97Kojn rQJcb5Brr4MLTkkKPmj+0GTHk0MMV0pAbTBERuzYNfHF+oZv6MU5mnBwJ3AsDAr2Girqt0 cT+U/Jt4Vhm1/LjHHHi7OFIuELeuxRc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675074984; a=rsa-sha256; cv=none; b=zoahh/C+OY1ybkq8ONxOKlLz9Y4HXrHjblbh2iI7yi4EWyWr1Ef5aQTTC1emVUrH2rcKL4 bo+/FaRxfOp8Gfcym77MxYbX432sKBWuiaYhyghT6nBNeDnPVCaXjYaeGJyN3XU4Nl1AaM +HbCqAa3hoZi+J1x0omz7XPz4lDjyP0= Received: by verein.lst.de (Postfix, from userid 2407) id DCD3968D07; Mon, 30 Jan 2023 11:36:19 +0100 (CET) Date: Mon, 30 Jan 2023 11:36:19 +0100 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Message-ID: <20230130103619.GA11874@lst.de> References: <20230130092157.1759539-2-hch@lst.de> <20230130092157.1759539-1-hch@lst.de> <3347557.1675074816@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3347557.1675074816@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BC14580002 X-Rspam-User: X-Stat-Signature: ipbdzyshoaa69hzk8qh7yd6gkxigfxx6 X-HE-Tag: 1675074984-249535 X-HE-Meta: U2FsdGVkX19VwP1Ke2oECpgGxfJBgVJowSjESdyaq+4z4ivvJmg02nIYQb6CxfLhGEBvR/Uaam4F0i/XaNmcTU3V7PpMJg/rYmJXdTkod/J7EXsIfF0zS9UkcbLiSzTcYHPninfFUThWqyG/pit0ksG1PHLJVKZKjMti3seL4SDRCENYY6JZDTZ3GVJ0PatuY+BPkRAgO5mU6d579cuWV0uv5X5i4IoeHfJyJL9FYwkT19A4qy+of5x6MI9w+CYLO7DhxDu7VaSIhXY5sh6B2EMgS4E8hvJ0KVND6+YRdptV5eO46ZXB3EzBK/UQ/65ArEu02HmI2fESqAnQZka2DFsbw3dkCEWb3dA/sSdbLUBIYPBiQipsZnyaM0BsSyhwffhZbug8BG+nWMnnl4M5htEBh0gfL7weLdF8s2zEQMppRAPyB0k2kPOi4YYXTtRJ7H13Qaidz71mBWnC44NwijIAkpJy+gkjUGIKiO16xby9RoZ/NFXhEXZIGE0Gxh37xE6LwFBkE5QcJ0dVpS/NxWigG2dBl4oULzNjLoPuX7NAoNv/PB4jSe/Jluf2OEluYmOqVITdKUaekDIdWT/QrginVWiH4CjOPM9kJXJgvaPAmRIsAT37r+OsWyrqxp0G9dcwUVvggQ99psLTnE64lZHNd3c8NCFXWqjhUG364xxj02dormIX6gft68Dzh2LsvwiLC01JjVQdZXh3RJfM4uyjubAVhMm7zd00+HwdKJLeahpttmwJQhwTK96pv3mB0px7aiJ4OqeimxsZ9Brj6GvBZs9h9AxsYn5TfCpmQh2uSrwanHeF2Yz8ewXzwj/GbKIVNiloPgFrjwBByZeFuCHELN2HM+eIisOFICjMg456a0vXoB3oWWpHVRpSor2FMzmreocP6HqCKW4WF/g7+QTQMR0czFhneB4WDKyInunsjFfvpzmnrLFl40lxTKWHo46okQcPFUL6WqbESZz NaMnKvWy AmNPmiHMTVrB5YQziGdFT7h2jS88p3S5WhJyHPJY5Hm0eiKPVhKoPks0IT9gXgMFH75whgfiPU/PVv/xrbcJblF7tzaY3PcLtkZoNghSdeeqy34n7eFDLMW5iAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 10:33:36AM +0000, David Howells wrote: > Christoph Hellwig wrote: > > > +static inline void bvec_set_page(struct bio_vec *bv, struct page *page, > > + unsigned int len, unsigned int offset) > > Could you swap len and offset around? It reads better offset first. You move > offset into the page and then do something with len bytes. This matches bio_add_page and the order inside bio_vec itself. willy wanted to switch it around for bio_add_folio but Jens didn't like it, so I'll stick to the current convention in this area as well.