From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34734C38142 for ; Tue, 31 Jan 2023 05:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6667C6B0072; Tue, 31 Jan 2023 00:52:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63E496B0073; Tue, 31 Jan 2023 00:52:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52D206B0074; Tue, 31 Jan 2023 00:52:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4441D6B0072 for ; Tue, 31 Jan 2023 00:52:08 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 000AE803EA for ; Tue, 31 Jan 2023 05:52:07 +0000 (UTC) X-FDA: 80414023494.10.ACF8D7E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 3CC1FC0009 for ; Tue, 31 Jan 2023 05:52:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ppdnbqD0; spf=pass (imf22.hostedemail.com: domain of kuba@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675144326; a=rsa-sha256; cv=none; b=htPu3SxV9hXMuFlWOVOgRGxOcRR+lalKtVsdI8OTsqJXPngRLhRPwT4DTig1xI83xOum0T Rw+w3ouHCG4KdkN8nGYmqufxFypJ+xkUysOYT09MkkK6QZ4aChyMC4SvyQbtmDkx7th3GU 1i4oez6LEmq3xl4MMBTifDDh4/pPgxY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ppdnbqD0; spf=pass (imf22.hostedemail.com: domain of kuba@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675144326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NYB4tcZ/ctiqnrZ+rs70HwQd98W6+GsZfJSaCIS4MZQ=; b=AjiDFov6anNjQ7bA7QMC4HjbVmPSCOuLRVnHmqcw28aqSsVeI9wleBaeanPZZWFQkbpbAy s7kgQetasYh9Uxc/nyO6W9vqt2kdILc5P4hCeoweXcrJQYkSI60T99uyjsd91IlWzFyw5P uFqhaJUIYl93emAE0ByYMYfgvc4Lwck= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD43CB819D6; Tue, 31 Jan 2023 05:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 037AAC433EF; Tue, 31 Jan 2023 05:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675144323; bh=wTgpW3dGevgcZKu/B5uphunmPqdkcXShhOveP7IOk1g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ppdnbqD0OAQMoEFgckylfI9L515y55Qro5OxF6u1pWh6KN8rP49ITU+tmDJReCtYg uQEeXluan0n2M2y3H2IKqnNt4YOlz8jwX7u0nMfjRxTYGr9dErSmaz8bAWMZdZliaT yK5TbcOOdTMAfCsWcsLkPqtdk4JC4UgRM6mrK5iKICBsPSiHKOliUIEebepQtdOaXI tynKkh7UvcMYmjAMiRxIUzmwY8hVKbiPo8rdHiCFAGgrt56xYFFXfRVdhTq+KXclxy 7Q9dga8dFPK/VTZRd/v+Q9bPtWy8ipxJ6FaihlxkJ25ft0o8OM2rPTvLq4dSPbibET smIB6luOzvshw== Date: Mon, 30 Jan 2023 21:52:00 -0800 From: Jakub Kicinski To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Message-ID: <20230130215200.0d0eaf66@kernel.org> In-Reply-To: References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> <20230130204758.38f4c6b9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3CC1FC0009 X-Rspamd-Server: rspam01 X-Stat-Signature: 1wraa9o9tsuui76jzf4i5c4oht3yfujs X-HE-Tag: 1675144326-371976 X-HE-Meta: U2FsdGVkX1/4rVmd5vBcp8hq0y3fkQmLTwMkPVQRnuxMj7ugzLrh3CiUJ46w3GNNBXP+sdAqwnCwJEAPq5syvuQ/JMt81jixq/lEZmnbewAsNRWH1Pyt5vTXIB4jA9/tviIEfFEd5o9ttnpOms23NcjD2SYvGpTuaxOSPErGkCFDcNvYiDdmxaKS6u71bFMu13c2TpJiRoKHlfp4vA6fc1ZXQzYLlgqmhWkX3GtRFTnUHM+bRLIE03mJfhfU9EPKRj1MdoQH7fmZD/bNbLTsCnv16SW3D65P+ggrazQx9shpelANQR3i6SsLjTillUXlIrRuZYJhau2zhJ5blCE9rk5f3qwtQBj+eApBpFgts+SV9/SaWiP5SuvjXKx/flOnpNSSWRbdYvxBkofngf8wKVjMuh+RtK3qAtQNgdDZFtt57p5YR8U0omxoSE0HHGtWQzKBMATaEJ5CdfjJkfBO5ueHtvtLyVbb4G64xeFtFLgJD2jK775opSrwVmmSw3sUuCbcagBQ0CdbDiW5LMKBxLE4+q4Jybmb+AjEmlF7gARPMnpV5iFzl8JrsLTOm0rg3RkeshyrAGG/hAdxSUVmCWz5PdMGmdYI4M7a4XqStpor+on48ODkZi8fdMhWhlHW0JYi0tCRbyKwlC3V3ZFbkhO/+KylTo+5Afko4QEgi9QUT2/xlBmWEvekIpPc7Wd2OLyIFsae/8Dw+IF7onq84btzXPHNA6xYwyqNnbBd49stRvqshOFVyAi0OdTmJ10zErgBeaqMNhbSyeYDfVUly7kVPger88+18JqAhI/ctXpT8RIGajiumH1TTlY5aX0Oe/Y1RwTlhJ0u6JZ5vXlTurqCK+PhwPSZf10V9E7G3tVxWFE1pn1rSj4jT3s6qnDB7CZlkVwmQ5GAdcua2g2uGdiBhKlR5IiBaFolPt4piKFbRGO3yFBwPKLbCCTYbOvacYK5eJErLjtrdMAJw8O ZsGjcyNO lm96suRilj4dveDZtAqZjBS8OrHZ+RMNsz3jAmrpd3zblYklOGnnPpCHCAa4y4ehdjlDqeoewmJo5k5odmCwntIfSnXDlLYsOaRChFjoS7Uiyk8TQ/co/PfO0Wh8Oz7eVJir497/FZ6lQOar6FS5u0d/mVGwKH7iazqcx7eGVKz+Oh/9HxxoPfLH5JuBDANWsNgvTsfcWwTuVOvoo1dcS/YCzg8OVKYMcyxAlio+Fn5NODTjucVRr+hLU/JTUP7ogaOu01AnlCV6HQNcfOqYHrs/jKaRFado8Ywqw7CDkD4yeXvYITu5Gd06ytJIJqxslA+AHNKnGeADzrUosZsLzvhKrLYduK+OLGSj9U8Y8Inj1ekI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 Jan 2023 05:28:19 +0000 Matthew Wilcox wrote: > > I bet we can drop mm.h now. It was originally added for nth_page() > > in 3d75ca0adef4 but those were all removed by b8753433fc61. > > > > A quick smoke test on my default testing config doesn't find any > > problems. Let me send a patch and see if the build bots complain. > > Disappointingly, it doesn't really change anything. 1134 files > depend on mm.h both before and after [1]. Looks like it's due to > arch/x86/include/asm/cacheflush.h pulling in linux/mm.h, judging by the > contents of .build_test_kernel-x86_64/net/ipv6/.inet6_hashtables.o.cmd. > But *lots* of header files pull in mm.h, including scatterlist.h, > vt_kern.h, net.h, nfs_fs.h, sunrpc/svc.h and security.h. > > I suppose it may cut down on include loops to drop it here, so I'm > still in favour of the patch I posted, but this illustrates how > deeply entangled our headers still are. +1 it's a bit of a chicken and an egg problem. Until mm.h is gone from bvec there's no point removing other headers which pull it in to skbuff.h.