From: Ira Weiny <ira.weiny@intel.com>
To: Sumit Garg <sumit.garg@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org,
linux-mm@kvack.org, Jens Wiklander <jens.wiklander@linaro.org>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Ira Weiny <ira.weiny@intel.com>,
John Hubbard <jhubbard@nvidia.com>, Mel Gorman <mgorman@suse.de>
Subject: [PATCH v2 4/4] mm: Remove get_kernel_pages()
Date: Fri, 03 Feb 2023 20:06:35 -0800 [thread overview]
Message-ID: <20230203-get_kernel_pages-v2-4-f1dc4af273f1@intel.com> (raw)
In-Reply-To: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com>
The only caller to get_kernel_pages() [shm_get_kernel_pages()] has been
updated to not need it.
Remove get_kernel_pages().
Cc: Mel Gorman <mgorman@suse.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
include/linux/mm.h | 2 --
mm/swap.c | 30 ------------------------------
2 files changed, 32 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 8f857163ac89..2041e6d4fa27 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2095,8 +2095,6 @@ int __account_locked_vm(struct mm_struct *mm, unsigned long pages, bool inc,
struct task_struct *task, bool bypass_rlim);
struct kvec;
-int get_kernel_pages(const struct kvec *iov, int nr_pages, int write,
- struct page **pages);
struct page *get_dump_page(unsigned long addr);
bool folio_mark_dirty(struct folio *folio);
diff --git a/mm/swap.c b/mm/swap.c
index 70e2063ef43a..4c03ecab698e 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -158,36 +158,6 @@ void put_pages_list(struct list_head *pages)
}
EXPORT_SYMBOL(put_pages_list);
-/*
- * get_kernel_pages() - pin kernel pages in memory
- * @kiov: An array of struct kvec structures
- * @nr_segs: number of segments to pin
- * @write: pinning for read/write, currently ignored
- * @pages: array that receives pointers to the pages pinned.
- * Should be at least nr_segs long.
- *
- * Returns number of pages pinned. This may be fewer than the number requested.
- * If nr_segs is 0 or negative, returns 0. If no pages were pinned, returns 0.
- * Each page returned must be released with a put_page() call when it is
- * finished with.
- */
-int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write,
- struct page **pages)
-{
- int seg;
-
- for (seg = 0; seg < nr_segs; seg++) {
- if (WARN_ON(kiov[seg].iov_len != PAGE_SIZE))
- return seg;
-
- pages[seg] = kmap_to_page(kiov[seg].iov_base);
- get_page(pages[seg]);
- }
-
- return seg;
-}
-EXPORT_SYMBOL_GPL(get_kernel_pages);
-
typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio);
static void lru_add_fn(struct lruvec *lruvec, struct folio *folio)
--
2.39.1
next prev parent reply other threads:[~2023-02-04 4:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 4:06 [PATCH v2 0/4] Remove get_kernel_pages() Ira Weiny
2023-02-04 4:06 ` [PATCH v2 1/4] highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings Ira Weiny
2023-02-04 6:50 ` Christoph Hellwig
2023-02-04 18:37 ` Ira Weiny
2023-02-10 21:59 ` Andrew Morton
2023-02-13 15:53 ` Jens Wiklander
2023-02-04 4:06 ` [PATCH v2 2/4] tee: Remove vmalloc page support Ira Weiny
2023-02-04 6:51 ` Christoph Hellwig
2023-02-06 6:16 ` Sumit Garg
2023-02-13 15:54 ` Jens Wiklander
2023-02-04 4:06 ` [PATCH v2 3/4] tee: Remove call to get_kernel_pages() Ira Weiny
2023-02-04 6:51 ` Christoph Hellwig
2023-02-06 6:17 ` Sumit Garg
2023-02-13 15:55 ` Jens Wiklander
2023-02-04 4:06 ` Ira Weiny [this message]
2023-02-04 6:51 ` [PATCH v2 4/4] mm: Remove get_kernel_pages() Christoph Hellwig
2023-02-06 6:17 ` Sumit Garg
2023-02-10 21:59 ` Andrew Morton
2023-02-13 15:55 ` Jens Wiklander
2023-02-04 19:50 ` [PATCH v2 0/4] " Linus Torvalds
2023-02-06 6:22 ` Sumit Garg
2023-02-07 16:19 ` Ira Weiny
2023-02-10 20:27 ` Ira Weiny
2023-02-13 15:02 ` Jens Wiklander
2023-02-13 18:53 ` Ira Weiny
2023-02-13 19:02 ` Linus Torvalds
2023-02-14 8:53 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203-get_kernel_pages-v2-4-f1dc4af273f1@intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=hch@lst.de \
--cc=jens.wiklander@linaro.org \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).