From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E63C636CD for ; Sat, 4 Feb 2023 06:50:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C682E6B0074; Sat, 4 Feb 2023 01:50:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C18856B0075; Sat, 4 Feb 2023 01:50:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D7B6B0078; Sat, 4 Feb 2023 01:50:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F8656B0074 for ; Sat, 4 Feb 2023 01:50:09 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 65834120832 for ; Sat, 4 Feb 2023 06:50:09 +0000 (UTC) X-FDA: 80428684938.03.0445693 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id 4E4831C0011 for ; Sat, 4 Feb 2023 06:50:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675493407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=duGkjpnQoh2R+oHe4eNdsMuvEQ+jkOvxNlcCdNhySxo=; b=dU5q5CE4sP7R5UYdpXquxdudkPvIdPD6QpVrvEfydnRS0mefj6Q8Pyty9GX1T7mQVClhit B0P0VRYQU6NNVI6HDu7DGk/nWv63zK3ggsJcB+m2vwyAE1pMrLKyGLVgaZ0wbi8XzlfqNZ beDIeEk+VyhFOFd98ge1iNdswwJWk4w= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675493407; a=rsa-sha256; cv=none; b=tbTB9kJc4tkNqTwAg/6LvRqM2PWzoDFnTHoB/I3hIcfxVIKA5syyERzbYogPQcfR4+JQ/F 304iN2HHn41z0Nt1l2Pam5nuwG4Q+bsUa91b+SeN2Cud+BDE1sYJL1O0hVYLO8HY+WldxU JYO2ZJ4Ikekkut9DWTh3DESeEyouQtU= Received: by verein.lst.de (Postfix, from userid 2407) id 641E467373; Sat, 4 Feb 2023 07:50:02 +0100 (CET) Date: Sat, 4 Feb 2023 07:50:01 +0100 From: Christoph Hellwig To: Ira Weiny Cc: Sumit Garg , Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, Jens Wiklander , "Fabio M. De Francesco" , John Hubbard , Matthew Wilcox , Thomas Gleixner Subject: Re: [PATCH v2 1/4] highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings Message-ID: <20230204065001.GA18482@lst.de> References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> <20230203-get_kernel_pages-v2-1-f1dc4af273f1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203-get_kernel_pages-v2-1-f1dc4af273f1@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: ax1j3ubub5bbbfjkm9grrtjrsusw89ww X-Rspam-User: X-Rspamd-Queue-Id: 4E4831C0011 X-Rspamd-Server: rspam06 X-HE-Tag: 1675493407-251884 X-HE-Meta: U2FsdGVkX1+LsUC0/fquMd0ehynOkm90Rfyjbfbp7hUtKqzo7IErZI3ApSkkuSXpJOC7LWEF4XgRJ8rEwGpQJh5EjXK6QXxekiw8Z/Vr5ku9R3zw73gw5j2Q+8CL2Sbz8bosuceDLG/BsFqLpFiEPz2d000tj4tpLbMCbtdGy1Yfzdvoej4MSnctWbjKtDuP6VG0QPmdzNSMxs1WWjS+KeKMvB6jzNz5GNCbxnX3EZEPxeoIOTn1RaeSY9Posp7X82c4eGJYqListtutYZ1LE5euo+nQKgWXVWuGlAklx5gfjY6qGGtjbqfCAtwXNAIoFUYompHLHXtJEubpmVJORrgzimyX9LJWbSba6k1ZdPOtQhzqEVjDd7NdThew/a8j1O8LsOu9Ok3pY4IoGYwfEIc5IFZKhdEBy4Gd9MO0ETOZaTWfOzLAp+O29K85YpcZFQJ+lxmSx9jcreYyoHPwqmbZ1uRpvMzUHCrm/1CepLp22o5AD4J2AGCnX5KqmCmHGEUPbEU0IVFObYukcp95vNXlL0XTLA6wtGqKdus+cFdmFyroYcUHnD4ZZsutRIz/D8ZcyRxz1k1KiS2grFulNAyF1ApM58DAIcpRFpXYv3y+8odO/NyeeuBYvLmNRaU2AklfjEQCIgdtPBeAqkwIf6Z0dVikCTytemwTiv7gV8604mIGflCEoy25dqa3Tb3mdwc7Xh+wsZHU2nOgsKOh3eVTvpI2L53ck2gbExKiRtb81e6zfkCVduP+VDSXg0hWh2HAswzrzSW4hsf3M7qNLacO8dMo23xtqkD2VR5errssVjsVDwvIh2mXWG98VA6RLetfGqWL1erCiUXLRfUp4Fb31/wIyiVXGLgZB+omI2oWyMYjMhJHECbO3BlEBs10PinUKgQxqvnBNlU5Og5uBDNLxjrxb/kLi1BdNMfwex6Ok9Lpy9bnX6gACtb51kgO2qHhu5Rtk5ToXB2+o6z PIzJ2NDb Jmy9wqDy1SbV9H0XMnN7bbJebTh7PP75HW6hJVfGvoY8BC+y20IPty+XITrT1ZxcVcru3VVINqtOF+CABIL/AELLL8T/R4T8p/xiFSJLFNNCeIldOb1uRm/V6bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 08:06:32PM -0800, Ira Weiny wrote: > - return addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP); > + > + return (addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP)) || > + (addr >= __fix_to_virt(FIX_KMAP_END) && > + addr < __fix_to_virt(FIX_KMAP_BEGIN)); Isn't the second check inverted?