From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCCDC636CD for ; Sun, 5 Feb 2023 23:17:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D11BB6B0072; Sun, 5 Feb 2023 18:17:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC0ED6B0073; Sun, 5 Feb 2023 18:17:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B88A16B0074; Sun, 5 Feb 2023 18:17:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A5AB76B0072 for ; Sun, 5 Feb 2023 18:17:12 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6F9F81202D3 for ; Sun, 5 Feb 2023 23:17:12 +0000 (UTC) X-FDA: 80434801104.27.3E2C1EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 82058C000E for ; Sun, 5 Feb 2023 23:17:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gLAF8qii; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675639030; a=rsa-sha256; cv=none; b=7t2zJU5wGp3SRHSetqy+l1VBPLcfFXr2NHJcJCxI9xmR9Ml9NpYlOKDKW6KaEY19oiXndu rLpx5fvFI//IvO/Extn0wyT/crTpK+NjMBMizddK84Akt6NMeNPMx77Be+sGvfR5JLygoq dNfBjyERBNgjA+/B8SkO8I6siaQ5f0I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gLAF8qii; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675639030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=hczbFL+ar/tk/IYpzPCczVyi3teFQZrB1wxKh73TL0g=; b=GiKX2qlmhUArxPEbkBOL921Jm1OEc0NZ4G1yWJpGIPLk2nEX7++7OI59V1YkD5wTW0l76l E8s5CNtvA322uC7vV3XgUzlk16Nop7WuDC7c3wkH4WKQ0ISj3KP/4SQyeVk9SVZyRxHbiC f5SCC3IVgCfKdOtCAES/M9MZnPZ4Vx8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675639028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hczbFL+ar/tk/IYpzPCczVyi3teFQZrB1wxKh73TL0g=; b=gLAF8qii/iuEwBLmyjF0T1Y6jdTmzsBC9JuY0dGdh0wfaJT5S3EVu2dbG1NVRhRY5s3/qE N9oJQO4aR+tuSd4Tv5avZh18HY12a1KQrdBvMwzPxV/1bAT0qOGIqGET5XMhUQDeqVv7Qx TiHo+i9cLl60RIy6ikPdU2GrH0/l5dA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-373-mS5UfA25OpWInLQYeDcs4g-1; Sun, 05 Feb 2023 18:17:07 -0500 X-MC-Unique: mS5UfA25OpWInLQYeDcs4g-1 Received: by mail-qk1-f199.google.com with SMTP id x17-20020a05620a449100b00731b7a45b7fso2026884qkp.2 for ; Sun, 05 Feb 2023 15:17:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hczbFL+ar/tk/IYpzPCczVyi3teFQZrB1wxKh73TL0g=; b=5Vdmvw/aRjIWUmsYDSsg2REdx1gw75yU9FEWsUF1fVI1vorjynAXmGgUZfMibmJuxp tO3hmNAnijScwFIH1vQTu3WnqoS8EZaGBHrOVInz+oTmcNP65agLVCopGNCAwg4XILl6 K3OtKP6mH3u5Hsc7nYkjNHUsUq4Xy1Isl4TGqmvBuMDl/GLYJ5w4FMWHz7jH2+M9vTeq 5HUcSVAZtxZgXmACOXOUoy5hn/weR46KY6wvlfslVMJmg+Klfn4LLM0/8BbFI9ev5e1q yDAsCvY/NBeiMw3+9bkWQmEG/7CwigTTYoRUOtkcZUCeNyyRfZjhsjyRyw+xif8pxvOd yB3Q== X-Gm-Message-State: AO0yUKWvSZ1C0/xjWZTSayV5NtOx++vtkA3gF1hi3wirbHgzBmrLwkAi ETOE9MNZYr7YauRU9wNxorWgCfld2KCL0q3R9yN55Yz3m5fgiMRBIJy/q9cCFnOvY0QF94Qa/C1 brsdsevRrktUihe33Bydrjzr/NdAJ49PcXgZ7GVT5v8a8l9b/JUHlcXx2sptW X-Received: by 2002:a05:622a:a15:b0:3b8:695b:aad1 with SMTP id bv21-20020a05622a0a1500b003b8695baad1mr31166812qtb.1.1675639026525; Sun, 05 Feb 2023 15:17:06 -0800 (PST) X-Google-Smtp-Source: AK7set/sbA75b0Czo2TaDI7H5+UellOBQzwBIsx8AnsLPSQNhM0IiyfwrSSGN0x0tfL39bKfeNgbnw== X-Received: by 2002:a05:622a:a15:b0:3b8:695b:aad1 with SMTP id bv21-20020a05622a0a1500b003b8695baad1mr31166787qtb.1.1675639026141; Sun, 05 Feb 2023 15:17:06 -0800 (PST) Received: from x1n.redhat.com (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id h26-20020ac8515a000000b003b82cb8748dsm5986545qtn.96.2023.02.05.15.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 15:17:05 -0800 (PST) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: peterx@redhat.com, Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: [PATCH 0/3] mm/arch: Fix a few collide definition on private use of VM_FAULT_* Date: Sun, 5 Feb 2023 18:17:01 -0500 Message-Id: <20230205231704.909536-1-peterx@redhat.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 82058C000E X-Rspamd-Server: rspam01 X-Stat-Signature: 6ftd8f3ub54uub37469bu311q8wguaqb X-HE-Tag: 1675639029-308196 X-HE-Meta: U2FsdGVkX1++9A248KMLSWvpUWFASVP9p7CeMHJTECocN8BTixG2jKz8aHQxsTcALlZO69uRF5RrQ2xcgObAj7TSayhSFAmTVqnkyWzW65Zlvw419Lk6X06q1A70SsIBDuZue+hv1CYiZFRGZNHG7LXxLHXB6S8O/e0xn9lGAdMVnsmkr2FdJkk4NkBvZ3X59hFN8+sQB9Iqd6r35HLMcRRveoBBD7wkLYC/A+ggkwyKFx6zGm38IvblFcvCsR64PjedZU8bIqya0muT/y92pulWhdHxmKZvFIalfBkyPTMdbLQQNHSiHoBq3gfRZkC53hTFdUulKe0dPmTGDWl1Vhs4EH+6aWU7UJ9RszZshsXwYLScQ0AgeEvNKdhIuXg98nSkbj+Y58mOg5KGuywALjGIrNTy+hMLURtlMxe5UUmR9r6KCMfROUagcKXf1GCOp1XRfGaXLpJLyWnW2BnCWPwjeYeIv1i5iEIoyrdxjyB9Tp06q8MEkz2pZ//Ds1Sy/jt+BdjOUDpgDqMLTJb0dRKbjz+LBOjm1NvicXEKtPNko64Jx1YBQfLgk5rnAka1gsGhUHQ0YWttMWS9rAcKKnm/RTTNKVSfPl2P+fPMo3Tiu2jcZRTVA0VBcaNY4IIb4lFZSGpKJuxFxLG1Yg765ipKBufV/X781TMYYgf1VUCBIogN5h8w5JzCnAML7AzUAXK0DX/3dtwismun0BOF0cvLg7HsGzR1KTEM0CJATvYX5y5TnkuU0BVFf/8/I2CFUPhZdeOG226J48fplhUxlHCxwNGwmiXuVBFmAIg9m8OabeT7DM4fDo1ISAruWrLdtiErKkd9McKEWqJxddOCghgZHq6L5Re9zzycfv4+PW0At9ZT6aS4v6Db3tM3gR4wcpdTKAgcFiigbP94t4+tP53R5JzUMpy+8hLcKXpMqh1TMrNGGm20m4dQIqosHXpUaR242a0xOCaeYo8S/Zd v/I5ZZd3 H9kq2ZGd++FnKQJSAE6PDBueIpYPAYGLAHEoZvqf2Yw3jjhPNrkU5I3//kRfI0gIMJ9TzlddNlwIzBh3TsaRuWQELxBX/JDUZAYOwpQy+dBtU7D8biGhZ82I2aLHhWclnO/19cFZ6jHrFaiMVhXgM5oQRB9lKITnMZDfEiKFxvtYST6gndM7NUQjPAEsrc9tgyt0BkXvyxQ3PgZewBi1FpT026gIg2nIOoxDoSK+arMTwi+8PYN3N0xzRx5X3Cnum5EzxPHTEi4Q5LB/F0GKM4THAS5s6CVrQ0lV2/ImkOMUzBx0nfdzk9C9auUoNfD2/hIJeHIsC5cbTFCUSTUiKjVLyiJAZEPGzi4bluKDb5FTzHLHrem/r+wtyKGDoYQ442glwWm6tVSJa5e34TQG3PwJBKcqi3RivbajviJffh4av30M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I noticed a few collision usage on VM_FAULT_* definition in the page fault path on arm/arm64/s390 where the VM_FAULT_* can overlap with the generic definition of vm_fault_reason. The major overlapped part being VM_FAULT_HINDEX_MASK which is used only by the hugetlb hwpoisoning. I'm not sure whether any of them can have a real impact, but that does not look like to be expected. I didn't copy stable, if anyone thinks it should please shoot. Nor did I test them in any form - I just changed the allocations from top bits and added a comment for each of them. Please have a look, thanks. Peter Xu (3): mm/arm: Define private VM_FAULT_* reasons from top bits mm/arm64: Define private VM_FAULT_* reasons from top bits mm/s390: Define private VM_FAULT_* reasons from top bits arch/arm/mm/fault.c | 8 ++++++-- arch/arm64/mm/fault.c | 8 ++++++-- arch/s390/mm/fault.c | 14 +++++++++----- 3 files changed, 21 insertions(+), 9 deletions(-) -- 2.37.3